[Device Plugin] Kobo Touch Extended Driver - Page 172

redlob · 07-09-2021, 01:58 PM

Quote:

Originally Posted by DNSB

See the first message in this thread if calibre has not noticed you that a new version of the Kobo Touch Extended driver is available. See message #2556 for the release announcement.

Whoops, totally missed that. I installed 3.5.1 now, restarted Calibre but it still crashes.

I noticed a pattern though.

Say I have 20 books. I send the first 10 books to the device and all is well. When I send the last 10 books, Calibre crashes.

After restarting Calibre I tried to send those last 10 books first because I suspected one of them might be corrupt, but all went well. Then I sent the first 10 books and Calibre crashed again.

When I send them one by one, all is fine.

jgoguen · 07-17-2021, 05:16 PM

New version posted, fixing an issue with exceptions being thrown in subprocesses when functions should have simply returned instead.

jgoguen · 07-17-2021, 05:17 PM

Quote:

Originally Posted by redlob

Whoops, totally missed that. I installed 3.5.1 now, restarted Calibre but it still crashes.

I noticed a pattern though.

Say I have 20 books. I send the first 10 books to the device and all is well. When I send the last 10 books, Calibre crashes.

This sounds like it might be tough to replicate, but can you restart calibre in debug mode, reproduce the problem, and paste your debug log?

ownedbycats · 07-18-2021, 04:46 PM

Quote:

Originally Posted by DNSB

See the first message in this thread if calibre has not noticed you that a new version of the Kobo Touch Extended driver is available. See message #2556 for the release announcement.

For what it matters, the plugin page is still showing 3.4.4. I think i recall something about a scraper updating that page so I wonder if something broke.

DNSB · 07-18-2021, 05:06 PM

Quote:

Originally Posted by ownedbycats

For what it matters, the plugin page is still showing 3.4.4. I think i recall something about a scraper updating that page so I wonder if something broke.

Not sure if this has anything to do with it, but the plugins I checked had the version in the __init__.py file while the KTE and Kepub Output have the version in common.py. This likely is not the issue since I vaguely remember the version is now supposed to be updated from the spoiler in the first post.

jgoguen · 07-18-2021, 05:12 PM

There was an issue with the version being indirect a while back but Kovid fixed that. There's a thread in the main calibre forum asking about this in case it's a problem again.

jhowell · 07-18-2021, 05:14 PM

The version spoiler in the first post is used and must be formatted exactly as expected with the content indented. That is not the case for this plugin.

jgoguen · 07-18-2021, 05:15 PM

What's wrong with it? In the editor it's formatted the same as previous versions that work.

DNSB · 07-18-2021, 05:20 PM

Quote:

Originally Posted by jhowell

The version spoiler in the first post is used and must be formatted exactly as expected with the content indented. That is not the case for this plugin.

Looking at a couple of other plugins, the content is not indented though the comments are in lists.

chaley · 07-18-2021, 05:23 PM

Quote:

Originally Posted by jhowell

The version spoiler in the first post is used and must be formatted exactly as expected with the content indented. That is not the case for this plugin.

I think that the version in the zip file is used, but I could easily be wrong.

BetterRed · 07-18-2021, 06:21 PM

Quote:

Originally Posted by chaley

I think that the version in the zip file is used, but I could easily be wrong.

Yep - the plugin index was simplified in Nov 2020. However the Updater has sourced the version number, author etc from the plugin's __init__,py modules for much longer than that, sample attached.

BR

chaley · 07-18-2021, 06:27 PM

Quote:

Originally Posted by BetterRed

Yep - the plugin index was simplified in Nov 2020. However the Updater has sourced the version number, author etc from the plugin's __init__,py modules for much longer than that, sample attached.

BR

Reading the source, it appears that the updater looks at __init__.py for the reference to a plugin base class. If it doesn't find it then then it looks at the imports. Once it finds a class that inherits from a plugin base class then it looks in that class for the author/version info.

My problem is that I can't actually see what the updater generates so I am not sure of my assertions.

BetterRed · 07-18-2021, 07:10 PM

Quote:

Originally Posted by chaley

Reading the source, it appears that the updater looks at __init__.py for the reference to a plugin base class. If it doesn't find it then then it looks at the imports. Once it finds a class that inherits from a plugin base class then it looks in that class for the author/version info.

My problem is that I can't actually see what the updater generates so I am not sure of my assertions.

This plugin's __init__.py file is nothing like the one I posted.

BR

DNSB · 07-18-2021, 09:24 PM

@BetterRed: So moving the version information into __init__.py should correct the issues that are being seen?

Looking at the information in the Index of Plugins thread, I found it rather unclear whether the information was still being extracted from the plugin.zip file or was being scraped from the Version History spoiler.

To wit:

Quote:

The index underwent a format revision in late November 2020 to remove the fields that are extracted from the plug-ins themselves, viz:

chaley · 07-19-2021, 04:49 AM

Quote:

Originally Posted by BetterRed

This plugin's __init__.py file is nothing like the one I posted.

BR

It isn't necessary to put the information in __init__.py. It must be in the plugin subclass. I think that the subclass must be imported by __init__.py, but I am not sure of that.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Kobo Device Driver Update	davidfor	Devices	284	05-24-2019 05:24 PM
[Device Plugin] Kindle 2, 3, 4, Touch Device Interface MBP Update Mod	cryzed	Plugins	7	10-28-2012 04:58 PM
[Device Interface Plugin] Update for Nook Color Driver	jmricker	Plugins	0	10-22-2011 10:11 AM
Touch Kobo Touch Extended 2 Year Warranty - Is it worth the $34.99?	EverC	Kobo Reader	11	08-31-2011 11:47 PM
Touch Kobo Touch Extended Warranty Program	SensualPoet	Kobo Reader	1	07-17-2011 04:08 AM

07-17-2021, 05:16 PM	#2567
jgoguen Generally Awesome Person Posts: 1,100 Karma: 2191133 Join Date: Jan 2013 Location: /dev/kmem Device: Kobo Clara HD, Kindle Oasis	New version posted, fixing an issue with exceptions being thrown in subprocesses when functions should have simply returned instead.

07-18-2021, 05:12 PM	#2571
jgoguen Generally Awesome Person Posts: 1,100 Karma: 2191133 Join Date: Jan 2013 Location: /dev/kmem Device: Kobo Clara HD, Kindle Oasis	There was an issue with the version being indirect a while back but Kovid fixed that. There's a thread in the main calibre forum asking about this in case it's a problem again.

07-18-2021, 05:14 PM	#2572
jhowell Grand Sorcerer Posts: 7,086 Karma: 91577715 Join Date: Nov 2011 Location: Charlottesville, VA Device: Kindles	The version spoiler in the first post is used and must be formatted exactly as expected with the content indented. That is not the case for this plugin.

07-18-2021, 05:15 PM	#2573
jgoguen Generally Awesome Person Posts: 1,100 Karma: 2191133 Join Date: Jan 2013 Location: /dev/kmem Device: Kobo Clara HD, Kindle Oasis	What's wrong with it? In the editor it's formatted the same as previous versions that work.