[GUI Plugin] Annotations

[bernard.ryefield]

Originally Posted by davidfor

Attached is a beta that will hopefully fix some recently reported problems. And some small changes for the Pocketbooks.



The changes are:

• Update: Minor changes for PocketBooks support - Thanks to @wold.
  
• Fix: Error "TypeError: unhashable type: 'SortableTableWidgetItem'" when importing from Kindle. This was reported on GitHub.
  
• Fix: Change some handling of confidence generation as some devices have already matched the books. This hopefully solves @bernard.ryefield's problem.
  

As usual, if there are any problems, please report them here.

No improvement here

[davidfor]

Originally Posted by bernard.ryefield

No improvement here

Did you try hitting escape or enter when this hangs? It has that sort of feeling of a dialog somewhere off the screen. I also added a couple of debug statements that should help clear up were it is stopping. Can you try debug mode again?

[bernard.ryefield]

No key nor mouse action is possible. As I wrote the plugin is stuck at 0% on the "Compiling annotations for a book" window (only visible when the mouse pointer is on Calibre in the task bar).

[squizzie]

Originally Posted by davidfor

@squizzie: That looks like a calibre version compatibility issue. I will have a look and see if I can solve this. But, it would be better if you upgrade calibre. If you are stuck on the 3.x versions of calibre, then I recommend installing 3.48. That is the last 3.x version and should be the best version to use. It is also the version I will do my compatibility testing with.

thanks - I was hesitant to update because I didn't want to upset the other plugin I was using, but have done so now anyway and am still having problems. The error message is now:

calibre, version 5.17.0
Error fetching annotations: <p>Unable to fetch annotations from Amazon Kindle.</p>

Traceback (most recent call last):
File "calibre_plugins.annotations.action", line 324, in fetch_device_annotations
File "calibre_plugins.annotations.action", line 1080, in process_selected_books
File "calibre_plugins.annotations.action", line 503, in generate_confidence
TypeError: unhashable type: 'SortableTableWidgetItem'

[squizzie]

Originally Posted by davidfor

@squizzie: That looks like a calibre version compatibility issue. I will have a look and see if I can solve this. But, it would be better if you upgrade calibre. If you are stuck on the 3.x versions of calibre, then I recommend installing 3.48. That is the last 3.x version and should be the best version to use. It is also the version I will do my compatibility testing with.

following my prior post, I realise too that I've assumed that a full update is going to work, but since you do your testing in 3.48 is it simply better for me to just roll back to that version?

[DNSB]

Originally Posted by squizzie

following my prior post, I realise too that I've assumed that a full update is going to work, but since you do your testing in 3.48 is it simply better for me to just roll back to that version?

The 3.48 version is used for testing compatibility not development. Version 4.23 would also be a version that would be used for compatibility testing. Most of the testing efforts are likely to be on the current calibre version.

[JSWolf]

Originally Posted by squizzie

following my prior post, I realise too that I've assumed that a full update is going to work, but since you do your testing in 3.48 is it simply better for me to just roll back to that version?

You cannot go back to 3.48. Calibre 5.x updated the database format and 3.48 is not compatible. The oldest version that is compatible is 4.23.

[ilovereading.com]

Hi techperts

I only recently discovered this plugin and it has been a lifesaver for me on my Kobo Aura (the original one) so thanks to the creator/s of it.

However, with some books, it only pulls through the chapter heading for the location of the relevant annotation and whatever comment I made, but not the actual highlighted text- and only with some of them not all. So I have a few books where it has pulled through all the annotations, but some of them don't show the relevant text that it is for.

I hope I've explained in a way that makes sense, does anyone have any idea about this please?

TIA

[davidfor]

Originally Posted by ilovereading.com

Hi techperts

I only recently discovered this plugin and it has been a lifesaver for me on my Kobo Aura (the original one) so thanks to the creator/s of it.

However, with some books, it only pulls through the chapter heading for the location of the relevant annotation and whatever comment I made, but not the actual highlighted text- and only with some of them not all. So I have a few books where it has pulled through all the annotations, but some of them don't show the relevant text that it is for.

I hope I've explained in a way that makes sense, does anyone have any idea about this please?

I have had some reports of missing annotations but have not been able to see why. Does the highlighted text show in the annotations list on the device? You can make a bookmark and add a note later. That does not have any highlighted text, so it is a valid situation when the plugin is working.

To be able to investigate, I need a debug log from calibre with some details of what is missing. For that, it is the book name and chapter that is missing the text. And are you looking at the preview window or after the annotations have been added to calibre? It will also help to see the database from the device. With that I can compare the log with what should be happening and see if there is something unusual about the database entry.

[Savate]

HI

I just get 'unable to fetch annotations from Kindle' when I select import annotations. The annotations are present in preview but plugin will not import. Have used plugin successfully in the past but doing some catching up. Plugin stubbornly refusing to cooperate!

Any advice? Thanks.

Have reinstalled plugin - no change
Calibre v5.22.1
Kindle Voyage v5.13.6

[davidfor]

Originally Posted by Savate

HI

I just get 'unable to fetch annotations from Kindle' when I select import annotations. The annotations are present in preview but plugin will not import. Have used plugin successfully in the past but doing some catching up. Plugin stubbornly refusing to cooperate!

Any advice? Thanks.

Have reinstalled plugin - no change
Calibre v5.22.1
Kindle Voyage v5.13.6

Can you try the beta version posted on the previous page? That has some changes that might solve this.

If that doesn't help, please turn on the debug option in the plugins configuration and run calibre in debug. After trying to fetch the annotations, close calibre and post the debug log for me to look at. Hopefully that will tell me what the problem is.

[Savate]

Thank you - that update (1.15.2) seems to work fine.

[prs350]

Greetings all - an issue with the plugin when trying to export annotations from an epub on a Sony PRS-350 (I didn't see in the previous 64 pages and apologize if I missed). And can confirm that it also occurs under Linux (can provide the error for as well). I realize it's an old reader, but if it can be made to export, it'd save me from buying another:

calibre, version 5.23.0
ERROR: Unhandled exception: <b>AttributeError</b>:'NoneType' object has no attribute 'execute'

calibre 5.23 embedded-python: True is64bit: True
macOS-10.16-x86_64-i386-64bit Darwin ('64bit', '')
('Darwin', '20.5.0', 'Darwin Kernel Version 20.5.0: Sat May 8 05:10:33 PDT 2021; root:xnu-7195.121.3~9/RELEASE_X86_64')
Python 3.8.5
OSX: ('10.16', ('', '', ''), 'x86_64')
Interface language: None
Successfully initialized third party plugins: Annotations (1, 15, 0) && Sony PRS-T1 notes plugin (1, 1, 0)
Traceback (most recent call last):
File "calibre_plugins.annotations.action", line 364, in fetch_usb_connected_device_annotations
self.fetch_usb_device_annotations(primary_name)
File "calibre_plugins.annotations.action", line 392, in fetch_usb_device_annotations
annotated_book_list = self.get_annotated_books_on_usb_device(reader_app)
File "calibre_plugins.annotations.action", line 606, in get_annotated_books_on_usb_device
ra.get_installed_books()
File "/var/folders/qg/270jyqsn4hzcpdpgn4n18cjr0000gn/T/calibre_annotations_plugin/Sony.py", line 219, in get_installed_books
AttributeError: 'NoneType' object has no attribute 'execute'

[DNSB]

Originally Posted by prs350

Greetings all - an issue with the plugin when trying to export annotations from an epub on a Sony PRS-350 (I didn't see in the previous 64 pages and apologize if I missed). And can confirm that it also occurs under Linux (can provide the error for as well). I realize it's an old reader, but if it can be made to export, it'd save me from buying another:

Could you try installing the beta version in message #945 in this thread and see if it works for you.

[davidfor]

Originally Posted by prs350

Greetings all - an issue with the plugin when trying to export annotations from an epub on a Sony PRS-350 (I didn't see in the previous 64 pages and apologize if I missed). And can confirm that it also occurs under Linux (can provide the error for as well). I realize it's an old reader, but if it can be made to export, it'd save me from buying another:

calibre, version 5.23.0
ERROR: Unhandled exception: <b>AttributeError</b>:'NoneType' object has no attribute 'execute'

calibre 5.23 embedded-python: True is64bit: True
macOS-10.16-x86_64-i386-64bit Darwin ('64bit', '')
('Darwin', '20.5.0', 'Darwin Kernel Version 20.5.0: Sat May 8 05:10:33 PDT 2021; root:xnu-7195.121.3~9/RELEASE_X86_64')
Python 3.8.5
OSX: ('10.16', ('', '', ''), 'x86_64')
Interface language: None
Successfully initialized third party plugins: Annotations (1, 15, 0) && Sony PRS-T1 notes plugin (1, 1, 0)
Traceback (most recent call last):
File "calibre_plugins.annotations.action", line 364, in fetch_usb_connected_device_annotations
self.fetch_usb_device_annotations(primary_name)
File "calibre_plugins.annotations.action", line 392, in fetch_usb_device_annotations
annotated_book_list = self.get_annotated_books_on_usb_device(reader_app)
File "calibre_plugins.annotations.action", line 606, in get_annotated_books_on_usb_device
ra.get_installed_books()
File "/var/folders/qg/270jyqsn4hzcpdpgn4n18cjr0000gn/T/calibre_annotations_plugin/Sony.py", line 219, in get_installed_books
AttributeError: 'NoneType' object has no attribute 'execute'

Firstly, this is the first time someone has actually reported using the plugin with a Sony device. The support was taken from someone elses code with a few changes. I don't have a Sony device and couldn't test it properly. It was done in response to a request, but, there was no feedback.

That looks like the plugin could not find the database on the device. Could you post the full path to the database on the device? It looks like it should be "database/books.db". And if you could run calibre in debug mode and post the log, that would help me validate what the plugin is seeing. There is also a debug option in the plugins configuration. Please turn that on to show exactly what the plugin is seeing.

Also, could you install the beta that @DNSB pointd to. There should not be any differences that affect this, but, there are enough changes in the other code that this should help track what is happening.