[GUI Plugin] Action Chains

[ownedbycats]

Minor UI bug with the new version on Dark Mode

[ownedbycats]

I have this template for single field edit an integer column:

program:
	if raw_field('#percentread') ==# '0' then '1'
	fi

However this turns everything else into undefined. I noticed the template tester returned a blank value when making the template but i was not expecting it to change.

This worked and did not change other values:

program:
	if raw_field('#percentread') ==# '0' then '1'
	else raw_field('#percentread')
	fi

Is this expected behaviour? I would think that unless the template had else '' for a deliberate null the user would want it to remain the same. Though perhaps it can't tell the difference between a deliberate null and no output.

[capink]

Yes, that is the expected behavior. The plugin actions do not know anything about the template, they only know the output of the template expression. If the output of the template is an empty string '' or a null, it will set the column to undefined.

The onus is on the user to write template that returns the correct value.

[ownedbycats]

That makes sense.

Also, is it expected for identifiers to be absent from the column list in single field edit?

[capink]

Originally Posted by ownedbycats

That makes sense.

Also, is it expected for identifiers to be absent from the column list in single field edit?

Never thought about the identifiers. Maybe I will add them in future releases

Originally Posted by ownedbycats

Minor UI bug with the new version on Dark Mode

Attachment 185990

I tried dealing with colors in dark mode for a specific widget (in the Import List plugin) and I failed. I don't think the result is going to be different this time. I do need help with this.

The new combobox was changed into a tree view so that if in the future other plugins provide actions, they will be displayed in a hierarchy (Third Party Plugins Actions > Plugin Name > Action Name). Custom Actions can also be displayed in tree view by setting the attribute display_tree. If I cannot solve this issue I will have to revert to original combobox where all items are displayed in one list view.

[ownedbycats]

Thank you

[ownedbycats]

Also, would it be possible to grey out the configuration button when there is nothing on an action to configure? I think the only thing that does this is user modules though.

[capink]

Well, it is not a real button, just a drawing. The settings dialog actually opens in response to clicking the cell containing the fake button.

For technical reasons I was not able to have a button inside the qtableview behave as I wanted. So, I did this hack and it took me long time to figure out how to draw it, so I am probably not going any further than this.

I generally struggle much with the whole painting, colors, drawing .... etc.

[chaley]

Originally Posted by capink

I tried dealing with colors in dark mode for a specific widget (in the Import List plugin) and I failed. I don't think the result is going to be different this time. I do need help with this.

This works for me.

Action Chains.gui.misc.StandardItem

class StandardItem(QStandardItem):
    def __init__(self, txt=''):
        super().__init__()
        self.setEditable(False)
        self.setText(txt)

In general you shouldn't change fonts and colors unless you have a good reason for it. Calibre goes to a lot of trouble to get things right in both dark and light themes.

If you do want to change colors then you should decide what to do depending on QApplication.instance().is_dark_theme. You will also probably want to override the data() method in QStandardItem to return the colors you want depending on what is being shown.

[capink]

Thanks a lot for taking the time to help with this. I have already posted a modified version containing the fix.

[chaley]

Originally Posted by capink

Thanks a lot for taking the time to help with this.

You are welcome. Ask anytime.

I have struggled with Qt's graphics and widgets for years and have reached an only moderate skill level. Kovid's help has been invaluable. It is only fair to pass it on.

[ownedbycats]

[ownedbycats]

Is it possible to toggle hiding a certain category in the tag browser using a module? (e.g. using the event manager to unhide "Kobo Collections" when a device is plugged in then hiding it again when it's ejected).

[chaley]

Originally Posted by ownedbycats

Is it possible to toggle hiding a certain category in the tag browser using a module? (e.g. using the event manager to unhide "Kobo Collections" when a device is plugged in then hiding it again when it's ejected).

There is no API, public or private, to hide and unhide tag browser categories.

[capink]

Version 1.4.2

• Update: Single Field Edit: Add identifiers.
• Fix: bug when deleting multiple non-contiguous rows.