[GUI Plugin] Favourites Menu

[JimmXinu]

Originally Posted by JSWolf

I cannot speak about the Py3 part, but the test version is working on 4.8.

[JSWolf]

Originally Posted by JimmXinu

I did install the portable version of 4.99.3 and gave it a quick try. It seemed to be working. I've since uninstalled 4.99.3 due to issues with some plugins I use that have not yet been converted,

[JimmXinu]

Originally Posted by JSWolf

I did install the portable version of 4.99.3 and gave it a quick try. It seemed to be working. I've since uninstalled 4.99.3 due to issues with some plugins I use that have not yet been converted,

Fair enough, thanks. I'm not using it much yet either.

[JimmXinu]

FYI, noting this here because I just discovered it:

The 2nd point below also applies to translated strings. But using the .favourites_menu_unique_name property mentioned would mean that Favourites would not benefit from translated strings.

In practice, I don't think it's a big deal for anyone who chooses one language and sticks with it. But it did surprise me while testing translated language support.

Originally Posted by kiwidude

Notes for other plugin developers

1. As of v1.0.3 Favourites Menu will support a plugin with its menus being rebuilt every time it is displayed (such as to enable/disable items based on the current state of calibre). The pattern for this is that your InterfaceAction class should have a .menu property representing the QMenu, and you will ordinarily have code hooked to the aboutToShow signal. When the Favourites Menu plugin is asked to dropdown will iterate through all of the child plugins it is being asked to display items for and (once per plugin) emit the iaction.menu.aboutToShow signal for any plugins that have such a .menu property.
2. If your plugin changes the name of a child item dynamically this can cause a problem for the Favourites Menu plugin (as it uses the text name displayed by a plugin as part of the "key" identifying a menu item). For instance the Reading List plugin includes a count of the items in a child list for some of its actions. To ensure such menu items can be supported by the Reading List plugin, you should simply assign a constant identifying name for the menu item to a .favourites_menu_unique_name property on your qaction at the time you create it. The Favourites Menu plugin will look for such a property being present and use that in preference to the current text name if it is present.

[jpijper]

Is there a way to assign a keyboard shortcut to the favourites menu?

[JimmXinu]

Not currently.

I thought it would be easy to add code to allow it, but it turns out it isn't. Or at least, I'm not figuring it out.

It's the difference between a menu and a direct action. I can't find a single example in Calibre of a menu that can be invoked by a keyboard shortcut instead of an action in a menu.

Which makes sense in at least one regard: Where would the menu come up? Usually the menu is anchored to where it's invoked in the toolbar, menubar or context menu.

I'm not going to work on this anymore--unless someone else can tell me how to do it. (And it's relatively easy.)

[BetterRed]

Originally Posted by JimmXinu

<snip>

Which makes sense in at least one regard: Where would the menu come up? Usually the menu is anchored to where it's invoked in the toolbar, menubar or context menu.
<snip>

had that discussion with kiwidude.

Originally Posted by jpijper

Is there a way to assign a keyboard shortcut to the favourites menu?

FWIW: I have the Favourites plugin menu as the topmost item in the book list context menu.

BR

[jpijper]

Originally Posted by JimmXinu

Not currently.

I thought it would be easy to add code to allow it, but it turns out it isn't. Or at least, I'm not figuring it out.

It's the difference between a menu and a direct action. I can't find a single example in Calibre of a menu that can be invoked by a keyboard shortcut instead of an action in a menu.

Which makes sense in at least one regard: Where would the menu come up? Usually the menu is anchored to where it's invoked in the toolbar, menubar or context menu.

I'm not going to work on this anymore--unless someone else can tell me how to do it. (And it's relatively easy.)

Thanks for going to all this trouble. I can live without it, but for a keyboard guy like myself it would have been nice

[jpijper]

Originally Posted by BetterRed

FWIW: I have the Favourites plugin menu as the topmost item in the book list context menu.

Thanks for this tip! This way I can reach the favourites menu using just the keyboard. If only my laptop had a menu key ... Shift-F10 is a combo that for some reason my fingers always find troublesome

[BetterRed]

Originally Posted by jpijper

Thanks for this tip! This way I can reach the favourites menu using just the keyboard. If only my laptop had a menu key ... Shift-F10 is a combo that for some reason my fingers always find troublesome

One handed shift+anykey are a no-go combo for me, because it has a menu key is one of the reasons I have a Surface Go.

BR

[ownedbycats]

Any idea why the Library Codes menu items would not work right in the Favourites menu?

Discussion in the LC thread starting here with more details: https://www.mobileread.com/forums/sh...76#post4061276

[BetterRed]

I think this issue is related to this plugin.

I set my interface language to French and switched to my test library in order to respond to a problem in the Viewer sub-forum.

I forgot to switch back to English before trying to use calibre, I wanted to switch to my Books library, so I tapped the context menu key, then right arrow, which resulted in this



The Quick switch, Switch create library…, EpubSplit, and Quality Check options are disabled - as evidenced by missing icons .

When I switched back to English the Quick switch option was restored, but Switch create library…, EpubSplit, and Quality Check remain disabled:



In guess I'll have to completely remove Favourites and set it up again.

BR

[JimmXinu]

Interesting.

I assume it has something to do with FM remembering the string which then changes with language.

However, I would have expected them to start working again when you switched back to the language you originally configured them with.

I'll look into it, see what I can figure out. Probably tomorrow tho.

[BetterRed]

I'm attaching the Favorites json file. Nothing leapt out at me.

No hurry.

BR

[BetterRed]

damn being a minimalist, I'd forgotten I removed the EpubSplit and Quality Check plugins

I was able to remove the dead Switch/create library… option in plugin configuration and add it back again.

There is a difference in the old and new json files, viz:



Sorry for the false alarm. Snookered by my own off break - the language switch Maybe a msg could be popped if an item in the plugin's json can't be mapped to a valid target action.

BR