[GUI Plugin] Reading List

[ownedbycats]

Originally Posted by snarkophilus

I've got a local change to this plugin that adds "move up/down 10" and "move to top/bottom" buttons as my reading list now has about 200 entries and adding something new to the list but wanted to move it to the top was a little painful to say the least.

Is there any interest in these changes? If so, what's the best way to share them? I can do a unix style diff or just post my working ZIP file of the plugin. Note that I couldn't find any existing button images for the new buttons, so I've made up some very average looking ones myself.

The GitHub is here so perhaps if you submitted a pull request Jim would incorporate it?

[JimmXinu]

I basically never use that dialog, so I don't have a strong opinion.

I will point out, however, that you can easily move the bottom entry to the top of the list by selecting all the entries *except* the last one and click the 'move down' button. Now the last is first.

[snarkophilus]

Originally Posted by ownedbycats

The GitHub is here so perhaps if you submitted a pull request Jim would incorporate it?

Ah cool, that makes it easy. Will have a go at that. Thanks!

[snarkophilus]

Originally Posted by JimmXinu

I will point out, however, that you can easily move the bottom entry to the top of the list by selecting all the entries *except* the last one and click the 'move down' button. Now the last is first.

Oh that's an interesting way of doing it. A little more tedious but gets the same results overall.

I still like the workflow of my patch (requires much less thought to use) so I'll have a go at making a patch against your github repo. Maybe someone else can even make better looking buttons .

Edit: If nothing else, having my patch in github will make updates easier for me even if no one else uses the change anyway!

[snarkophilus]

Jim- I think I've sent a pull request? I'm still a bit new with the whole git way of life. I'm not expecting you to do anything with it straight away, even if just because the button icon changes will be controversial .

If anyone else wants to have a look, what's changed is here.

[JimmXinu]

I did look at it and give you some comments: PR #1

I think your icons are fine, it's the bugs that concern me.

[dunhill]

I see that the plugin does not have support for translations, I offer to translate it, if you wish.

[JimmXinu]

If you are saying you want to add the code to support translations, you're welcome to give it a try.

If you're asking me to do the code changes so you can contribute a translation, I don't have the time or interest right now. Sorry.

[snarkophilus]

Originally Posted by JimmXinu

I did look at it and give you some comments: PR #1

I think your icons are fine, it's the bugs that concern me.

I never thought to test it with an empty list! I've been using this for 6 months maybe and haven't noticed any problems, but only ever on a long existing list. Thanks, will have a look.

[ownedbycats]

I decided to repurpose the Column Update Options:



I would have expected this to remove any value in the #kobocoll (tag-like) column. It didn't. Is it even possible?

[JimmXinu]

No, RL isn't going to glob for you.

[ownedbycats]

Ok. Thank you. I'll just set up a column icon to remind me to manually remove it.

[ownedbycats]

Btw what does glob mean in this context?

EDIT: Ah, Wiktionary informs:

(programming) A limited pattern matching technique using wildcards, less powerful than a regular expression.

Do regexes work in that field?

EDIT: I tried a simple [a-z]. Seems not. Worth a try anyways.

[compurandom]

Originally Posted by ownedbycats

Btw what does glob mean in this context?

glob * is equivalent to regex .* (mostly)

[JSWolf]

Glob = A lump of a semi-liquid substance