[GUI Plugin] Reading List

[compurandom]

Originally Posted by davidfor

To me that is very deliberate. The purpose of that type of list is to be able to see what books are on the device when it is not actually connected.

The existing behaviour could be done just by having the pulldown set to add/remove rather than add only.

This looks like a bug to me -- if you're going to ignore the option in the pulldown, then grey out the pulldown like is done for the next section. The surprising behavior is to ignore the pulldown.

I was hoping to have it add tags when a book is seen on the device, but let me manually remove the tag (or delete the book from calibre) if the book is removed from the device. With it forcing this behaviour, I have to manually add a separate tag to every book that is added so I can tell when it has been deleted.

[davidfor]

Originally Posted by compurandom

The existing behaviour could be done just by having the pulldown set to add/remove rather than add only.

This looks like a bug to me -- if you're going to ignore the option in the pulldown, then grey out the pulldown like is done for the next section. The surprising behavior is to ignore the pulldown.

All those things could be done. But, I was basing my comments on my understanding of how the plugin works, plus the code that @JimmXinu posted. That code is very deliberate. And it uses a parameter to a method that is not used anywhere except in those lines. In fact, it looks like the parameter was added specifically for this.

But, overall, it doesn't worry me that much. I don't use that type of list. The fact that it changes the modified date every time the device is connected drove me nuts when I did use it.

[JSWolf]

Originally Posted by davidfor

All those things could be done. But, I was basing my comments on my understanding of how the plugin works, plus the code that @JimmXinu posted. That code is very deliberate. And it uses a parameter to a method that is not used anywhere except in those lines. In fact, it looks like the parameter was added specifically for this.

But, overall, it doesn't worry me that much. I don't use that type of list. The fact that it changes the modified date every time the device is connected drove me nuts when I did use it.

I use this type of list. But I only have a Y/N column. All I want to see is what's on my H2O. I see no need to see when it was put on the H2O.

[JimmXinu]

@compurandom's interpretation seems to me to be most technically accurate, if you take the time to think about it deeply. (OTOH, I also suspect that compurandom may be the only user in the world who wants it to work that way.)

I also don't want to deal with the inevitable users who fiddled that 'modify type' setting and left it on something other than 'add or remove' and suddenly don't get the behavior they had before.

RL already had a migrate_library_config_if_required() method built-in. The most logical thing to do may be to use that to force-change all pre-existing pop-from-device lists to 'add or remove' to match prior behavior and then honor the modify action setting.

[JimmXinu]

New Test Version Attached

- Honor modify action setting on device pop lists.
- Force pre-existing lists to TAGADDREMOVE to match prior behavior.
- Disable series labels too when series settings disabled.

This seems to me to be the best compromise. But then, I don't use device populated lists for anything.

[ownedbycats]

I use the Reading List series column feature (mostly for column icon and sorting purposes).

To test some FFF metadata settings and search & replaces I duplicated a few books. Some of them had populated series column. I removed the books when I was done. I just remembered that editing that column directly shouldn't be done though. I'm not sure if duplicating books counts.

Is there a way to check that I didn't break anything? Reading List > View list shows all the books are on the list.


EDIT: Also, I set a keyboard shortcut to add a book to the reading list. However every time I use it it refreshes the tag browser (e.g. if I have selected things in it the pluses and minuses go away, and also temporarily glitches the Job Spy user category icons). Is that supposed to happen?

[JSWolf]

Originally Posted by JimmXinu

New Test Version Attached

- Honor modify action setting on device pop lists.
- Force pre-existing lists to TAGADDREMOVE to match prior behavior.
- Disable series labels too when series settings disabled.

This seems to me to be the best compromise. But then, I don't use device populated lists for anything.

Is this ready for release?

[JimmXinu]

Originally Posted by ownedbycats

Is there a way to check that I didn't break anything? Reading List > View list shows all the books are on the list.

I'm not sure what there might be to break. The worst that can happen is your series common doesn't reflect the list. Reading the code, I think when you next change the list, RL will basically reset the series to be the list again.

I would suggest, that instead of asking, it would be quicker and more accurate in most cases to setup a test case and try things out to see what happens when you have specific behavior questions.

Originally Posted by ownedbycats

EDIT: Also, I set a keyboard shortcut to add a book to the reading list. However every time I use it it refreshes the tag browser (e.g. if I have selected things in it the pluses and minuses go away, and also temporarily glitches the Job Spy user category icons). Is that supposed to happen?

As far as I know, RL calls the appropriate Calibre methods to alert Calibre about which book ids have been changed and whether tags need to be recounted due to changes. RL calls gui.tags_view.recount(), but only when tags change, and gui.library_view.model().refresh_ids(<changed_id>) for any books with changes.

What Calibre and other plugins do with it is outside Reading List's control.

Originally Posted by JSWolf

Is this ready for release?

I don't know--there's been no feedback either for or against the change. I suppose we can call 10 downloads with no complaints implicit positive feedback?

[compurandom]

Originally Posted by JimmXinu

I don't know--there's been no feedback either for or against the change. I suppose we can call 10 downloads with no complaints implicit positive feedback?

Guilty.

Tested it just now. Ran it through all the features I use, seems to work.

The autopopulate from list / update column feature now updates the old preference correctly, keeps the value when changed, and does what it says it does now.

Thanks!

[Terisa de morgan]

I'll try to test it (4.23), as I only use it for sending books to device.

[JimmXinu]

New Version Released

Version 1.6.15 - 09 Oct 2020
- Honor modify action setting on device pop lists.
- Force pre-existing lists to TAGADDREMOVE to match prior behavior.
- Disable series labels too when series settings disabled.

Thanks for the feedback, everybody.

[nikoski]

I've read the following quoted answer but do not see a "driveinfo.calibre" on my following device: xiaomi mi9, android 10

When i connect it to calibre by CC it shows in calibre as connected.
But in readinglist i cannot add it because the add button is grey.

Also my other android 10 devices do not appear as connected in the status field of the readinglist although they are already added there.

What could be the issue?

Originally Posted by davidfor

When you click the add device in the devices tab, it stores details of the device at that. That includes whatever name calibre has given it. You can also set the name and that is used when the plugin sees the device.

When calibre sees a device, it creates the file driveinfo.calibre in the root of the device. This includes an identifier that calibre generates. This identifier is what the plugin uses to id the device when it is connected.

When you got the new device, did you copy any files over from the old one? If you copied the driveinfo.calibre over, then calibre will use device id in it for both devices. And the Reading List plugin will consider them to be the same device.

If this is what you have done, delete the driveinfo.calibre from one of the devices while calibre isn't running, and then run calibre. It will regenerate the file and should generate a new id. Then you can add the device in the plugins config and use it.

[davidfor]

Originally Posted by nikoski

I've read the following quoted answer but do not see a "driveinfo.calibre" on my following device: xiaomi mi9, android 10

When i connect it to calibre by CC it shows in calibre as connected.
But in readinglist i cannot add it because the add button is grey.

Also my other android 10 devices do not appear as connected in the status field of the readinglist although they are already added there.

What could be the issue?

What you quoted was talking about devices connected as USBMSD devices. If you are using CalibreCompanion, it is connecting to calibre in a different way. And I have no idea how that works. I don't know if it is seen as a device in a way that the Reading List can handle.

[chaley]

Originally Posted by davidfor

If you are using CalibreCompanion, it is connecting to calibre in a different way. And I have no idea how that works. I don't know if it is seen as a device in a way that the Reading List can handle.

The wireless device driver implements the standard device interface, and in particular the driveinfo stuff. It depends on the client (CC, koreader, etc) to store the UUID and give it back when requested. Reading List sees CC connections/devices.

[nikoski]

Originally Posted by davidfor

What you quoted was talking about devices connected as USBMSD devices. If you are using CalibreCompanion, it is connecting to calibre in a different way. And I have no idea how that works. I don't know if it is seen as a device in a way that the Reading List can handle.

With CC i connect by WiFi and it's been working very well with readinglist for some years already, it sends books to my devices as expected.

But now i wanted to edit a bit the plugin settings and noticed that my devices are not shown as connected and i cannot add the new one.