[GUI Plugin] Modify ePub

[Rev. Bob]

So, calibre 5.0.0 is now out, and with it comes the move to Python v3.

Which I do not know. (Okay, technically I don't really know Python v2, either, but tinkering within a code base is a lot easier than trying to upgrade to a new one.)

So this leaves us in a pickle: incompatible and outdated.

Does anyone both know Python v3 and have the time and inclination to tackle this upgrade?

[chaley]

Originally Posted by Rev. Bob

Does anyone both know Python v3 and have the time and inclination to tackle this upgrade?

I will port it this weekend unless someone gets to it first. I don't use it so can't test it beyond obvious things.

[chaley]

Python 3-compatible version for testing. As I said, I don't use the plugin so I don't know how to test it. This version starts on calibre 5 and can embed metadata. I didn't try it on calibre 4

[ownedbycats]

"Update Metadata" seems to work as expected. The feature I use most returned this error, though.

Remove calibre bookmark files:

  Modifying:  C:\Users\[username]\AppData\Local\Temp\calibre_7mgpz7uw\u9snmsek_modify_epub\5035.epub

Parsing xml file: content.opf

Parsing xml file: toc.ncx

	Looking for files to remove: ['META-INF/calibre_bookmarks.txt']

	  Found file to remove: META-INF/calibre_bookmarks.txt

No Cats Allowed - ERROR: Traceback (most recent call last):

  File "calibre_plugins.modify_epub.modify", line 80, in process_book

  File "calibre_plugins.modify_epub.container", line 687, in write

TypeError: string argument without an encoding



ePub not changed after 0.44 seconds

[chaley]

Originally Posted by ownedbycats

"Update Metadata" seems to work as expected. The feature I use most returned this error, though.

Remove calibre bookmark files:

This version fixes that problem, and probably several others.

[JSWolf]

Originally Posted by chaley

This version fixes that problem, and probably several others.

So far it's working with Calibre 4.23. I'm just waiting for Hyphenate This! to be converted before I switch to Calibre 5.

[ownedbycats]

Thanks for the fix.

[DNSB]

Using calibre 5.0.1, Modify Epub errors on quite a few functions. Most of the error messages were along the lines of:

Smarten Punctuation: TypeError: a bytes-like object is required, not 'str'

Strip Spans: TypeError: cannot use a string pattern on a bytes-like object

[chaley]

Originally Posted by DNSB

Using calibre 5.0.1, Modify Epub errors on the quite a few functions. Most of the error messages were along the lines of:

Smarten Punctuation: TypeError: a bytes-like object is required, not 'str'

Strip Spans: TypeError: cannot use a string pattern on a bytes-like object

Sorry, but this isn't helpful. I need the entire error message, otherwise I have no idea where to look.

Honestly, I am considering abandoning the port project.

[JSWolf]

Originally Posted by chaley

Sorry, but this isn't helpful. I need the entire error message, otherwise I have no idea where to look.

Honestly, I am considering abandoning the port project.

I do use this plugin very much. If it's not converted, I'll have to stay with 4.23. So please don't abandon porting.

[ownedbycats]

Here's the error I got running strip spans + smarten puncuation. If you need them run separately I can do that.

  Modifying:  C:\Users\[user]\AppData\Local\Temp\calibre_n7_o6tj0\k9ixvfiz_modify_epub\5036.epub

Parsing xml file: content.opf

Parsing xml file: toc.ncx

	Applying smarten punctuation

No Cats Allowed - ERROR: Traceback (most recent call last):

  File "calibre_plugins.modify_epub.modify", line 78, in process_book

  File "calibre_plugins.modify_epub.modify", line 180, in _process_book

  File "calibre_plugins.modify_epub.modify", line 518, in _smarten_punctuation

  File "calibre_plugins.modify_epub.modify", line 504, in smarten_punctuation_for_page

TypeError: a bytes-like object is required, not 'str'



ePub not changed after 0.43 seconds

[DNSB]

Originally Posted by chaley

Sorry, but this isn't helpful. I need the entire error message, otherwise I have no idea where to look.

Honestly, I am considering abandoning the port project.

Here's the error message for the two items I mentioned.

Spoiler:

calibre, version 5.0.1
ERROR: Modify ePub failed: No ePub files were updated

Modify ePubs


  Modifying:  C:\Users\David\AppData\Local\Temp\calibre_eafsouve\v6xq5hp6_modify_epub\9904.epub

Parsing xml file: OEBPS/content.opf

Parsing xml file: OEBPS/toc.ncx

	Stripping spans

Mind Games - ERROR: Traceback (most recent call last):

  File "calibre_plugins.modify_epub.modify", line 78, in process_book

  File "calibre_plugins.modify_epub.modify", line 194, in _process_book

  File "calibre_plugins.modify_epub.modify", line 699, in _strip_spans

  File "calibre_plugins.modify_epub.modify", line 641, in strip_span_for_page

  File "re.py", line 210, in sub

TypeError: cannot use a string pattern on a bytes-like object



ePub not changed after 0.26 seconds

Spoiler:

calibre, version 5.0.1
ERROR: Modify ePub failed: No ePub files were updated

Modify ePubs


  Modifying:  C:\Users\David\AppData\Local\Temp\calibre_eafsouve\3h6316_n_modify_epub\9904.epub

Parsing xml file: OEBPS/content.opf

Parsing xml file: OEBPS/toc.ncx

	Applying smarten punctuation

Mind Games - ERROR: Traceback (most recent call last):

  File "calibre_plugins.modify_epub.modify", line 78, in process_book

  File "calibre_plugins.modify_epub.modify", line 180, in _process_book

  File "calibre_plugins.modify_epub.modify", line 518, in _smarten_punctuation

  File "calibre_plugins.modify_epub.modify", line 504, in smarten_punctuation_for_page

TypeError: a bytes-like object is required, not 'str'



ePub not changed after 0.26 seconds

[chaley]

Yet another test version. I tested it by choosing many of the options. It completed without crashing. I suspect the output is even correct.

I don't know if this version is compatible with python 2 (calibre 4). There are a zillion fiddly bits around character conversion that it might not be.

[JSWolf]

Originally Posted by chaley

Yet another test version. I tested it by choosing many of the options. It completed without crashing. I suspect the output is even correct.

I don't know if this version is compatible with python 2 (calibre 4). There are a zillion fiddly bits around character conversion that it might not be.

I'll test with 4.23 today.

[chaley]

Originally Posted by JSWolf

I'll test with 4.23 today.

Thank you.

Attached is a version that eliminates one possibility of incompatibility.