calibre 5: Beta testers needed

[jony08]

Double-clicking on text in the server viewer gives this error (using the latest Firefox but doesn't happen in Chrome):

[Exception... "Method not implemented" nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)" location: "JS frame :: about:srcdoc :: annotations_msg_received :: line 25601" data: no]

[jony08]

Feature request: Allows to hide the backward and forward arrows and the delete button in the controls for the server viewer. For some people, the buttons in the browser are enough and you can remove the book from local storage on the Downloads page. This would make the controls less cluttered.

[jony08]

More suggestions:
1. You can now select text in a paragraph by clicking on the text three times, but it would be useful to also select a paragraph when you have selected a word by double-clicking on the selected text to extend the selection to the entire paragraph.

2. When you select some highlighted text and click on the quick highlight button in the bar, the Add notes window opens. IMHO it would be better if the quick highlight button would only quick highlight text, especially when there is already a button to add notes.

[kovidgoyal]

@jony08: Quick highlight does not open notes. The full screen being removed was indeed a bug. If you want to extend a selection to a paragraph, simply click outside and then triple click. And as for your firefox bug on double clicking text, I cannot replicate. And no I want there to be buttons to both edit notes and edit the entire highlight.

[kovidgoyal]

@thiago: If a custom style is applied to some text then it will show up even if removed, since it is actually used in the text. If you delete that highlight or change its style then it will no longer show up. Following your set of steps does not create an error for me.

[kovidgoyal]

While I could not reproduce the error, I realized there was indeed a bug when adding more than one custom highlight style, now fixed: https://github.com/kovidgoyal/calibr...abf9c44b03bc73

[jony08]

Originally Posted by kovidgoyal

@jony08: Quick highlight does not open notes. The full screen being removed was indeed a bug. If you want to extend a selection to a paragraph, simply click outside and then triple click. And as for your firefox bug on double clicking text, I cannot replicate. And no I want there to be buttons to both edit notes and edit the entire highlight.

@kovid: Quick highlight opens notes for me if the selection is already highlighted. My mistake, the Firefox bug doesn't happen when you double-click on text, it happens when you triple-click on text.

[kovidgoyal]

@jony08: That's by design, if you have highlighted an existing selection it means you want to edit it, not create a new one. As for the firefox bug, ok I can reproduce it, will look into it when I have some time.

https://github.com/kovidgoyal/calibr...fcc3098e56eb87

[jony08]

@kovid: Good news that you could fix it! As for the quick highlight, it makes sence.

One more suggestion: When searching for selection in the book, the search panel should automatically do the search. It doesn't make sence that you should have to click search one more time in the panel.

[nixsee]

Nice changes! I like the Chapter segmentation for highlights and the selection handles are sufficiently non-offensive to me now!

A few notes of feedback/suggestions:
1. Only top-level chapters/sections show up in the highlights panel - it would be nice for it to also segment them by sub chapters as well. Here's a screenshot of one book - the four Parts consist of dozens of shorter chapters, which aren't showing up.



2. It seems strange that there is both the Edit button and the clickable Edit Notes link. I see that they do different things, and actually like the larger notes-only editor, but the two buttons so close to each other is uncomfortable in some way...

3. If there could be just slightly more space between highlights in the highlights pane - a pixel or two - that would be nice. I know that each line is a new highlight, but they tend to blur together.


Nice work! Any estimate on when Calibre 5 will be released?

[kovidgoyal]

@nixsee:
1) It is deliberate, there is too much segmentation if you use the full toc tree. One then has to drill down through multiple sections to get to the actual highlight.

2) Like you I like having a larger editor that is easily accessed. I dont see how that is possible without two buttons.

3) I dont see what's special about the highlights list. All tree views in calibre are like this. Adjusting individual trees by a pixel or two is just a recipe for chaos.

@jony08: What does when searching for selection in book mean? You mean clicking the search button in the selection bar?

[jony08]

@kovid: Yes, I mean clicking the search button in the selection bar. I think the shortcut Ctrl+s should do the same but it doesn't work.

[kovidgoyal]

Originally Posted by jony08

@kovid: Yes, I mean clicking the search button in the selection bar. I think the shortcut Ctrl+s should do the same but it doesn't work.

https://github.com/kovidgoyal/calibr...f375c130483c42

[JimmXinu]

FYI, I think that my DB update issue may well have been caused by my threading issue.

When I saw the threading issue occur the second time, I didn't stop and restart Calibre. Changes made to the library after that don't appear to have been saved.

That suggests to me that Calibre didn't keep the DB connection? Will the change in 13259a4 help with that?

More strangely, I started digging to the code to see what was going on and noticed this from my error log--note the line numbers:

...
Traceback (most recent call last):
  File "site-packages\calibre\db\backend.py", line 132, in __setitem__
...
Traceback (most recent call last):
...
  File "site-packages\calibre\db\backend.py", line 133, in __setitem__
apsw.ThreadingViolationError: You are trying to use the same object concurrently in two threads or re-entrantly within the same thread which is not allowed.

Were there somehow two different threads(or processes) running different versions of backend.py??

I had Calibre 4.22(32bit) and 4.99.12(64bit) installed and was running from CLI `calibre-debug -g`.

That call was on line 133 in 4.99.12 and line 132 a few versions earlier. Although according to the tag, it was line 131 in v4.22...

Kovid, if you still think that this all boils down to me doing something illegally re-entrant in plugin, can you give me an example of how I could do that? Because I don't know how it could even happen.

Thanks.

[jony08]

@kovid: I think there should be a function to remove all highlights and/or bookmarks from a book/books.