Funny: PageEdit searches in the opposite direction

Der_Andi · 07-28-2020, 06:57 AM

Hello together,
i found a funny thing in PageEdit (Windows 10 & Kubuntu 20.04 with all updates, versions 1.2.0 and 1.3.0).
If i start searching a word, PageEdit will find them all an mark them yellow. But when i will go to the next item with the 'down'-button, it will find the previous item. And when i'll go to the previous item using the 'up'-button, PageEdit will find the next one.
I really believe that we can survive with this mystery, but it is possible to change this?

Best regards, Der_Andi

KevinH · 07-28-2020, 09:35 AM

I have never noticed that. Is this with up and down icon buttons in search bar or with keyboard shortcuts to them?

Der_Andi · 07-28-2020, 10:11 AM

Hello KevinH,
it is with the up/down-buttons next to the search-input-field
Der_Andi

KevinH · 07-28-2020, 10:23 AM

Okay, I will look into fixing this for the next release.

KevinH · 07-28-2020, 10:31 AM

Yes, the code itself is correct but the icon files got switched somehow. The find next icon is incorrectly set to the up arrow and the find previous icon has been set to the down arrow.

You can see this here:

https://github.com/Sigil-Ebook/PageE...-next_16px.png
https://github.com/Sigil-Ebook/PageE...vious_16px.png

I will rename both files back to what they should be for the next release.

Edit: The files were switched back, so the links above should now show properly

Der_Andi · 07-28-2020, 11:48 AM

Great, thank you very much!
Der_Andi

KevinH · 07-28-2020, 01:56 PM

Now fixed in PageEdit master

BeckyEbook · 07-28-2020, 04:52 PM

It's my fault. When preparing the icons, I called them the other way around.
Somehow I didn't pay attention to it later.

KevinH · 07-28-2020, 06:47 PM

No worries! It was easily fixed.

exaltedwombat · 07-29-2020, 08:03 AM

I appreciate the work that went into the new icons. I've given them a fair trial. But I still find them intrusive and un-intuitive. Is there ANY possibility of having the old ones as an option? Sorry.

KevinH · 07-29-2020, 08:32 AM

The old ones do not work well under both dark and light modes. If you really can't live with the new icons, your only choice right now is to find and extract the old icon files from our github site and build Sigil and PageEdit from source yourself.

We have talked about user icon sets as a future feature but that does not exist yet.

exaltedwombat · 07-29-2020, 11:10 AM

Ok, thanks. I resisted criticising the new icons when they arrived, assuming I'd get used to them. But I'm afraid they continue to irritate and impede. Far from a showstopper, but it would be great if those of us who have no interest in Dark Mode could have the choice.

KevinH · 07-29-2020, 11:31 AM

Since they are all the same size and colour coordinated, I find the new icons much less intrusive than the old ones. The mnemonic impact of course depends on individual recognition but to me the new icons seem to use similar underlying images or themes as the old ones, so their meaning was quite clear to me, too.

The added benefits of the new icons means the Sigil owns them, so no licensing issues or copyright issues by mistake, and there are svg versions of most of them that should allow us to eventually move to using only svg icons removing the need to have 16px, 22px, and 48px versions.

Having users create their own icon sets, is I think a long term goal of DiapDealer for Sigil that I support too.

exaltedwombat · 07-29-2020, 11:48 AM

Quote:

Originally Posted by KevinH

Since they are all the same size and colour coordinated,

You've put into words better than mine precisely what I DON'T like about the new icons! Icons need to be easily distinguishable, to look DIFFERENT to each other. Uniformity is a minus.

But it's a small quibble about a very useful program.

DiapDealer · 07-29-2020, 12:34 PM

It's one thing to not like the new icons. Taste is subjective after all. But it's quite another to pretend there's something objectively 'wrong" with the uniformity of the theme in general. if uniformity were an objective "minus" where icons are concerned, there would be no such thing as icon themes in the first place. Stick with "I don't like them" from now on. Your attempt to imply there's anything other than subjective taste in play is not necessary. Nor is it accurate.

07-28-2020, 06:57 AM	#1
Der_Andi Member Posts: 14 Karma: 10 Join Date: Jun 2020 Device: Tolino	Funny: PageEdit searches in the opposite direction Hello together, i found a funny thing in PageEdit (Windows 10 & Kubuntu 20.04 with all updates, versions 1.2.0 and 1.3.0). If i start searching a word, PageEdit will find them all an mark them yellow. But when i will go to the next item with the 'down'-button, it will find the previous item. And when i'll go to the previous item using the 'up'-button, PageEdit will find the next one. I really believe that we can survive with this mystery, but it is possible to change this? Best regards, Der_Andi

07-28-2020, 10:31 AM	#5
KevinH Sigil Developer Posts: 8,478 Karma: 5703586 Join Date: Nov 2009 Device: many	Yes, the code itself is correct but the icon files got switched somehow. The find next icon is incorrectly set to the up arrow and the find previous icon has been set to the down arrow. You can see this here: https://github.com/Sigil-Ebook/PageE...-next_16px.png https://github.com/Sigil-Ebook/PageE...vious_16px.png I will rename both files back to what they should be for the next release. Edit: The files were switched back, so the links above should now show properly Last edited by KevinH; 07-28-2020 at 02:19 PM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
The Opposite of Living is FREE today and tomorrow	Genevieve Mckay	Self-Promotions by Authors and Publishers	3	02-16-2015 12:02 PM
The Opposite of Absolute	RobertLCollins	Self-Promotions by Authors and Publishers	0	12-14-2012 09:26 AM
What do you call circles moving in the opposite direction?	mr ploppy	Writers' Corner	23	06-24-2012 06:54 AM
The Opposite of Writer's Block?	aecardenas	Writers' Corner	26	05-08-2012 10:45 PM
The opposite of drop caps	LostSock	ePub	13	09-13-2011 07:07 AM

07-28-2020, 09:35 AM	#2
KevinH Sigil Developer Posts: 8,478 Karma: 5703586 Join Date: Nov 2009 Device: many	I have never noticed that. Is this with up and down icon buttons in search bar or with keyboard shortcuts to them?

07-28-2020, 10:11 AM	#3
Der_Andi Member Posts: 14 Karma: 10 Join Date: Jun 2020 Device: Tolino	Hello KevinH, it is with the up/down-buttons next to the search-input-field Der_Andi

07-28-2020, 10:23 AM	#4
KevinH Sigil Developer Posts: 8,478 Karma: 5703586 Join Date: Nov 2009 Device: many	Okay, I will look into fixing this for the next release.

07-28-2020, 11:48 AM	#6
Der_Andi Member Posts: 14 Karma: 10 Join Date: Jun 2020 Device: Tolino	Great, thank you very much! Der_Andi

07-28-2020, 01:56 PM	#7
KevinH Sigil Developer Posts: 8,478 Karma: 5703586 Join Date: Nov 2009 Device: many	Now fixed in PageEdit master

07-28-2020, 04:52 PM	#8
BeckyEbook Guru Posts: 809 Karma: 2416112 Join Date: Jan 2017 Location: Poland Device: Various	It's my fault. When preparing the icons, I called them the other way around. Somehow I didn't pay attention to it later.

07-28-2020, 06:47 PM	#9
KevinH Sigil Developer Posts: 8,478 Karma: 5703586 Join Date: Nov 2009 Device: many	No worries! It was easily fixed.

07-29-2020, 08:03 AM	#10
exaltedwombat Guru Posts: 878 Karma: 2457540 Join Date: Nov 2011 Device: none	I appreciate the work that went into the new icons. I've given them a fair trial. But I still find them intrusive and un-intuitive. Is there ANY possibility of having the old ones as an option? Sorry.

07-29-2020, 08:32 AM	#11
KevinH Sigil Developer Posts: 8,478 Karma: 5703586 Join Date: Nov 2009 Device: many	The old ones do not work well under both dark and light modes. If you really can't live with the new icons, your only choice right now is to find and extract the old icon files from our github site and build Sigil and PageEdit from source yourself. We have talked about user icon sets as a future feature but that does not exist yet.

07-29-2020, 11:10 AM	#12
exaltedwombat Guru Posts: 878 Karma: 2457540 Join Date: Nov 2011 Device: none	Ok, thanks. I resisted criticising the new icons when they arrived, assuming I'd get used to them. But I'm afraid they continue to irritate and impede. Far from a showstopper, but it would be great if those of us who have no interest in Dark Mode could have the choice.

07-29-2020, 11:31 AM	#13
KevinH Sigil Developer Posts: 8,478 Karma: 5703586 Join Date: Nov 2009 Device: many	Since they are all the same size and colour coordinated, I find the new icons much less intrusive than the old ones. The mnemonic impact of course depends on individual recognition but to me the new icons seem to use similar underlying images or themes as the old ones, so their meaning was quite clear to me, too. The added benefits of the new icons means the Sigil owns them, so no licensing issues or copyright issues by mistake, and there are svg versions of most of them that should allow us to eventually move to using only svg icons removing the need to have 16px, 22px, and 48px versions. Having users create their own icon sets, is I think a long term goal of DiapDealer for Sigil that I support too.

07-29-2020, 12:34 PM	#15
DiapDealer Grand Sorcerer Posts: 28,358 Karma: 203720150 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	It's one thing to not like the new icons. Taste is subjective after all. But it's quite another to pretend there's something objectively 'wrong" with the uniformity of the theme in general. if uniformity were an objective "minus" where icons are concerned, there would be no such thing as icon themes in the first place. Stick with "I don't like them" from now on. Your attempt to imply there's anything other than subjective taste in play is not necessary. Nor is it accurate.