Find replace history not saved between sessions - Page 4

KevinH · 02-08-2020, 11:42 AM

FWIW, we have had a number of issues with Qt over the years related to the order of destructors being called on all platforms. I think there are 3 or 4 places in Sigil code alone that mentions order dependent issues. The problem is without understanding how two classes are related and what pointers are used to implement things internally, the order of destruction may need to be different the reverse of the order of creation.

DiapDealer · 02-08-2020, 12:31 PM

Oddly enough, switching the order on F&R and ToC object deletions has no effect. It works regardless which one is first.

DiapDealer · 02-08-2020, 12:33 PM

Also, for what it's worth: the exiting segfault seems to be because of something happening in QWebEnginePage's destructor.

poxi1023 · 02-09-2020, 07:46 PM

I'm baffled...
On another laptop (Dell Inspiron 13) with Linux Mint 19.3 and also Qt 5.9.5, I compiled and installed Sigil 1.1.0, with DiapDealer's fix. Regrettably the problem remains - [find_replace] is not saved between sessions!
Only solution: close ToC window and restart Sigil.

DiapDealer · 02-09-2020, 08:14 PM

It could be a timing thing. Did you try 1.1.0 as is on that machine first, or did you apply the fix right away? It's possible the original code could work fine on that machine. Also make sure you used the #ifndef directive and not #ifdef when patching.

KevinH · 02-10-2020, 09:33 AM

This could be a bug in the C++ standard library as well since it relates to destructors. What versions of g++ are you compiling with? What libc version? Is there any differences on your two machines?

poxi1023 · 02-10-2020, 02:00 PM

Quote:

Originally Posted by DiapDealer

It could be a timing thing. Did you try 1.1.0 as is on that machine first, or did you apply the fix right away? It's possible the original code could work fine on that machine. Also make sure you used the #ifndef directive and not #ifdef when patching.

Sorry, my fault! I overlooked the "n" in "#ifndef"...
Now it works all right.

Thanks for all the help, great, guys!

DiapDealer · 02-10-2020, 02:58 PM

Quote:

Originally Posted by poxi1023

Sorry, my fault! I overlooked the "n" in "#ifndef"...
Now it works all right.

Thanks for all the help, great, guys!

No problem. I knew it would be easy to overlook that if you weren't copy/pasting directly from my post. That's why I threw it out there.

02-09-2020, 08:14 PM	#50
DiapDealer Grand Sorcerer Posts: 28,574 Karma: 204127028 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	It could be a timing thing. Did you try 1.1.0 as is on that machine first, or did you apply the fix right away? It's possible the original code could work fine on that machine. Also make sure you used the #ifndef directive and not #ifdef when patching. Last edited by DiapDealer; 02-09-2020 at 08:17 PM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Behaviour of history and spaces in find/replace text boxes	arspr	Editor	0	01-01-2014 05:04 PM
Find Replace	unrulyguides	Sigil	5	02-17-2012 08:38 PM
Find/Replace Won't Find	Rand Brittain	Sigil	7	09-24-2011 04:35 AM
Find / replace	bremler	Sigil	6	12-17-2010 03:26 PM
Using Find/Replace with BD	Otter	Sony Reader	7	02-28-2009 01:49 PM

02-08-2020, 11:42 AM	#46
KevinH Sigil Developer Posts: 8,766 Karma: 6000000 Join Date: Nov 2009 Device: many	FWIW, we have had a number of issues with Qt over the years related to the order of destructors being called on all platforms. I think there are 3 or 4 places in Sigil code alone that mentions order dependent issues. The problem is without understanding how two classes are related and what pointers are used to implement things internally, the order of destruction may need to be different the reverse of the order of creation.

02-08-2020, 12:31 PM	#47
DiapDealer Grand Sorcerer Posts: 28,574 Karma: 204127028 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	Oddly enough, switching the order on F&R and ToC object deletions has no effect. It works regardless which one is first.

02-08-2020, 12:33 PM	#48
DiapDealer Grand Sorcerer Posts: 28,574 Karma: 204127028 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	Also, for what it's worth: the exiting segfault seems to be because of something happening in QWebEnginePage's destructor.

02-09-2020, 07:46 PM	#49
poxi1023 Member Posts: 21 Karma: 88 Join Date: Mar 2008 Location: Paraguay Device: Samsung Galaxy Tab S2	I'm baffled... On another laptop (Dell Inspiron 13) with Linux Mint 19.3 and also Qt 5.9.5, I compiled and installed Sigil 1.1.0, with DiapDealer's fix. Regrettably the problem remains - [find_replace] is not saved between sessions! Only solution: close ToC window and restart Sigil.

02-10-2020, 09:33 AM	#51
KevinH Sigil Developer Posts: 8,766 Karma: 6000000 Join Date: Nov 2009 Device: many	This could be a bug in the C++ standard library as well since it relates to destructors. What versions of g++ are you compiling with? What libc version? Is there any differences on your two machines?