[GUI Plugin] Quality Check

[jhowell]

Originally Posted by JSWolf

I'm not seeing any errors as I'm not using the 4.99+ beta. I'm just keeping track of what I use that's been updated.

I tried it. The plugin fails to load under 4.99.2.

Spoiler:

calibre Debug log
calibre 4.99.2 Portable embedded-python: True is64bit: False
Windows-10-10.0.18362-SP0 Windows ('32bit', 'WindowsPE')
32bit process running on 64bit windows
('Windows', '10', '10.0.18362')
Python 3.8.0
Windows: ('10', '10.0.18362', 'SP0', '')
Interface language: None
...
Traceback (most recent call last):
File "ui.py", line 157, in __init__
File "ui.py", line 171, in init_iaction
File "__init__.py", line 612, in load_actual_plugin
File "__init__.py", line 127, in import_module
File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
File "<frozen importlib._bootstrap>", line 991, in _find_and_load
File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 655, in _load_unlocked
File "<frozen importlib._bootstrap>", line 618, in _load_backward_compatible
File "zipplugin.py", line 184, in load_module
File "calibre_plugins.quality_check.action", line 25, in <module>
File "zipplugin.py", line 184, in load_module
File "calibre_plugins.quality_check.check_epub", line 11, in <module>
ImportError: cannot import name 'escape' from 'cgi' (C:\calibre-beta\Calibre Portable\Calibre\\app\pylib.zip\cgi.pyc)
[7.36] splash screen hidden
[7.36] Started up in 7.36 seconds with 8324 books

[kboogie222]

Originally Posted by snarkophilus

Indeed, Stephen King's Christine has 145 matches for just [a-z]</p> and 245 matches for [a-z,]</p>. Almost all of these were in song verses at the start of each chapter, but there were three missing periods at the end of sentences, one comma that should have been a period and one actual occurrence of a break mid-sentence.

Wow, it sounds like we could be pretty close here. Very cool!

Thinking through a couple rules that might help us avoid the false positives, here's the first that come to mind. There's probably 2 or 3 better solutions, hah.

1) Ignore instances that are repeating.
2) Add a capital requirement for the beginning of the first half of broken sentence.
3) Add a length requirement for the first half of the first half

Originally Posted by snarkophilus

Instead of just looking for at least one match for the regex, you could count the number of times the broken sentence regex appears and return "true" if more than certain (configurable?) threshold.

Exactly. Set a threshold for number of time broken, and exit search if true. Would also cut down on unnecessary searching beyond threshold.

[davidfor]

Originally Posted by JSWolf

I'm not seeing any errors as I'm not using the 4.99+ beta. I'm just keeping track of what I use that's been updated.

Which is exactly what I thought.

It will get done. There is no urgency as the Python 3 release isn't expected before mid year. The developers who are likely to do this, are dealing with their own plugins first. Or other aspects in their life.

[pmattera]

Hello,
I want to report a problem and ask an improvement to this plug-in (if is possible),

1.) the problem is that in the "Check series gaps" function, if a series with more than 1000 occurs, this is not even analyzed.

2.) if a comic or book within a series has a double numbering, is it possible to create an exception?
So that this is no longer reported as absent?

I'm managing about 23 thousand cbr/cbz and it is hard to remember the exceptions/double numbers.

Bye
Paolo Mattera

[JSWolf]

Originally Posted by pmattera

I'm managing about 23 thousand cbr/cbz and it is hard to remember the exceptions/double numbers.

Bye
Paolo Mattera

23,000 comic books is a lot. Where did you get these comic books? Are they legal (did you pay for them or are they public domain or a combination of both)?

[theducks]

23000 is so far out of what I would expect for a 'typical' series, that I am not surprised it is not handled (nor would I expect much effort to make it happen).
I do remember that some of the 'gap' lists were pretty unwieldy and that was for under 100 members

[pmattera]

Originally Posted by JSWolf

23,000 comic books is a lot. Where did you get these comic books? Are they legal (did you pay for them or are they public domain or a combination of both)?

these are mostly comics scans in my possession or on some rare occasions a friend of mine who lent it to me when I lost it or did not arrive in time to buy it from newsstands.
most are Marvel or DC comics (some Image) but there are also some manga that I think are worth reading

however the problem I have with the Italian edition of Mickey Mouse which currently includes 3340 numbers, and is categorically skipped by the verification.

sorry my english but I'm not used to writing so I rely on classic Google translator

[JSWolf]

So in plain English, a lot of those comics are not legally obtained.

[boriar]

Originally Posted by JSWolf

So in plain English, a lot of those comics are not legally obtained.

And? Is it your problem?

[chaley]

Originally Posted by JSWolf

So in plain English, a lot of those comics are not legally obtained.

Originally Posted by boriar

And? Is it your problem?

Yes, copyright violation is everyone's problem, assuming we want authors to be compensated for their work. I suggest very strongly that you don't continue the argument that copyright violation is OK. You will possibly be banned.

[JSWolf]

Originally Posted by boriar

And? Is it your problem?

It means no more help as we don't give help with pirated content.

[boriar]

Originally Posted by chaley

Yes, copyright violation is everyone's problem, assuming we want authors to be compensated for their work. I suggest very strongly that you don't continue the argument that copyright violation is OK. You will possibly be banned.

PLEASE, do not put in my mouth things that I have not said.

[JSWolf]

Originally Posted by boriar

PLEASE, do not put in my mouth things that I have not said.

You said it like it was not my business and that you didn't care that all those comics were illegally obtained. The way you said what you said was saying that it was none of my business and that you didn't care.

The rule is not to give help to someone asking for help with illegally obtained content and that's what happened in this case.

[BetterRed]

I would have thought if you buy 23,000 paper comics from newstands, or a second hand copies from ebay, or drag them out of dumpster, then you can scan them for your own use without violating any copyright laws.

The possible exception here is ". . . on some rare occasions a friend of mine who lent it to me when I lost it or did not arrive in time to buy it from newsstands." Comics are rarely reissued. If you're an avid collector it is easy to miss an edition if you have to go o/seas, or you're hospitalised for a few weeks etc.

I suggest those who want to maintain a guilty until proven innocent doctrine lighten up on this occasion; especially those from regimes where the Magna Carta is much revered

BR

[JSWolf]

Originally Posted by BetterRed

I would have thought if you buy 23,000 paper comics from newstands, or a second hand copies from ebay, or drag them out of dumpster, then you can scan them for your own use without violating any copyright laws.

The possible exception here is ". . . on some rare occasions a friend of mine who lent it to me when I lost it or did not arrive in time to buy it from newsstands." Comics are rarely reissued. If you're an avid collector it is easy to miss an edition if you have to go o/seas, or you're hospitalised for a few weeks etc.

I suggest those who want to maintain a guilty until proven innocent doctrine lighten up on this occasion; especially those from regimes where the Magna Carta is much revered

BR

It depends what's said. If it raises red flags, then I'll ask about it. And in this case, 23,000 scanned comics really raised red flags. I don't see why to get annoyed with my asking. I don't do it in a rude way. But if the answer is yes, it's pirated, then that's it, game over man.