save file as - file selection dialog - 0.9.18

[KevinH]

Wow that is news to me! All macs have had that self test start-up chime since forever ... I wonder why they changed that?

I am letting travis build a new macOS version for you and Odamizu to test with that disables the native QFileDialog widgets and uses Qt's version, to see if that has any impact at all.

I will pm both of you with an updated download link when that automated build finally completes. Please give the new version a try as it has all of the latest bug fixes in place in case they are contributing to the problem.

KevinH

Originally Posted by Vroni

Searching the internet comes to another conclusion. Macs sold from 2016 have this turned off by a hidden system setting only accessible via command line / terminal.

[odamizu]

Success! I ran a few quick tests with 0.9.991-build211 and so far so good. No leftover dialog boxes. I will play with it more in a bit, but wanted you to know this right away

Originally Posted by KevinH

... new macOS version for you and Odamizu to test with that disables the native QFileDialog widgets and uses Qt's version, to see if that has any impact at all ...

[KevinH]

Wow so the bug is in Qt somewhere in how it uses native widgets for QFileDialogs.
We use a bunch of them in MainWindow, ClipSettings, Preferences, etc. i only changed the ones in BookBrowser.

So it looks like I will have to track down all uses of QFileDialog and set their options to not use native widgets but only for macOS since no one else is reporting any difficulties here.

I will start that process tomorrow unless a better solution is found.

Thanks for testing it.

KevinH

[odamizu]

I repeated the tests, and indeed the new build 211 solves this problem. Yay!

I wanted to ask about some of your earlier comments.

Originally Posted by KevinH

On a macOS double clicking on an existing epub will not close Sigil if it is already running. You are probably launching a different version of Sigil someplace when you do that!

Sigil remains running when you close the Window (even the last window) and you can see this by looking for the dot in the panel under your Sigil app. If you click once on the panel Sigil with the icon, you should see the top menubar show Sigil and have a File menu enabled to open a new epub.

Dragging a new epub to that Sigil icon in the panel with the dot under it will just open a new Window in the existing version of Sigil just as using the File->Open menu would do.

I understand that if I close the Window (red close button or menu-Close) that Sigil itself is still running (dot next to Sigil icon on Dock), even if there are no visible Windows. I also understand that the only way to make Sigil stop running is to Quit with command-Q or menu-Quit.

But what do you mean "You are probably launching a different version of Sigil someplace when you do that!" ??

I usually leave Sigil "open and running" (dot next to Sigil icon in Dock) without a Window open. In other words, when I finish working on an epub, I usually just save and close the Window, but leave Sigil running (with dot in Dock). I may then open a different epub or go do something else and then come back and re-open the epub I was working on. I only Quit Sigil when I'm done for the day. Is this a problem? Should I avoid Closing a Window and use Quit instead?

Originally Posted by KevinH

It sounds like you are running multiple instance of Sigil at the same time. This is not correct for a mac.

I am so confused now. See above.

... flush your Application caches

Is this when I go to Library > Caches and delete the sigil-ebook folder?

Thank you

[KevinH]

Vroni implied with his post that double clicking an epub somehow closed the Sigil window. I was pointing out it did not. If he was actually seeing that, he might be running multiple instances of Sigil at the same time.

That is all I was trying to say. When you have multiple versions of Sigil on you system, double-clicking an epub to launch Sigil may actually launch a different version depending on where each is located. It is better to drag and drop the epub on the Sigil icon with the dot in the panel to launch the new epub or use the file open menu to makesure youknow which version of Sigil is running.

[KevinH]

BTW: I have now pushed a fix to master that converts all QFileDialogs to use QFileDialog::DontUseNativeDialog just for macOS (and for Linux where it was set that way before).

This should workaround a number of ignored and closed as too old Qt bugs related to QFileDialog on macOS that report that the native versions of QFileDialogs do not always properly exit from exec().

The reports were all basically ignored by Qt but made it clear that this seems to hit only some machines and some users and even then not consistently.

My guess is that this is a structure alignment or signal issue issue but no one at Qt has bothered to look more closely.

For reference see here are many of the related Qt bug reports for QFileDialog and macOS:

https://bugreports.qt.io/browse/QTBUG-57009
https://bugreports.qt.io/browse/QTBUG-66138
https://bugreports.qt.io/browse/QTBUG-69437
https://bugreports.qt.io/browse/QTBUG-71234
https://bugreports.qt.io/browse/QTBUG-76563

[Vroni]

Originally Posted by KevinH

Vroni implied with his post that double clicking an epub somehow closed the Sigil window.

He may have said that, she didnt. Its clearly visible in the dock that closing an app is NOT quitting the app.

I downloaded the test app but didnt had time to test it. As you already changed all Filedialog instances, are you still interested in my test result?

[KevinH]

No, if you have don't have interest in helping to further test Sigil-0.9.991 do not bother to confirm as we already have confirmation.

Thanks,

Kevin

Originally Posted by Vroni

He may have said that, she didnt. Its clearly visible in the dock that closing an app is NOT quitting the app.

I downloaded the test app but didnt had time to test it. As you already changed all Filedialog instances, are you still interested in my test result?