Calibre 4 a step back

[Phssthpok]

Originally Posted by kovidgoyal

Feel free to contribute a working CSS3 validation to the css-parser library then. Waaay too much work for me just to avoid the occassional unneeded warning.

Warnings are one thing, but this is reported as an ERROR. And I don't mind ignoring the occasional warning, but I hate ignoring errors. Any chance of downgrading this from an error to a warning?

[kovidgoyal]

Just continue using 100% there are now workarounds for it in both the editor and the viewer and even PDF output.

[JSWolf]

Originally Posted by kovidgoyal

That was a bug I fixed earlier today, look at the updated code.

Does the code to replace 100% with 100vh or 100vw work with...

img {
  max-height: 100%;
  max-width: 100%;
}

With 4.2, the width seems to work as it fills the entire window and no more, but the height does not.

Thanks.

[kovidgoyal]

It works only with the standard recommended markup for displaying full screen images using an SVG tag. Nothing else. And max-width/height only prevent an element from being larger than the specified amount they do not control its size.

[jiembe]

Originally Posted by kovidgoyal

It works only with the standard recommended markup for displaying full screen images using an SVG tag. Nothing else. And max-width/height only prevent an element from being larger than the specified amount they do not control its size.

I resize by coding every image to get the size I want with percentage of the screen not with pixel (width=25% not width=120px or whatever). Since I'm often using images with larger size than the kobo screen. max-width and max-height work well in those circumstances to assure that the image is fully display.

For an image with height superior to its width:
height: 100%;
width: auto;
max-height: 100%;

I'm also using "tablet" as Page setup when I convert book.

As for svg I use it only when I want to be able to enlarge the image during lecture (maps for example) and sometimes for the cover.

You understand that I am not trying to produce the smallest file available.

[Phssthpok]

Originally Posted by kovidgoyal

Just continue using 100% there are now workarounds for it in both the editor and the viewer and even PDF output.

I see the previewer in the editor does not reduce images to 100% of the height of the previewer window, which is what used to happen in C3.

[kovidgoyal]

100% does not refer to viewport size in modern browsers. But most ebook viewers including calibre's will auto-restrict images to viewport.

[JSWolf]

Originally Posted by kovidgoyal

It works only with the standard recommended markup for displaying full screen images using an SVG tag. Nothing else. And max-width/height only prevent an element from being larger than the specified amount they do not control its size.

But when using hi-res images of a larger height then the Viewer windows, it prevents the image from being too large.