epubcheck plugin for Sigil - Page 17

KevinH · 07-21-2019, 01:46 PM

Also since we run the EmbeddedPython routines explicitly without env vars, we are going to have to change python3lib updatechecker.py to set its own environment var for macOS just to be safe.

Edit:
So something like this added to our updatechecker.py inside Sigil's python3lib or added to any plugin should do the trick too.

Code:

import sys
import os

if sys.platform.startswith('darwin'):
    try:
	    import certifi
	    os.environ["SSL_CERT_FILE"]=certifi.where()
    except:
	    pass

Update:

With both changes to updatechecker.py for our python3lib and to PluginRunner.cpp, and after I removed the bad symlink changes done by the install certify script, I was able with a clean rebuild to run EpubCheck and its update checker found a new update and downloaded it and ran.

So I pushed all of these changes to master. In the interim, if a plugin wants to do an update check prehaps they could add the short macOS piece of python code near the top to get the current release to work.

odamizu · 07-21-2019, 08:04 PM

KevinH, KovidGoyal and DiapDealer!

Sorry I am so late returning to this discussion. I assume you no longer need me to do the command line thingie.

You guys are too fast for me! Thanks again for all your time and effort

Quote:

Originally Posted by KevinH

Odamizu,
Are you okay using the command line (Terminal.app) and if so would you be willing to try the following for me.

Quote:

Originally Posted by KevinH

... I was able with a clean rebuild to run EpubCheck and its update checker found a new update and downloaded it and ran. So I pushed all of these changes to master ...

KevinH · 07-21-2019, 09:54 PM

If you do get a free moment, please add this snippet near the top of the epubcheck plugin.py, and re-enable update checking to see if this workaround fixes things for you.

Code:

if sys.platform.startswith('darwin'):
    try:
	    import certifi
	    os.environ["SSL_CERT_FILE"]=certifi.where()
    except:
	    pass

odamizu · 07-21-2019, 11:24 PM

Yes! It worked! I did a clean install of the plugin then added your snippet after line 12 in plugin.py. On first-run, the plugin promptly checked for a new version, downloaded 4.2.2, then checked the open epub. Thanks!

Leonatus · 07-30-2019, 02:46 AM

Sigil v. 0.9.16.
I use the plugin EpubCheck_v0.4.1.4, whereas a friend uses the standalone version.
I created a book with some errors, due to unattentiousnes, such as

Code:

<h1><div>...</div></h1>

As far as I know, divs should not be embedded in h1 elements. And the other:

Code:

<span class="center">...</span>

What I learned is that spans should only be used embedded in block elements, what has been missing here.
Now the strange is that epubcheck didn't put out an error message in the Sigil plugin version (for neither of the errors), but it did in the standalone version. Is there something one should know about that?

Doitsu · 07-30-2019, 04:26 AM

Quote:

Originally Posted by Leonatus

Sigil v. 0.9.16.
I use the plugin EpubCheck_v0.4.1.4, whereas a friend uses the standalone version.

What's the EPUBCheck version number that's displayed when you run the plugin?
(It should say: Running EPUBCheck v4.2.2, if you have the latest version.)

When I tested epub2 and epub3 files with the following code:

Code:

<body>
  <h1>
	<div>div test</div>
  </h1>
  <span>span test</span>
</body>

I noticed differences in the errors reported by EPUBCheck 4.2.2.

When I checked the epub2 file both problems were flagged as:

Code:

ERROR(RSC-005): Error while parsing file: element "div" not allowed here
ERROR(RSC-005): Error while parsing file: element "span" not allowed here

However, when I checked the epub3 file only the div was flagged:

Code:

ERROR(RSC-005): Error while parsing file: element "div" not allowed here

AFAIK, EPUBCheck uses Nu Html Checker for checking HTML5 files in epub3 books, and according to Nu Html Checker, isolated <span> tags are apparently OK in HTML5 files. IMHO, this is a bug.

Please create blank epub2 and epub3 books with my code, re-create my tests and let me know if you're getting different results.

Leonatus · 07-30-2019, 04:36 AM

I use the most recent version of Epubcheck, and as I'm not at home, I had at look at #1, where the version is called 0.4.1.4. But I'll look again at home, and then I shall follow your advice. Until now, I only created epub2 books.

Leonatus · 07-30-2019, 07:35 AM

I noticed that the .zip file is called 0.4.1.4, but at running the version no. is 4.2.1. Result is the same as I had written, even when trying with your test code.
Where can I find version 4.2.2, please?

Doitsu · 07-30-2019, 07:58 AM

Quote:

Originally Posted by Leonatus

Where can I find version 4.2.2, please?

The plugin should've automatically downloaded the latest version, if the computer has internet access. If it didn't, make sure that EpubCheck.json contains the following entry:

Code:

  "update_check": true,

If it doesn't, please add it at the beginning of EpubCheck.json. If the entry does exist, also edit the last_time_checked entry and change 2019 to 2018. This should trigger a download.

If your computer doesn't have Internet access or your firewall blocks the updater, download the latest version from the EPUBCheck github website and extract it and overwrite epubcheck.jar and the lib folder in the plugin folder.

Quote:

Originally Posted by Leonatus

Result is the same as I had written, even when trying with your test code.

Please be more specific. Did you get exactly the same error messages that I got?

Leonatus · 07-30-2019, 08:29 AM

Quote:

Originally Posted by Doitsu

download the latest version from the EPUBCheck github website and extract it and overwrite epubcheck.jar and the lib folder in the plugin folder.

Are you sure this hint is for the Sigil plugin version?

Quote:

Please be more specific. Did you get exactly the same error messages that I got?

"No errors found" - as well in your test file as in my book.

Doitsu · 07-30-2019, 08:39 AM

Quote:

Originally Posted by Leonatus

Are you sure this hint is for the Sigil plugin version?

Yes. The Sigil EpubCheck plugin folder contains epubcheck.jar and a lib folder. If you want to manually update the EPUBCheck version, you'll need to replace both epubcheck.jar and the lib folder with the files from the zip file that I linked to.

However, you shouldn't have to do this if you followed the instructions in my previous post.

DiapDealer · 07-30-2019, 09:07 AM

Quote:

Originally Posted by Doitsu

However, you shouldn't have to do this if you followed the instructions in my previous post.

Remember that https downloading via plugins is currently broken in 0.9.16 on MacOS -- as per Kevin and odamizu's above discussion. I have no idea if Leonatus is using a Mac or not, but I thought I'd mention it just in case.

Leonatus · 07-30-2019, 09:54 AM

Sorry for causing trouble. My system is Windows 10, and I have a main computer 64 bit and another, 32 bit.
On my main computer, I downloaded the zip-file, but at trying to integrate into Sigil it wasn't possible, because it were "no valid plugin", so I supposed it could be the standalone version. Now, I'm off from home again and have my 32 bit computer, and there the automatic download of 4.2.2 worked without problems. Of course, I tried the plugin in the same way as at home, and, here also the result is in both cases: "no problems found".
Please mind that now I have no access to my home computer, so for this time, I cannot try out anything you recommended.
By the way: the new version of Sigil (0.9.16) seems to be available only for 64 bit systems.

Of course, now I see that my misundedrstanding had been that I thought the download link were the plugin itself. sorry for that!

Leonatus · 08-01-2019, 09:00 AM

Now I also have version 4.2.2 at home, but the results are the same: "no problems found".

DiapDealer · 08-01-2019, 09:41 AM

Quote:

Originally Posted by Leonatus

Now I also have version 4.2.2 at home, but the results are the same: "no problems found".

Are you certain you're running the EpubCheck plugin and not the built-in Sigil Well-formed check (F7)?

07-21-2019, 01:46 PM	#241
KevinH Sigil Developer Posts: 8,799 Karma: 6000000 Join Date: Nov 2009 Device: many	Also since we run the EmbeddedPython routines explicitly without env vars, we are going to have to change python3lib updatechecker.py to set its own environment var for macOS just to be safe. Edit: So something like this added to our updatechecker.py inside Sigil's python3lib or added to any plugin should do the trick too. Code: import sys import os if sys.platform.startswith('darwin'): try: import certifi os.environ["SSL_CERT_FILE"]=certifi.where() except: pass Update: With both changes to updatechecker.py for our python3lib and to PluginRunner.cpp, and after I removed the bad symlink changes done by the install certify script, I was able with a clean rebuild to run EpubCheck and its update checker found a new update and downloaded it and ran. So I pushed all of these changes to master. In the interim, if a plugin wants to do an update check prehaps they could add the short macOS piece of python code near the top to get the current release to work. Last edited by KevinH; 07-21-2019 at 02:16 PM. Reason: Updates

07-21-2019, 09:54 PM	#243
KevinH Sigil Developer Posts: 8,799 Karma: 6000000 Join Date: Nov 2009 Device: many	If you do get a free moment, please add this snippet near the top of the epubcheck plugin.py, and re-enable update checking to see if this workaround fixes things for you. Code: if sys.platform.startswith('darwin'): try: import certifi os.environ["SSL_CERT_FILE"]=certifi.where() except: pass

07-30-2019, 02:46 AM	#245
Leonatus Wizard Posts: 1,055 Karma: 11391181 Join Date: Mar 2013 Location: Guben, Brandenburg, Germany Device: Kobo Clara 2E, Tolino Shine 3	Sigil v. 0.9.16. I use the plugin EpubCheck_v0.4.1.4, whereas a friend uses the standalone version. I created a book with some errors, due to unattentiousnes, such as Code: <h1><div>...</div></h1> As far as I know, divs should not be embedded in h1 elements. And the other: Code: <span class="center">...</span> What I learned is that spans should only be used embedded in block elements, what has been missing here. Now the strange is that epubcheck didn't put out an error message in the Sigil plugin version (for neither of the errors), but it did in the standalone version. Is there something one should know about that?

07-30-2019, 09:54 AM	#253
Leonatus Wizard Posts: 1,055 Karma: 11391181 Join Date: Mar 2013 Location: Guben, Brandenburg, Germany Device: Kobo Clara 2E, Tolino Shine 3	Sorry for causing trouble. My system is Windows 10, and I have a main computer 64 bit and another, 32 bit. On my main computer, I downloaded the zip-file, but at trying to integrate into Sigil it wasn't possible, because it were "no valid plugin", so I supposed it could be the standalone version. Now, I'm off from home again and have my 32 bit computer, and there the automatic download of 4.2.2 worked without problems. Of course, I tried the plugin in the same way as at home, and, here also the result is in both cases: "no problems found". Please mind that now I have no access to my home computer, so for this time, I cannot try out anything you recommended. By the way: the new version of Sigil (0.9.16) seems to be available only for 64 bit systems. Of course, now I see that my misundedrstanding had been that I thought the download link were the plugin itself. sorry for that! Last edited by Leonatus; 07-30-2019 at 10:05 AM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
[Plugin] PunctuationSmarten Sigil plugin	DiapDealer	Plugins	138	07-11-2023 11:22 AM
[Plugin] KindleImport Sigil plugin	DiapDealer	Plugins	187	07-04-2022 10:11 AM
Sigil Plugin Index	Thasaidon	Plugins	0	10-04-2014 07:41 AM
FC and Sigil 0.5.3 ePUBcheck failure	Hitch	Sigil	32	04-17-2012 02:56 AM
Web-based epubcheck upgraded to epubcheck 1.0.5	kjk	ePub	4	02-09-2010 09:53 PM

07-21-2019, 11:24 PM	#244
odamizu just an egg Posts: 1,831 Karma: 8006102 Join Date: Mar 2015 Device: Kindle, iOS	Yes! It worked! I did a clean install of the plugin then added your snippet after line 12 in plugin.py. On first-run, the plugin promptly checked for a new version, downloaded 4.2.2, then checked the open epub. Thanks!

07-30-2019, 04:36 AM	#247
Leonatus Wizard Posts: 1,055 Karma: 11391181 Join Date: Mar 2013 Location: Guben, Brandenburg, Germany Device: Kobo Clara 2E, Tolino Shine 3	I use the most recent version of Epubcheck, and as I'm not at home, I had at look at #1, where the version is called 0.4.1.4. But I'll look again at home, and then I shall follow your advice. Until now, I only created epub2 books.

07-30-2019, 07:35 AM	#248
Leonatus Wizard Posts: 1,055 Karma: 11391181 Join Date: Mar 2013 Location: Guben, Brandenburg, Germany Device: Kobo Clara 2E, Tolino Shine 3	I noticed that the .zip file is called 0.4.1.4, but at running the version no. is 4.2.1. Result is the same as I had written, even when trying with your test code. Where can I find version 4.2.2, please?

08-01-2019, 09:00 AM	#254
Leonatus Wizard Posts: 1,055 Karma: 11391181 Join Date: Mar 2013 Location: Guben, Brandenburg, Germany Device: Kobo Clara 2E, Tolino Shine 3	Now I also have version 4.2.2 at home, but the results are the same: "no problems found".