[GUI Plugin] FanFicFare

[Ser4nb2LUY6e]

Originally Posted by JimmXinu

All in all, I don't think BG job per download is worth pursuing any further.

Fair enough. Thanks for having a look!

[wildfire142]

Trying to download the story below and getting the following error

maximum recursion depth exceeded in cmp
https://forums.spacebattles.com/thre...isekai.587209/

setting that might be relevant - use_reader_mode:false

any clue did a quick search now obvious solutions.

[JimmXinu]

Originally Posted by wildfire142

Trying to download the story below and getting the following error

The SB site presents variously that there are 22, 24 or 29 Apocrypha threadmarks, and the 'elided' (...) link in the list doesn't work correctly.

So it's a bug in the story / site, but I will look into making FFF fail more gracefully.

Semi-related announcement

forums.sufficientvelocity.com, aka SV will be changing their software in the next few days.

I did develop changes to support the XF2 test site that was available, so I can hopefully support the new sites changes quickly, but there are no guarantees the site will be identical to the now-off-line test site.

[JimmXinu]

New Test Version Posted

2019-07-11
- Add a de-dup check to XF threadmark collection due to at least one SB story having TM bug.
- Adjust reader_posts_per_page for forum.questionablequesting.com.

[wildfire142]

Originally Posted by JimmXinu

The SB site presents variously that there are 22, 24 or 29 Apocrypha threadmarks, and the 'elided' (...) link in the list doesn't work correctly.

So it's a bug in the story / site, but I will look into making FFF fail more gracefully.

Semi-related announcement

forums.sufficientvelocity.com, aka SV will be changing their software in the next few days.

I did develop changes to support the XF2 test site that was available, so I can hopefully support the new sites changes quickly, but there are no guarantees the site will be identical to the now-off-line test site.

Thanks for the quick reply will try and grab it without the Apocrypha TM

[Atherton25]

I have a request. It may be difficult to implement, if so ignore it, but please review it at least.

When I update my stories via email sometimes I can have several stories, sometimes 40+ stories due to multiple sites giving me updates and the amount of time between checking.

After I get the list, I run FFF to download them. Lately I've been getting several timeouts or bad requests for one reason or another (likely bad internet service is a large part of it). This isn't a huge issue because it's easy to run it again with the URLs and generally that will get most of the failed downloads.
What is annoying is getting those URLs. Because of the way duplicate entries are sorted (as bad) the actual bad entries and the duplicates are sorted together. Usually my list is half duplicates because I wait several days before getting my email updates. This means I have to go through and pick out, one by one any actual 'bad' entries, paste them into another window one at a time until I have them all, then bring them back into FFF. Also, a few times I've forgotten to check the table before updating calibre, so I have to go pick them out of the job log instead.

What I'd like to request may be a two parts request, depending on how calibre handles the job log.
First, on the table that shows how the jobs are processed can it be sorted better? Possibly having a 'duplicate' option or something like that instead of just bad/successful so that when the table arranges itself, the dups are all together. Or just arrange the table better, sorting by more than just successful/bad columns? Just want all the actual 'bad' requests together so its easier to copy them out of the table.

The second may or may not be able to be tied into the above. I'd like that same information to be reflected in the job log so all the actual bad requests are together. That way if I miss checking the table I can still easily pull the bad requests from the log. Honestly, it looks like the way it filters before the successful/unsuccessful note is the same as the table, just not with all the table info, so if they're arranged a little better, this will likely sort itself.

Anyway, as always I love FFF and really appreciate everyone that dedicates time to work on it and add sites, as well as fix those that change, JimmXinu particularly.

Secondary request @ JimmXinu and/or @nexusflamehart: Was going to mention this a week ago, but I've been out of town and wanted to try and get it myself. I have tried several times getting that story on QuestionableQuesting called Ninja Ninja Tactics, that was mentioned on 6/23 and my internet timed out again. If (and only if) you have a copy of it available, could you PM me that link as well? I attribute that failed download to my internet. I've tried 3 times and it's timed out multiple times for me, and yes I used the options (no images/extras threads) mentioned in your post to nexusflamehart.

[Atherton25]

One other thing I keep forgetting to ask about. This is likely not something that can be fixed, because it's likely beautiful soup which is doing it. Fairly regularly I run across 'email protected' in the middle of my paragraph. What I've found is that often (if not always) it's because the author has done something like #&*@!^& instead of swearing/having a word shown, and has a @ symbol included. Sometimes it's for a 'password' (in the story) or something else. I've never actually seen it used for emails in the downloaded stories. Is there a way to get that fixed, or is it all something handled by beautiful soup, and not anything that can be corrected?

[JimmXinu]

New Test Version Posted

2019-07-12
- Plugin: Group reported results better.

Originally Posted by Atherton25

... (please order results better) ...

See above.

Originally Posted by Atherton25

... story on QuestionableQuesting called Ninja Ninja Tactics ...

Already deleted.

Originally Posted by Atherton25

... Fairly regularly I run across 'email protected' in the middle of my paragraph. ...

I've only seen that on XF forums. It's an artifact of the forum--they 'protect' 'email addresses' in the HTML and then convert them back to readable with javascript to prevent page scrapers from harvesting them.

It's pretty difficult to argue that FFF isn't a page scraper. I'm not going to get into that arms-race, so unfortunately, it is what it is.

[wildfire142]

You are probably aware of this but the upgrade to sufficient velocity has broken something as FFF gives the following when I download the following two tests and got this error both times.

'NoneType' object has no attribute 'h1'
https://forums.sufficientvelocity.co...worm-au.54757/
https://forums.sufficientvelocity.co...d-pieces.35274

[JimmXinu]

New Test Version Posted

2019-07-13
- Changes to adapter_forumssufficientvelocitycom for XenForo2 migration.
- Fix for Plugin: Group reported results better for meta-only updates.

[wildfire142]

Works fine thanks for the quick update.

[ILB]

Originally Posted by JimmXinu

New Test Version Posted

2019-07-13
- Changes to adapter_forumssufficientvelocitycom for XenForo2 migration.
- Fix for Plugin: Group reported results better for meta-only updates.

I installed the test version und now every time I close the e-book viewer I get the following error message:

Spoiler:

calibre, version 3.45.0
ERROR: Unhandled exception: <b>SystemError</b>:error return without exception set

calibre 3.45 [64bit] embedded-python: True is64bit: True
Windows-10-10.0.17134-SP0 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.17134')
Python 2.7.15+
Windows: ('10', '10.0.17134', 'SP0', u'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: Similar Stories (1, 0, 58) && Read MP3 AudioBook metadata (1, 0, 79) && Quick Preferences (1, 4, 1) && FanFicFare (3, 9, 7) && EpubMerge (2, 5, 0) && KoboTouchExtended (3, 1, 3) && Count Pages (1, 8, 2) && Generate Cover (1, 5, 21) && Manage Series (1, 2, 8) && Copy Cover To Device (2, 0, 0) && Annotations (1, 9, 2) && SmartEject (2, 2, 0) && Reading List (1, 6, 6) && Find Duplicates (1, 6, 3)
Traceback (most recent call last):
File "site-packages\calibre\gui2\viewer\main.py", line 379, in closeEvent
File "site-packages\calibre\gui2\viewer\main.py", line 366, in shutdown
File "site-packages\calibre\gui2\viewer\main.py", line 392, in save_state
File "site-packages\calibre\utils\config.py", line 448, in __setitem__
File "site-packages\calibre\utils\config.py", line 411, in commit
File "site-packages\calibre\utils\config.py", line 432, in to_raw
File "site-packages\calibre\utils\config_base.py", line 86, in json_dumps
File "json\__init__.py", line 251, in dumps
File "json\encoder.py", line 209, in encode
File "json\encoder.py", line 434, in _iterencode
File "json\encoder.py", line 408, in _iterencode_dict
File "json\encoder.py", line 313, in _iterencode_list
File "json\encoder.py", line 39, in encode_basestring
SystemError: error return without exception set

[JimmXinu]

Originally Posted by ILB

I installed the test version und now every time I close the e-book viewer I get the following error message:

Spoiler:

calibre, version 3.45.0
ERROR: Unhandled exception: <b>SystemError</b>:error return without exception set

calibre 3.45 [64bit] embedded-python: True is64bit: True
Windows-10-10.0.17134-SP0 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.17134')
Python 2.7.15+
Windows: ('10', '10.0.17134', 'SP0', u'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: Similar Stories (1, 0, 58) && Read MP3 AudioBook metadata (1, 0, 79) && Quick Preferences (1, 4, 1) && FanFicFare (3, 9, 7) && EpubMerge (2, 5, 0) && KoboTouchExtended (3, 1, 3) && Count Pages (1, 8, 2) && Generate Cover (1, 5, 21) && Manage Series (1, 2, 8) && Copy Cover To Device (2, 0, 0) && Annotations (1, 9, 2) && SmartEject (2, 2, 0) && Reading List (1, 6, 6) && Find Duplicates (1, 6, 3)
Traceback (most recent call last):
File "site-packages\calibre\gui2\viewer\main.py", line 379, in closeEvent
File "site-packages\calibre\gui2\viewer\main.py", line 366, in shutdown
File "site-packages\calibre\gui2\viewer\main.py", line 392, in save_state
File "site-packages\calibre\utils\config.py", line 448, in __setitem__
File "site-packages\calibre\utils\config.py", line 411, in commit
File "site-packages\calibre\utils\config.py", line 432, in to_raw
File "site-packages\calibre\utils\config_base.py", line 86, in json_dumps
File "json\__init__.py", line 251, in dumps
File "json\encoder.py", line 209, in encode
File "json\encoder.py", line 434, in _iterencode
File "json\encoder.py", line 408, in _iterencode_dict
File "json\encoder.py", line 313, in _iterencode_list
File "json\encoder.py", line 39, in encode_basestring
SystemError: error return without exception set

That's not FFF code. Did you restart Calibre after installing the plugin?

[PeterT]

Originally Posted by ILB

I installed the test version und now every time I close the e-book viewer I get the following error message:

calibre, version 3.45.0

You might want to install 3.45.2 and see if that helps

[FanFicFareFan]

Just a heads up, Sufficient velocity has updated to a new xenforo format, and seems to no longer be compatible with FFFF. I tried updating a fic (https://forums.sufficientvelocity.co...justice.35443/) and got the following message: "'NoneType' object has no attribute 'h1'". Status is 'bad.