[Bug?] Sigil's inconsistent behavior with italics and bold - Page 3

KevinH · 06-09-2018, 08:07 AM

Quote:

Originally Posted by kovidgoyal

@KevinH: You need to normalize() before calculating the path. https://developer.mozilla.org/en-US/...Node/normalize

Thank you! I will give that a try.

KevinH

Turtle91 · 06-09-2018, 10:49 AM

Quote:

Originally Posted by DiapDealer

Clickable Preview links have already been added. https://github.com/Sigil-Ebook/Sigil...6f3a402c364fa6

Book View:

BetterRed · 06-09-2018, 07:45 PM

Quote:

Originally Posted by DiapDealer

Clickable Preview links have already been added. https://github.com/Sigil-Ebook/Sigil...6f3a402c364fa6

Is that in 0.9.9? For some forgotten reason I'm still on 0.9.8.

BR

Turtle91 · 06-09-2018, 07:47 PM

I just tried it on 9.9. Not there yet.

DiapDealer · 06-09-2018, 07:50 PM

Sorry I wasn't clearer. That commit was after the 0.9.9 release. But it's ready to go for the next release.

Notjohn · 06-10-2018, 06:33 AM

Quote:

Originally Posted by DiapDealer

Clickable Preview links have already been added. https://github.com/Sigil-Ebook/Sigil...6f3a402c364fa6

Excellent! For me, since Preview Pane came to live with us, that was Book View's only function. I look forward to the update.

Now that Sigill is perfect, will this be 1.0.0?

DiapDealer · 06-10-2018, 09:11 AM

Quote:

Originally Posted by Notjohn

Now that Sigill is perfect, will this be 1.0.0?

Hardly.

I've not talked to Kevin about it, but 0.9.10 or 0.10.0 makes the most sense to me.

BetterRed · 06-10-2018, 07:13 PM

When I've updated Sigil in the past I've lost some of my keyboard shortcut settings. I think it happens when a new 'factory' shortcut is introduced that uses the same sequence as one already in use. One I can remember was F7, which I had assigned to Spellcheck, which become Well-formed Check, and Spellcheck became Alt+Q.

IMO if Sigil is being updated the existing keyboard shortcuts should be left as-is.

Because I'm keyboard-centric I reconfigure/reassign keyboard shortcuts more than most users, consistency across applications is one of my main aims.

BR

DiapDealer · 06-10-2018, 07:50 PM

We don't purposely change keyboard shortcuts.

F7 was always the default shortcut for the integrated Flightcrew Validation feature. When Flightcrew was removed from Sigil, the Well-formed check took its place--including its default F7 keyboard shortcut.

When we add a new feature that needs a keyboard shortcut, there's simply no way for us to easily know if a user has reassigned one of the default shortcuts to something else. It seemed a no-brainer for the Well-Formed check to take Flightcrew's. I don't know how we could have done it any differently.

Sigil is never really "updated," for the record. It's just a new installation over top of the old. There is no separate upgrade vs install procedure. If there are ini files and a prefs folder already present upon launch, Sigil uses those instead of creating new default ones.

BetterRed · 06-11-2018, 12:34 AM

I could be wrong but after the upgrade, I think F7 was assigned to Mend HTML and Spellcheck.

And I don't think the Spellcheck shortcut is the only one I've lost when updating. On another occasion I recall losing my Next/Previous Tab shortcuts, which I had assigned to Ctrl+Alt+→ and Ctrl+Alt←, they reverted to something like Alt+PgUp and Alt+PgDn.

I've made a note to remind me cut and paste the 'shortcuts' section from last night's backup of sigil.ini after I install a new version.

Added: I appreciate programs, like Sigil, that provide user control over keyboard shortcuts, but in my opinion most, including Sigil, ship with too many pre-set defaults.

BR

KevinH · 06-11-2018, 12:57 PM

Hi Kovid,

Using normalize() seems to help but ... calling normalize() on the anchorNode or its parent or even the entire document seems to clear/reset the cursor or highlighted region in BookView. My guess is the highlighted code is actually the part that is being normalized away. This same javascript routine is used to save the cursor position while editing in BookView and having your highlighted text randomly become unhighlighted makes things a bit tough.

I guess I could simply always return the parent node of the text field as the cursor position.

Any other advice?

KevinH

Quote:

Originally Posted by kovidgoyal

@KevinH: You need to normalize() before calculating the path. https://developer.mozilla.org/en-US/...Node/normalize

kovidgoyal · 06-11-2018, 09:46 PM

Sorry, no. There's a reason I decided not to implement book view in calibre's editor

KevinH · 06-12-2018, 10:06 AM

FYI, a "fix" for this BV to CV transition crash has now been committed to master. It will use the normalized DOM tree only during transitions and will otherwise pick a sane sibling or parent of the text node for the cursor location when the current anchor gets merged away.

AlanHK · 06-30-2018, 04:07 AM

Quote:

Originally Posted by DiapDealer

Hardly.

I've not talked to Kevin about it, but 0.9.10 or 0.10.0 makes the most sense to me.

So, 0.10 comes after 0.9??

Aside from the numeric logic, surely it's time to go to 1.0?
It's been in beta for almost 10 years, FFS.

DiapDealer · 06-30-2018, 06:35 AM

Quote:

Originally Posted by AlanHK

So, 0.10 comes after 0.9??

Yes, of course it does. It's a versioning system, not decimal math. 10 follows nine. The period is merely a separator between the segments, not a decimal point.

Quote:

Originally Posted by AlanHK

Aside from the numeric logic, surely it's time to go to 1.0?
It's been in beta for almost 10 years, FFS.

Time has nothing to do with it. We set a personal goal of full epub3 support (as well as structural file/folder independence) as the determining factor for the 1.0 release.

06-10-2018, 07:50 PM	#39
DiapDealer Grand Sorcerer Posts: 28,617 Karma: 204624552 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	We don't purposely change keyboard shortcuts. F7 was always the default shortcut for the integrated Flightcrew Validation feature. When Flightcrew was removed from Sigil, the Well-formed check took its place--including its default F7 keyboard shortcut. When we add a new feature that needs a keyboard shortcut, there's simply no way for us to easily know if a user has reassigned one of the default shortcuts to something else. It seemed a no-brainer for the Well-Formed check to take Flightcrew's. I don't know how we could have done it any differently. Sigil is never really "updated," for the record. It's just a new installation over top of the old. There is no separate upgrade vs install procedure. If there are ini files and a prefs folder already present upon launch, Sigil uses those instead of creating new default ones. Last edited by DiapDealer; 06-10-2018 at 08:04 PM.

06-11-2018, 12:34 AM	#40
BetterRed null operator (he/him) Posts: 21,752 Karma: 30237526 Join Date: Mar 2012 Location: Sydney Australia Device: none	I could be wrong but after the upgrade, I think F7 was assigned to Mend HTML and Spellcheck. And I don't think the Spellcheck shortcut is the only one I've lost when updating. On another occasion I recall losing my Next/Previous Tab shortcuts, which I had assigned to Ctrl+Alt+→ and Ctrl+Alt←, they reverted to something like Alt+PgUp and Alt+PgDn. I've made a note to remind me cut and paste the 'shortcuts' section from last night's backup of sigil.ini after I install a new version. Added: I appreciate programs, like Sigil, that provide user control over keyboard shortcuts, but in my opinion most, including Sigil, ship with too many pre-set defaults. BR Last edited by BetterRed; 06-11-2018 at 12:44 AM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
bold and italics	FAMOsa	Sigil	7	09-09-2017 12:15 PM
Email to Kindle - plugboard behavior inconsistent	lairdb	Calibre	11	08-17-2016 05:49 PM
Italics, Bold, Etc.	Arekuzanra	Amazon Kindle	14	03-09-2014 11:01 PM
iPad "Upgraded" to iBooks 3.2 – Bold fonts are extra-bold, italics are now bold-italic	MHC	Apple Devices	4	03-03-2014 01:50 PM
Weird Kindle DX bug (possibly calibre related) Italics/Bold	Andybaby	Amazon Kindle	4	02-14-2011 09:52 AM

06-09-2018, 07:47 PM	#34
Turtle91 A Hairy Wizard Posts: 3,355 Karma: 20171571 Join Date: Dec 2012 Location: Charleston, SC today Device: iPhone 15/11/X/6/iPad 1,2,Air & Air Pro/Surface Pro/Kindle PW & Fire	I just tried it on 9.9. Not there yet.

06-09-2018, 07:50 PM	#35
DiapDealer Grand Sorcerer Posts: 28,617 Karma: 204624552 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	Sorry I wasn't clearer. That commit was after the 0.9.9 release. But it's ready to go for the next release.

06-10-2018, 07:13 PM	#38
BetterRed null operator (he/him) Posts: 21,752 Karma: 30237526 Join Date: Mar 2012 Location: Sydney Australia Device: none	When I've updated Sigil in the past I've lost some of my keyboard shortcut settings. I think it happens when a new 'factory' shortcut is introduced that uses the same sequence as one already in use. One I can remember was F7, which I had assigned to Spellcheck, which become Well-formed Check, and Spellcheck became Alt+Q. IMO if Sigil is being updated the existing keyboard shortcuts should be left as-is. Because I'm keyboard-centric I reconfigure/reassign keyboard shortcuts more than most users, consistency across applications is one of my main aims. BR

06-11-2018, 09:46 PM	#42
kovidgoyal creator of calibre Posts: 45,382 Karma: 27756918 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Sorry, no. There's a reason I decided not to implement book view in calibre's editor

06-12-2018, 10:06 AM	#43
KevinH Sigil Developer Posts: 8,807 Karma: 6000000 Join Date: Nov 2009 Device: many	FYI, a "fix" for this BV to CV transition crash has now been committed to master. It will use the normalized DOM tree only during transitions and will otherwise pick a sane sibling or parent of the text node for the cursor location when the current anchor gets merged away.