[Plugin] cssRemoveUnusedSelectors

[KevinH]

That is a python 3 error message when a bytes object is added to a string object. My guess is that the prefs are being read in as bytes for some reason and can't be directly concatenated without a call to decode. But this is only a wild guess.

[Doitsu]

Originally Posted by Auramazda

Hi, I tried the plug-in on a css with too many stile but I get a error message

I got the same message in an earlier version. Uninstall the plugin, download and install the latest version and re-run the plugin.

If you're still getting the error message, please post the stylesheet that caused the error message.

[Auramazda]

Is the last version, I downloaded it tonight, I deleted and reinstalled it but I got the same message.
The CSS is:
https://www.dropbox.com/s/d2n6iv1815...stili.css?dl=0

PS thanks for the fast reply

[KevinH]

Is the b byte indicator needed here? See plugin.py

def get_css_output_prefs(bk):
    prefs = bk.getPrefs()
    prefs.defaults['indent'] = "\t" #2 * ' '
    prefs.defaults['indentClosingBrace'] = False
    prefs.defaults['keepEmptyRules'] = True
    prefs.defaults['omitLastSemicolon'] = False
    prefs.defaults['omitLeadingZero'] = False
    prefs.defaults['blankLinesAfterRules'] = 1 * b'\n'
    prefs.defaults['formatUnknownRules'] = False
    return prefs

[wrCisco]

Yes, that 'b' is the problem. Already fixed on github but I didn't find the time to upload a new release yet (I'll do it this evening).

In the meanwhile, in order to bypass the problem, you can just open the preferences dialog and click on "save and continue" (incorrect string type is only on default values, and the plugin uses them only when no preferences file exists).

[wrCisco]

Just uploaded version 0.2.2 with the fix.

[wrCisco]

Just uploaded v0.2.3 of the plugin to guarantee compatibility with Sigil v0.9.7, that changes reading mode of stylesheet files.

[DiapDealer]

Originally Posted by wrCisco

Just uploaded v0.2.3 of the plugin to guarantee compatibility with Sigil v0.9.7, that changes reading mode of stylesheet files.

For what it's worth, the .decode() bit was never working correctly on Linux even before Sigil v0.9.7. I had to remove .decode() from two places to get cssRemoveUnusedSelectors v0.2.2 to work with Sigil 0.9.6 on Linux (similar to your 0.2.3 modification). I never got around to mentioning that. Sorry. I can verify that v0.2.3 does work "out of the box" on Sigil v0.9.7 on Linux, though. Thanks.

[wrCisco]

Strange. To me it always worked correctly on Ubuntu. Anyway, glad that the new version is OK, thanks for testing.

[wrCisco]

Uploaded the version 0.3.0 of the plugin, which can parse xml files in epub (not only xhtml), has a more robust handling of css namespaces and is licensed as free software (GPLv3).

[Turtle91]

Hi, the plugin gave an error notice to the following css styles:

color:RGB(0,124,196)

I'm pretty sure that is valid css??

.HC      {color:RGB(239,50,36); font-size:1.1em; line-height:1.5}
.HC em   {color:RGB(136,137,140)}
.HC span {color:RGB(0,124,196)} 
.HC img  {max-width:20px; max-height:23px}

When I removed the 3 lines with color:xxxx it worked fine.

[Doitsu]

Originally Posted by Turtle91

color:RGB(0,124,196)

The parser that the plugin uses expects lower case rgb() declarations. Try changing RGB() to rgb().

[wrCisco]

Yes, that seems to be a bug in cssutils that does a case sensitive match with 'rgb(', 'rgba(' and relatives, while it should be ASCII case insensitive.
I'll file a bug report to cssutils.

In the meantime the workaround is, as suggested by Doitsu, to use only lowercase characters for color functions.

(I think that the patch in cssutils should be something like this...
In cssutils/css/value.py, in method _setCssText of class ColorValue:

noalp = Sequence(Prod(name='FUNCTION',
                      match=lambda t, v: t == types.FUNCTION and
                                              v in ('rgb(', 'hsl('),
...
witha = Sequence(Prod(name='FUNCTION',
                      match=lambda t, v: t == types.FUNCTION and
                                              v in ('rgba(', 'hsla('),

should become:

noalp = Sequence(Prod(name='FUNCTION',
                      match=lambda t, v: t == types.FUNCTION and
                                              v.lower() in ('rgb(', 'hsl('),
...
witha = Sequence(Prod(name='FUNCTION',
                      match=lambda t, v: t == types.FUNCTION and
                                              v.lower() in ('rgba(', 'hsla('),

).

Thanks for the bug report!

[Turtle91]

That did the trick! Thanks!!

[DNSB]

Originally Posted by Turtle91

That did the trick! Thanks!!

Sounds much like what one instructor told a class I was in, "The CSS specification says 'All CSS style sheets are case-insensitive' and goes on to say 'element names are case-insensitive in HTML, but case-sensitive in XML' so don't use anything but lowercase unless absolutely needed since I will guarantee that it will bite you in the butt."

Admittedly, his favourite t-shirt read "Murphy was a raving optimist".