|
|
#31 |
|
Guru
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 877
Karma: 2676800
Join Date: Sep 2008
Location: Taranaki - NZ
Device: Kobo Aura H2O, Kobo Forma
|
Hi geek1011
A couple of thoughts on your new patch format. Why not include the patch description as part of each patch, instead of outside in comments? It would make parsing the description easier. Also, have you thought about more defined versioning information (with regards to firmware version etc), rather than specifying the version in a comment somewhere? Cheers, Sherman |
|
|
|
|
|
#32 | |
|
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 2,811
Karma: 7423683
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD, Clara BW, Libra Colour
|
Quote:
As for the versioning, I was considering it, but decided against it. Firstly, the patches will most likely fail if applied to the wrong version. Secondly, it is very difficult to extract the version info from the binary, and thirdly, it is hard to represent things like ranges in an concise way. |
|
|
|
|
|
|
#33 |
|
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 6,270
Karma: 16544702
Join Date: Sep 2009
Location: UK
Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3
|
@geek1011,
As an occasional patch contributor I'll be happy to test your new system if I can do the testing on Windows. Is this possible at the moment? Also a comment about Offset/Find/Replace… I like the new option which places each of these on its own line rather than combining into a single line. It should be less confusing for new users who want to tweak the defaults. For me the single line of the current system is what makes it more awkward to ensure that the before/after strings are the same length. I'm looking forward to being able to patch nickel zlib css in a more user-friendly way. I'm hoping it will make it possible for users to fine-tune them. |
|
|
|
|
|
#34 | |
|
I need a chapter break
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 4,042
Karma: 56058267
Join Date: Mar 2015
Location: Israel
Device: Kobo Glo
|
Quote:
@geek1011 it works ok, what the difference between the old and new file. Edit: never mind I read the README.md, I'm waiting for the zlib support. Last edited by oren64; 04-27-2018 at 08:32 AM. |
|
|
|
|
|
|
#35 |
|
Evangelist
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 469
Karma: 600816
Join Date: Sep 2009
Device: Kobo Aura HD, Kobo Aura One
|
Code:
- FindBaseAddress: "ReadingFooter {\n qproperty-footerMargin: 105;\n}\n"
- ReplaceString: {Offset: 0x0, Find: "ReadingFooter {\n qproperty-footerMargin: 105;\n}\n", Replace: "ReadingFooter {min-height:15px;max-height:15px;}\n"}
Code:
- FindBaseAddress: "ReadingFooter {\n qproperty-footerMargin: 105;\n}\n"
- ReplaceString: {Offset: 0x0, Replace: "ReadingFooter {min-height:15px;max-height:15px;}\n"}
|
|
|
|
|
|
#36 |
|
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 6,270
Karma: 16544702
Join Date: Sep 2009
Location: UK
Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3
|
I should have been more specific in my question. I saw a couple of linux files (testalllibnickel.sh and testallnickel.sh) which I thought (perhaps wrongly) were needed to check old-result vs. new-result.
Last edited by jackie_w; 04-27-2018 at 10:11 AM. |
|
|
|
|
|
#37 | |
|
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 6,270
Karma: 16544702
Join Date: Sep 2009
Location: UK
Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3
|
Quote:
|
|
|
|
|
|
|
#38 |
|
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 6,270
Karma: 16544702
Join Date: Sep 2009
Location: UK
Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3
|
@geek1011,
I can't help thinking that discussion about your proposed new patching method deserves a new thread of its own. Most of the people coming to this thread aren't interested in the inner workings of a future patching system, they just want help with the current system on the latest firmware. |
|
|
|
|
|
#39 |
|
Connoisseur
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 79
Karma: 10000
Join Date: Jul 2012
Location: Israel
Device: KA1, KLH2O, Oasis 3
|
Removed.
Last edited by makara; 04-27-2018 at 05:29 PM. Reason: The problem is solved. |
|
|
|
|
|
#40 | |
|
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 2,811
Karma: 7423683
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD, Clara BW, Libra Colour
|
Quote:
|
|
|
|
|
|
|
#41 | |
|
Evangelist
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 469
Karma: 600816
Join Date: Sep 2009
Device: Kobo Aura HD, Kobo Aura One
|
Quote:
|
|
|
|
|
|
|
#42 | |
|
Zealot
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 113
Karma: 32126
Join Date: Dec 2017
Location: Madrid (Spain)
Device: Kobo Aura H2O Ed2, Onyx Boox C67ML
|
Quote:
|
|
|
|
|
|
|
#43 |
|
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 2,811
Karma: 7423683
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD, Clara BW, Libra Colour
|
|
|
|
|
|
|
#44 | |
|
I need a chapter break
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 4,042
Karma: 56058267
Join Date: Mar 2015
Location: Israel
Device: Kobo Glo
|
Quote:
Last edited by oren64; 05-04-2018 at 07:15 AM. |
|
|
|
|
|
|
#45 | |
|
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 2,811
Karma: 7423683
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD, Clara BW, Libra Colour
|
Quote:
|
|
|
|
|
![]() |
|
Similar Threads
|
||||
| Thread | Thread Starter | Forum | Replies | Last Post |
| Instructions for patching firmware 3.13.1 | GeoffR | Kobo Developer's Corner | 56 | 07-01-2016 10:59 AM |
| Instructions for patching firmware 3.16.10 | GeoffR | Kobo Developer's Corner | 12 | 08-14-2015 04:40 AM |
| Instructions for patching firmware 3.16.0 | GeoffR | Kobo Developer's Corner | 74 | 08-12-2015 03:12 PM |
| Instructions for patching firmware 3.8.0 | GeoffR | Kobo Developer's Corner | 92 | 10-22-2014 08:22 AM |
| Instructions for patching firmware 3.3.x, 3.4.x, 3.5.x | GeoffR | Kobo Developer's Corner | 285 | 08-27-2014 11:06 AM |