"unused stylesheet class" is actually used

[AlanHK]

In this ePub I used this pair of style definitions:

.letter, .letter1 {
    display: block;
    margin-bottom: 0;
    margin-left: 2em;
    margin-right: 1em;
    margin-top: 0em;
    text-align: left;
    text-indent: 2em;
    }

 .letter1 {
    margin-top: 2em;
    text-indent: 0;
    }

And in the pages used them:

<p class="letter1">Dear Mr. Wells,</p>

  <p class="letter">Your attendance is requested in an investigation
of grave importance to the Royal Family of the Nederlands. Please
consult S. Holmes posthaste regarding your willingness to participate.</p>

  <p class="letter">Sec. to H.M. Emma of Waldeck-Pyrmont</p>

The idea being to have the first line of a letter with a top margin and no indent, otherwise the same as the "body" of the letter.

This looked as expected and validated with epubcheck.
But running Sigil's "Delete Unused Stylesheet Classes" and it includes "letter1" as unused.

Is this a bug in that function, or is this kind of CSS invalid?

[KevinH]

Which version of Sigil? There was a similar bug fixed in an earlier but recent version of Sigil but I am not sure which one.

If the latest version, 0.9.8 then most probably a bug in Sigil that I will track down and fix.

[Doitsu]

Originally Posted by KevinH

Which version of Sigil? There was a similar bug fixed in an earlier but recent version of Sigil but I am not sure which one.

Originally Posted by AlanHK

I'm using Sigil 0.91.

Originally Posted by KevinH

If the latest version, 0.9.8 then most probably a bug in Sigil that I will track down and fix.

I wasn't able to reproduce this issue with the 64bit 0.9.8 Windows version.

[KevinH]

So it is most probably a css parsing bug already fixed.

Thanks for testing it!

Originally Posted by Doitsu

I wasn't able to reproduce this issue with 64bit 0.9.8 Windows version.

[Turtle91]

The only consistent issue I've seen with the remove unused stylesheet classes tool is that it still doesn't recognize when pseudo-element selectors have been used in the document.

eg.
p.first:first-letter
p.first:first-line


Even when <p class="first"> is used in the document they are still tagged for deletion. It is easy enough to uncheck the box, but only if you know to look for it.

[wrCisco]

Originally Posted by Turtle91

The only consistent issue I've seen with the remove unused stylesheet classes tool is that it still doesn't recognize when pseudo-element selectors have been used in the document.

I'm just making a quick reappearance to do a shameless promotion of the plugin I published here at MobileRead last year, cssRemoveUnusedSelectors, that goes over that and other limitations of the standard Sigil tool.

Just in case new users lost it...

Originally Posted by KevinH

Which version of Sigil?

You fixed that bug before releasing v0.9.6 (I remember testing it...).

I don't use Sigil anymore as much as I'd like, but it's always a pleasure to read and see the great work that maintainers and active users do.

[DiapDealer]

Originally Posted by wrCisco

I'm just making a quick reappearance to do a shameless promotion of the plugin I published here at MobileRead last year, cssRemoveUnusedSelectors, that goes over that and other limitations of the standard Sigil tool.

Just in case new users lost it...

Ack! I should have remembered that. I use your plugin enough that you'd think that wouldn't happen.