Beta testers for calibre 3.0 needed

[eschwartz]

Did not even notice that. I would have thought that equality searches would be superior in that respect.

[kovidgoyal]

That should take care of it.

https://github.com/kovidgoyal/calibr...41f9648e31906f

[jony08]

Originally Posted by kovidgoyal

I think it is fine where it is. It does not cover the entire width of the Tag browser and your proposed alternateives all have costs that IMO are not worth it.

I agree with BetterRed, that the buttons on the bottom of the Tag browser could be moved to the top because that would make it easier to distinguish the Tag browser from the VL button. Or have a header for the Tag browser, like "Categories"?

[BetterRed]

Originally Posted by kovidgoyal

That should take care of it.

https://github.com/kovidgoyal/calibr...41f9648e31906f

How about changing it to "Get saved search term", which seems to used elsewhere (e.g. Prefs->Searching) - I thought that might be what it was, but I was coming from the Tag Browser too.

If calibre gets a full text search feature it could be confusing.

BR

[jony08]

Originally Posted by kovidgoyal

@BR: I like option 4: https://github.com/kovidgoyal/calibr...d3b94ad77ecb89

For me it is confusing and adds clutter to keep the icons in the Layout drop down. It may help to move Show/hide before the icons.

[chaley]

Originally Posted by BetterRed

How about changing it to "Get saved search term", which seems to used elsewhere (e.g. Prefs->Searching) - I thought that might be what it was, but I was coming from the Tag Browser too

In this case the correct word is "expression", not "term". A term is a single search item/clause, such as aaa or authors:aaa. Preferences / Search uses the word "term" correctly because it is referring to what happens if the single item doesn't have a qualifier (is naked).

A search "expression" is a collection of terms. The operation in that drop down gets the text, the expression, associated with the saved search name.

I don't care if it says "Get saved search text" or "Get saved search expression". You do, so I will change it.

[chaley]

Originally Posted by eschwartz

When I click it, it does absolutely nothing at all, but I thought it sounded like it should copy the actual search string that the saved search resolves to, either to the clipboard or the searchbar.

It doesn't do "nothing at all". If it can't figure out what saved search is being used or if the search name is invalid then it puts an error in the status line.

Originally Posted by JimmXinu

I feel the same way about the tag browser. Didn't even know it could show saved searches.

Update: "Get saved search text" does work if you typed in a saved search like:

search:"Search Name"

"Get saved search text" does not work if the search in the bar is:

search:"=Search Name"

...which is what tag browser puts up there. The = is the difference.

It is actually my bad.

There are five ways to refer to a saved search:

• search:="fff"
• search:"=fff"
• search:fff
• search:=fff
• search:"fff"

All of these are equivalent if the search name does not contain a space.

I was lazy in my testing. My original code handled #1, which is what clicking on a search in the drop down produces. Kovid's fix picked up #2, which is what the tag browser produces. I just submitted a change to pick up the last 3.

Note: the equals sign has no significance at all when referring to a saved search and can always be left out. The quotes are necessary only if the search name contains spaces.

[Nicolas F]

A small layout problem:
In the calibre book viewer settings the text is cut in the page flip/scrolling options.

(apparently it's also the case in older versions of calibre)

[jony08]

One more suggestion:
add a Toolbar option in the Layout drop down where you can change the icon size and Show/hide text under icons of the Toolbar.

[kovidgoyal]

@NicolasF: That should take care of it https://github.com/kovidgoyal/calibr...9ab571c43f7647

[Nicolas F]

Originally Posted by kovidgoyal

@NicolasF: That should take care of it https://github.com/kovidgoyal/calibr...9ab571c43f7647

Thanks

One remark for the tag browser: what about using a non clickable label "Tag browser", with two icons button around (setting on the left and search on the right). You could put it on top to separate with the virtual libraries as some peoples have suggested. Or at least deleting the find label since the magnifying glass icon is self explaining

I say this because in some languages (french included) with longer translations adding the find button here with an icon force the tag browser to be quite large (you can't reduce it more than the two button width)

[BetterRed]

Originally Posted by chaley

In this case the correct word is "expression", not "term". A term is a single search item/clause, such as aaa or authors:aaa. Preferences / Search uses the word "term" correctly because it is referring to what happens if the single item doesn't have a qualifier (is naked).

A search "expression" is a collection of terms. The operation in that drop down gets the text, the expression, associated with the saved search name.

I don't care if it says "Get saved search text" or "Get saved search expression". You do, so I will change it.

Thanks

A calibre Search Expression is a collection of Search Terms makes sense.

However, I find the following snippet from the manual somewhat confusing:




One of my English teacher's had a set of commandments; one of which was: "Unless for rhetorical purposes, thou shalt not use different words to refer to the same thing, nor yet the same word to refer to different things.". Some of her rules have stuck with me ever since. Her aim with a blackboard duster was deadly, and she was our cricket coach

BR

[BetterRed]

Originally Posted by Nicolas F

Thanks

One remark for the tag browser: what about using a non clickable label "Tag browser", with two icons button around (setting on the left and search on the right). You could put it on top to separate with the virtual libraries as some peoples have suggested. Or at least deleting the find label since the magnifying glass icon is self explaining

Attachment 157264

I say this because in some languages (french included) with longer translations adding the find button here with an icon force the tag browser to be quite large (you can't reduce it more than the two button width)

I like this idea. IMO the two icons are self explanatory, and they already have good tool tips, and because it gets the 'clutter' at the top.

@NicolasF, do you envisage the fixed label "Tag browser" being replaced by a Text box when the Search icon is clicked?

Some Tag browser related settings are in Preferences->Look and Feel->Tag Browser, others are in the empty space context menu, and the rest are in the (Alter) Tag Browser configuration.

1. Could the settings in the empty space context menu be moved to the Tag Browser Configuration menu?
2. Could the Manage authors, tags etc menu be moved to a regular Toolbar feature - Manage xxxxxx (Entities ?)
3. Could a link to Preferences->Look and Feel->Tag Browser be added to the Tag browser Configuration menu

BR

[BetterRed]

Originally Posted by chaley

It doesn't do "nothing at all". If it can't figure out what saved search is being used or if the search name is invalid then it puts an error in the status line.

I never noticed that.

I suggest error messages displayed in the status line should make a sound and/or be displayed in Red - maybe put some settings in Look and Feel to specify the sound and/or colour - or in a Tweak.

BR

[jony08]

Originally Posted by BetterRed

I like this idea. IMO the two icons are self explanatory, and they already have good tool tips, and because it gets the 'clutter' at the top.

@NicolasF, do you envisage the fixed label "Tag browser" being replaced by a Text box when the Search icon is clicked?

Some Tag browser related settings are in Preferences->Look and Feel->Tag Browser, others are in the empty space context menu, and the rest are in the (Alter) Tag Browser configuration.

1. Could the settings in the empty space context menu be moved to the Tag Browser Configuration menu?
2. Could the Manage authors, tags etc menu be moved to a regular Toolbar feature - Manage xxxxxx (Entities ?)
3. Could a link to Preferences->Look and Feel->Tag Browser be added to the Tag browser Configuration menu

BR

I like the idea of moving everything together.

Some of options related to the Layout could be moved to the Layout button drop down menu in a Tag browser sub-menu, that way they would be in the same place. Many of the settings in the Alter Tag browser could be moved there, for example Sort by, Search type when selecting multiple items and Change sub-categorization scheme. The ones that are not related to the Layout could be moved to the Preferences->Look & feel->Tag browser and the Alter Tag browser button could be removed from the Tag browser.

There could be different sub-menus in the Layout drop down menu for the different part of the main window as well, the Toolbar, the Search bar and the Book details.