Beta testers for calibre 3.0 needed

[JimmXinu]

Originally Posted by kovidgoyal

@JimmXinu: This should take care of it: https://github.com/kovidgoyal/calibr...5330234ef32750

Unrelated FYI: At least one plugin, Find Duplicates, is negatively affected by the clear search button moving:

  File "calibre_plugins.find_duplicates.action", line 56, in initialization_complete
AttributeError: 'Main' object has no attribute 'clear_button'

    def initialization_complete(self):
        # Delay instantiating our finder as we require access to the library view
        self.duplicate_finder = DuplicateFinder(self.gui)
        self.update_actions_enabled()
        self.gui.clear_button.clicked.connect(self.user_has_cleared_search)
        self.gui.search_restriction.currentIndexChanged[int].connect(self.user_has_changed_restriction)

[PandathePanda]

Originally Posted by JimmXinu

Unrelated FYI: At least one plugin, Find Duplicates, is negatively affected by the clear search button moving:

Spoiler:

  File "calibre_plugins.find_duplicates.action", line 56, in initialization_complete
AttributeError: 'Main' object has no attribute 'clear_button'

    def initialization_complete(self):
        # Delay instantiating our finder as we require access to the library view
        self.duplicate_finder = DuplicateFinder(self.gui)
        self.update_actions_enabled()
        self.gui.clear_button.clicked.connect(self.user_has_cleared_search)
        self.gui.search_restriction.currentIndexChanged[int].connect(self.user_has_changed_restriction)

The fix is here:
https://www.mobileread.com/forums/sh...&postcount=592

[Stevex]

Nothing to do with the beta but may i mention: calibre editor remembers last search type normal or regex, and i wish it wouldnt, because i'm always doing regex searches by mistake and wondering what went wrong! Surely on a newstart should always default to normal.

[jony08]

It was only suggestions so it is fine if you don't agree on them of course.

For an experienced user, sure. For a new user, how is she to know what the checkbox means?

The button is called Layout so I don't think it is hard to understand for a new user but maybe written is easier to understand.

You can sort by clicking column headers, so what's the point of duplicating this functionality?

Sorting is a basic function that probably most users want to use and it is not possible to sort the Cover view by clicking column headers. You can add Sort by to the right click menu but then you have to be an experienced user to know that.

[JSWolf]

Originally Posted by PandathePanda

The fix is here:
https://www.mobileread.com/forums/sh...&postcount=592

Is the fix for the Find Duplicates plugin compatible with Calibre 2.85.1?

[Terisa de morgan]

Originally Posted by Stevex

Nothing to do with the beta but may i mention: calibre editor remembers last search type normal or regex, and i wish it wouldnt, because i'm always doing regex searches by mistake and wondering what went wrong! Surely on a newstart should always default to normal.

No way, I never use normal search, why do I have to change it every time?

[PandathePanda]

Originally Posted by JSWolf

Is the fix for the Find Duplicates plugin compatible with Calibre 2.85.1?

answered in the plugin thread, and yes it seems so

[BetterRed]

Originally Posted by kovidgoyal

@BR: I like option 4: https://github.com/kovidgoyal/calibr...d3b94ad77ecb89

Thanks : I imagined that would be the one you'd like least of all :lol:

Added: Could you give it a keyboard shortcut (I suggest Shift+Alt+L), you may want to relocate the shortcuts for Show/Hide Tag Browser, Book Details etc into a new Layout keyboard shortcut group.

BR

[BetterRed]

Originally Posted by JimmXinu

It's not new to the beta, but the search bar changes reminded of a minor UI issue that bugs me:

After clicking in the search box, I hit the down arrow key on the keyboard and instead of the first past search, I get the second past search. After that, I can get the first search by hitting up arrow.

I cannot get the first search by hitting up arrow right after focusing the search box.

As I said, minor. But an oddity that feels wrong.

I access the search via the keyboard (Ctrl+F or '/'), and I can hit up arrow to get at first item. Presumably I won't need to with version 3.00.

Originally Posted by kovidgoyal

@JimmXinu: This should take care of it: https://github.com/kovidgoyal/calibr...5330234ef32750

Even more minor : I also noticed that if search history only contains one item then the only way to get at it is via the drop down arrow.

My biggest issue with the search bar is that the search history is global rather than per library. Maybe the following could be considered for a future release (i.e. after Version 3.0)

A setting for Preferences->Searching>Search History Storage with a value of Global or Per Library. Default would be Global (i.e as is), a change in value would probably have to clear existing history.

BTW - I never understood what "Get saved search text" did when it was a button, I still don't now its in a drop down menu - what 'text'?

BR

[BetterRed]

Comments in Purple

BR

Originally Posted by kovidgoyal

I think it is fine where it is. It does not cover the entire width of the Tag browser and your proposed alternateives all have costs that IMO are not worth it.

If the 'clutter' at the bottom of the Tag Browser were moved to the top of the tag browser then this should be less of an issue

I dont think this is a good idea, that text changes depending on lots of things, for instance connecting a device.

The linking idea is a good one, most software has an About Box with a link to product home page, some have extra links to things like downloads, release notes, and support

You can sort by clicking column headers, so what's the point of duplicating this functionality?

Or you can install the View Manager plugin and access it via the Book List/Grid context menu.

[kovidgoyal]

@jony08: I am sympathetic to the need for a sort button in the cover grid view, so I'll look into addnig a button that only appears when you are in that view.

[eschwartz]

Originally Posted by BetterRed

BTW - I never understood what "Get saved search text" did when it was a button, I still don't now its in a drop down menu - what 'text'?

When I click it, it does absolutely nothing at all, but I thought it sounded like it should copy the actual search string that the saved search resolves to, either to the clipboard or the searchbar.

[JimmXinu]

Originally Posted by eschwartz

When I click it, it does absolutely nothing at all, but I thought it sounded like it should copy the actual search string that the saved search resolves to, either to the clipboard or the searchbar.

??? If you have a saved search up, it copies the saved search string to the search box. Which is how it worked before as a button and how I expected it to work. No saved search up, nothing to copy.

Arguably, menu item could be hidden or disabled if there isn't a saved search up, but other than that, looks fine to me.

[eschwartz]

My bad, it turns out it does work iff you use the same dropdown to perform the search -- manually typing anything, or generating the search via the tag browser breaks calibre's awareness or just doesn't work.

I have always used the tag browser to run saved searches, to the point I sort of forgot there was another way. I almost never touched that UI element at all TBH.

[JimmXinu]

I feel the same way about the tag browser. Didn't even know it could show saved searches.

Update: "Get saved search text" does work if you typed in a saved search like:

search:"Search Name"

"Get saved search text" does not work if the search in the bar is:

search:"=Search Name"

...which is what tag browser puts up there. The = is the difference.