Editing Dates in the Booklist

[BetterRed]

I set a Date custom column on some books to Today (e.g 2016-09-28) using Bulk Metadata Edit

And then I selected one of the books in the Book List, cursored to the Date column and hit F2 - the date in the edit box shows the previous date - i.e. 2016-09-27 If I then press Enter or Tab the date is changed

So, why haven't I noticed this before. I always use 'yyyy-MM-dd' format. I first noticed this when looking at someone else's data who uses the default 'dd MM YYYY' format. Being a LTR reader I immediately saw the change from '28 Sep 2016' to '27 Sep 2016'. Also when I edit Dates in the Book List I normally set them to Today or Clear them with '=' and '-' respectively. But I do occasionally tab through them. But I rarely (probably never before) set them in Bulk.

I have only observed it happen with dates set in Bulk MDE. But other things like metadata downloads, maybe some UI plugins (FFF ?), and Calibre Companion also set dates in calibre libraries. I don't do any of them, so I'm unable to test them.

In case its relevant I'm UTC+10.00.

Here is a zip with a video ==>> https://www.mediafire.com/?9dqceavm6r6a4zr (too big for here).

You'll see a green blob in the video - that's the mouse pointer, you'll see I don't use it except to move it off 'camera'. The video loops, and sorry for the slowness (hence size), its the first such thing I've made. Took me several downloads to find something I could drive - Icecream Screen Recorder - very simple.

I can PM the database if necessary

BR

[kovidgoyal]

I cannot reproduce this, steps I tried:

1) Select two books with some value a custom date column
2) Click edit metadata
3) Set the date column to today
4) Click OK
5) Press F2 to edit one the changed dates
6) The date shown in the edit box is today's date

Unfortunately I cannot see your video, since the domain it is hosted on is blackholed in my DNS server. Make sure you are not pressing the Ctrl key at the same time as F2, that will cause the date editor tobe initialized to a fixed value.

I also looked at the code and I cant see how it is possible for it to get the previous value, but, the code was awkward, so I have simplified it https://github.com/kovidgoyal/calibr...250007a957814e

[BetterRed]

Originally Posted by kovidgoyal

I cannot reproduce this, steps I tried:

1) Select two books with some value a custom date column
2) Click edit metadata
3) Set the date column to today
4) Click OK
5) Press F2 to edit one the changed dates
6) The date shown in the edit box is today's date

Unfortunately I cannot see your video, since the domain it is hosted on is blackholed in my DNS server. Make sure you are not pressing the Ctrl key at the same time as F2, that will cause the date editor tobe initialized to a fixed value.

I also looked at the code and I cant see how it is possible for it to get the previous value, but, the code was awkward, so I have simplified it https://github.com/kovidgoyal/calibr...250007a957814e

Kovid - I made another video - shorter this time, its attached in a zip.

No Ctrl keys, vanilla F2.

I can't reproduce it either right now. Only on dates I 'created' with BMDE before 10 a.m. this morning my time - when UTC time was yesterday. That's why I mentioned my UTC offset - I had an inkling it was related.

This has been driving me nuts for days.

BR

[davidfor]

Originally Posted by BetterRed

Kovid - I made another video - shorter this time, its attached in a zip.

No Ctrl keys, vanilla F2.

I can't reproduce it either right now. Only on dates I 'created' with BMDE before 10 a.m. this morning my time - when UTC time was yesterday. That's why I mentioned my UTC offset - I had an inkling it was related.

I think the timezone is the key. I know I have seen, it mainly just after midnight here. I'm much more likely to be doing something with calibre then than before 10:00am. I think the display of the date is in local time, but the edit is UTC.

[kovidgoyal]

I'm confused, are you saying that the dates shown in the editor are the values from before the bulk metadata edit or the value from the bulk metadata edit less one day?

[kovidgoyal]

If the issue is that the timezone of the date is different from the displayed date and the edited date, that should have been taken care of by the commit I linked to earlier. It now uses the exact same date object for both display and edit.

[davidfor]

Originally Posted by kovidgoyal

If the issue is that the timezone of the date is different from the displayed date and the edited date, that should have been taken care of by the commit I linked to earlier. It now uses the exact same date object for both display and edit.

OK, I'll test it tonight.

[BetterRed]

Originally Posted by kovidgoyal

I'm confused, are you saying that the dates shown in the editor are the values from before the bulk metadata edit or the value from the bulk metadata edit less one day?

The latter - I think

Say I do the bulk edit at 08:00 and set dates to today (2016-09-28), i.e. when it's 2016-09-27 22:00 UTC. It shows as '2016-09-28' in the Book List. But I press F2 on one of the Dates in the Book List the Edit Box shows '2016-09-27'.

However, say I do the bulk edit at 10:30 and set dates to today (2016-09-28), when it's 2016-09-28 00:30 UTC. It shows as '2016-09-28' in the Book List. When I press F2 on one of those Dates in the Book List the Edit Box shows '2016-09-28'.

It seems the problem occurs when the date is set in Bulk Edit at a time when my date is a day ahead of UTC date - but it only manifests when I edit one of the dates.

As I said its been driving me nuts for days.

BR

[BetterRed]

Originally Posted by davidfor

OK, I'll test it tonight.

Thanks David.

BR

[davidfor]

Yes, that looks to be the fix. Running the release version and it behaves as BR described. Run from source and no problems.

[BetterRed]

Originally Posted by kovidgoyal

If the issue is that the timezone of the date is different from the displayed date and the edited date, that should have been taken care of by the commit I linked to earlier. It now uses the exact same date object for both display and edit.

Originally Posted by davidfor

Yes, that looks to be the fix. Running the release version and it behaves as BR described. Run from source and no problems.

Thanks again to you both, looking forward to a new version and the restoration of sanity )(

BR

[davidfor]

Originally Posted by BetterRed

Thanks again to you both, looking forward to a new version and the restoration of sanity )(

Hmm, what am I missing? Installing new versions of calibre have never helped restore any sanity here.

[BetterRed]

Originally Posted by davidfor

Hmm, what am I missing? Installing new versions of calibre have never helped restore any sanity here.

At the time I was thinking - "If I was an American, who would I vote for?" Answer: Gary Johnson, his campaign slogan is "Let's Make America Sane Again"

BR

[davidfor]

Originally Posted by BetterRed

At the time I was thinking - "If I was an American, who would I vote for?" Answer: Gary Johnson, his campaign slogan is "Let's Make America Sane Again"

Dare I ask when the USA was last sane?