CSS styles modifications inside nickel

[tshering]

Originally Posted by pipcat

I updated extract script to create also all the streams in bad-eyes format. I attach them. Tshering, is it ok ? If so, I will add the same in patch process, generating newpart with customized values.

There is happened something. In each patch at the very end of the source text (oldpart) a new line is missing. For instance

Spoiler:

<patch>
name=4A002B (found 3, zlib)
enabled=true
action=replace_zlib
position=autodetect
oldpart=N3ButtonLabel[qApp_deviceIsAlyssum="true"] { font-size: 34px; }
...
oldpart=\n\nMetaDataElidedLabel[qApp_deviceIsAlyssum="true"],\nMetaDataLabel[qApp_deviceIsAlyssum="true"]\t\t{ font-size: 23px; }
...

should be

<patch>
name=4A002B (found 3, zlib)
enabled=true
action=replace_zlib
position=autodetect
oldpart=N3ButtonLabel[qApp_deviceIsAlyssum="true"] { font-size: 34px; }
...
oldpart=\n\nMetaDataElidedLabel[qApp_deviceIsAlyssum="true"],\nMetaDataLabel[qApp_deviceIsAlyssum="true"]\t\t{ font-size: 23px; }\n
...

or rather to your style

<patch>
name=4A002B (found 3, zlib)
enabled=true
action=replace_zlib
position=autodetect
oldpart=N3ButtonLabel[qApp_deviceIsAlyssum="true"] { font-size: 34px; }
...
oldpart=\n\nMetaDataElidedLabel[qApp_deviceIsAlyssum="true"],\nMetaDataLabel[qApp_deviceIsAlyssum="true"]\t\t{ font-size: 23px; }
oldpart=\n
...

Originally Posted by pipcat

Two questions about your patchit.exe :
Is it ok if newpart is shorter than oldpart ? (if you change four byte size value when non-compressed values, it should be ok).

If newpart (= the concatenated string of all newparts) is shorter then oldpart (= the concatenated string of all newparts), the difference will be filled up with zero bytes.

Originally Posted by pipcat

If there are 5 oldpart in a patch, is it ok if only 3 newpart ? (or we need 5 newpart lines, last two emptys ?)

This is ok.

[pipcat]

Originally Posted by tshering

There is happened something. In each patch at the very end of the source text (oldpart) a new line is missing. For instance

Mmm, I think you get an old .txt, from nickel-badeyes.txt.zip ;-)
With script v04, \n are at the end of strings, like in your patches. My last example with spoilers is like that. With your info about patchit.exe, it should work.

[tshering]

Originally Posted by pipcat

Updated patch-nickel-css scripts, with an option to generate bad-eyes format. Instead of executing python patch.py we can run python patch_badeyes.py and get a .txt with our customizations for bad-eyes pack.

Tshering, these are two examples, zlib and not, with myglohd.css modifications. newpart are some lines shorter than oldpart. Is that ok for patchit.exe ?

Spoiler:

<patch>
name=4A192E (found 16, nozlib)
enabled=true
action=replace_string
position=autodetect
oldpart=#InlineDictionaryView {\n\tmin-width: 500px;\n\tmax-width: 500px;\n\tmin-height: 220px;\n\tmax-height: 220px;\n}\n
oldpart=#InlineDictionaryView[qApp_deviceIsPhoenix="true"] {\n\tmin-width: 650px;\n\tmax-width: 650px;\n\tmin-height: 280px;\n\tmax-height: 280px;\n}\n
oldpart=#InlineDictionaryView[qApp_deviceIsDragon="true"] {\n\tmin-width: 980px;\n\tmax-width: 980px;\n\tmin-height: 350px;\n\tmax-height: 350px;\n}\n
newpart=/* [MOD]: Increased dictionary view */\n#InlineDictionaryView {\n\tmin-width: 980px;\n\tmax-width: 980px;\n\tmin-height: 400px;\n\tmax-height: 400px;\n}\n
combineparts
</patch>

Spoiler:

<patch>
name=4A3061 (found 28, zlib)
enabled=true
action=replace_zlib
position=autodetect
oldpart=#RecentBookTile[qApp_deviceIsTrilogy="true"] {\n qproperty-percentFontSize: 20;\n qproperty-progressFontSize: 20;\n qproperty-topMargin: 15;\n qproperty-coverBorder: 4;\n}\n
oldpart=#RecentBookTile[qApp_deviceIsPhoenix="true"] {\n qproperty-percentFontSize: 28;\n qproperty-progressFontSize: 22;\n qproperty-topMargin: 15;\n qproperty-coverBorder: 4;\n}\n
oldpart=#RecentBookTile[qApp_deviceIsDragon="true"] {\n qproperty-percentFontSize: 36;\n qproperty-progressFontSize: 26;\n qproperty-topMargin: 20;\n qproperty-coverBorder: 6;\n}\n
oldpart=#RecentBookTile[qApp_deviceIsAlyssum="true"] {\n qproperty-percentFontSize: 39;\n qproperty-progressFontSize: 30;\n qproperty-topMargin: 20;\n qproperty-coverBorder: 6;\n}\n
oldpart=#recentBookTileInfo {\n background-color: transparent;\n}\n
oldpart=#recentBookTileInfo[qApp_deviceIsTrilogy="true"] {\n qproperty-topMargin: 15;\n qproperty-bottomMargin: 15;\n}\n
oldpart=#recentBookTileInfo[qApp_deviceIsPhoenix="true"] {\n qproperty-topMargin: 15;\n qproperty-bottomMargin: 15;\n}\n
oldpart=#recentBookTileInfo[qApp_deviceIsDragon="true"] {\n qproperty-topMargin: 10;\n qproperty-bottomMargin: 15;\n}\n
oldpart=#annotation {\n min-height: 75px;\n max-height: 75px;\n}\n
oldpart=#annotation[qApp_deviceIsTrilogy="true"] {\n min-height: 52px;\n max-height: 52px;\n}\n
oldpart=QLabel {\n background-color: transparent;\n}\n
oldpart=QLabel[qApp_deviceIsTrilogy="true"] {\n font-size: 18px;\n}\n
newpart=/* [MOD]: Removed cover border in most recent book thumbnail */\n#RecentBookTile {\n qproperty-percentFontSize: 39;\n qproperty-progressFontSize: 30;\n qproperty-topMargin: 20;\n qproperty-coverBorder: 0;\n}\n\n
newpart=#recentBookTileInfo {\n background-color: transparent;\n qproperty-topMargin: 10;\n qproperty-bottomMargin: 15;\n}\n\n
newpart=#annotation {\n min-height: 75px;\n max-height: 75px;\n}\n\n
newpart=QLabel {\n background-color: transparent;\n}\n
combineparts
</patch>

The shorter lines are ok. The first patch (no zlip) does work, the second has some problems; there is for instance one space missing in the last oldpart. Maybe you did some editing when posting it here. Or maybe double spaces and such things get lost if you post it outside from code tags.

[tshering]

Originally Posted by pipcat

Mmm, I think you get an old .txt, from nickel-badeyes.txt.zip ;-)
With script v04, \n are at the end of strings, like in your patches. My last example with spoilers is like that. With your info about patchit.exe, it should work.

You are right, I took the text files from your uploaded archive. I have not installed python on my pc.

[pipcat]

Originally Posted by tshering

I have not installed python on my pc.

Oh, that's a pity, you would like this script ;-) Do you have calibre to try jackie_w trick ?

I attach some samples from nickel 3.19.5761:
- nickel-extracted.css : all css streams found, in .css format.
- nickel-extracted-badeyes.txt : same, with bad-eyes format.
- nickel-modified-myglohd.css : sample hand-edited .css with my custom modifications for some streams.
- nickel-modified-badeyes.txt : my modified css saved as bad-eyes format.

I cut/paste spoiler, but maybe it's because it was not in a code tag. The attached .txt should not have spaces problem.

[tshering]

Originally Posted by pipcat

Oh, that's a pity, you would like this script ;-) Do you have calibre to try jackie_w trick ?

Maybe it sounds strange, but I do not have calibre either.

Originally Posted by pipcat

I attach some samples from nickel 3.19.5761:
- nickel-extracted.css : all css streams found, in .css format.
- nickel-extracted-badeyes.txt : same, with bad-eyes format.
- nickel-modified-myglohd.css : sample hand-edited .css with my custom modifications for some streams.
- nickel-modified-badeyes.txt : my modified css saved as bad-eyes format.

I cut/paste spoiler, but maybe it's because it was not in a code tag. The attached .txt should not have spaces problem.

Thank you for the files. I checked nickel-extracted-badeyes.txt, nickel-modified-badeyes.txt. Very nicely done. Only one problem, in nickel-extracted-badeyes.txt, name=4A2895. Instead of

oldpart=ul li:before {\n  content: "\2219";\n}\n

patchit.exe needs

oldpart=ul li:before {\n  content: "\\2219";\n}\n

[pipcat]

Ok, thx for report. I modified script v04 to string_escape any \, not just \n and \t as before. Finally it should work ;-DD

[tshering]

Originally Posted by pipcat

Ok, thx for report. I modified script v04 to string_escape any \, not just \n and \t as before. Finally it should work ;-DD

It does work!

[mietek81]

Do you guys think that in this CSS there might be code for the homepage layout? There was once a patch called "Compact homepage layout". But from firmware 3.19 it is not available and I would be interested in having it back..