[GUI Plugin] FanFicFare

[JimmXinu]

Originally Posted by edeniz

Very strange. Because, no, I'm not changing dates in replace_metadata. Whyever (or even how?) would someone do that? And I'm not even a member of spacebattles, so I don't have user/pass to add to personal.ini. I mean it, there is nothing in the truncuated parts but replace_metadata for mostly ao3, tth, and ffnet. Even stranger: I too have tried to download with the very same truncuated ini, and the result was same as the epub I previously attached.

The only other thing in calibre I can think for you to try is creating a new, empty test library, clearing the personal.ini entirely and trying there.

You could confirm that HTML for (Chapter 13A) the last threadmark for that story matches what I see:

Spoiler:

      <li class="primaryContent memberListItem threadmarkItem " data-item-id="48133">
        
        <a href="threads/the-commission-rwby-au.341476/page-12#post-21206485"
           class="PreviewTooltip"
           data-previewUrl="posts/21206485/threadmarkpreview">Chapter 13A</a>

        <div class="extra">
          <span class="DateTime" title="Mar 6, 2016 at 9:58 PM">Mar 6, 2016</span>
        </div>
      </li>

[edeniz]

Ok, I'll try and see what happens. Meanwhile, here is the debug log attached.

[edeniz]

I did as you suggested and created an empty test library, then deleted the whole personal.ini and downloaded this link: https://forums.spacebattles.com/threads/341476/[1-2] only with default.ini. Attached is the resulting epub and its debug log.

By the way, this is what I see as html for chapter 13A:

Spoiler:

 
      <li class="primaryContent memberListItem threadmarkItem " data-item-id="48133">
        
        <a title="" href="threads/the-commission-rwby-au.341476/page-12#post-21206485" class="PreviewTooltip" data-previewurl="posts/21206485/threadmarkpreview">Chapter 13A</a>

        <div class="extra">
          <span class="DateTime" title="Mar 6, 2016 at 10:58 PM">Mar 6, 2016</span>
        </div>
      </li>

So yeah, nothing on that front.

[JimmXinu]

Originally Posted by edeniz

Ok, I'll try and see what happens. Meanwhile, here is the debug log attached.

Ah, now we're getting somewhere! Your computer isn't interpreting the date for some reason:

FFF: DEBUG: 2016-04-23 00:25:24,237: calibre_plugins.fanficfare_plugin.fanficfare.adapters.base_xenforoforum_adapter(275): No date found in <div class="extra">
          <span class="DateTime" title="May 24, 2015 at 5:22 PM">May 24, 2015</span>
        </div>

Is your computer localized for some where that doesn't use AM and PM to denote... am and pm? I don't know another way to say that.

[edeniz]

Originally Posted by JimmXinu

Ah, now we're getting somewhere! Your computer isn't interpreting the date for some reason:

FFF: DEBUG: 2016-04-23 00:25:24,237: calibre_plugins.fanficfare_plugin.fanficfare.adapters.base_xenforoforum_adapter(275): No date found in <div class="extra">
          <span class="DateTime" title="May 24, 2015 at 5:22 PM">May 24, 2015</span>
        </div>

Is your computer localized for some where that doesn't use AM and PM to denote... am and pm? I don't know another way to say that.

Yes, actually. I'm an Austrian, so my computer's set for Vienna, with the date format "Saturday, 23 April 2016", using the 24h format for time. We don't use am/pm.

It's boggling my mind that it should even play any sort of role for calibre/fanficfare, however.

[JimmXinu]

Originally Posted by edeniz

Yes, actually. I'm an Austrian, so my computer's set for Vienna, with the date format "Saturday, 23 April 2016", using the 24h format for time. We don't use am/pm.

It's boggling my mind that it should even play any sort of role for calibre/fanficfare, however.

Python's date parsing library depends on the locale for things like month name and such. Month names are already addressed, so I'm guessing about am/pm.

Attached is a test version that should log some additional info that hopefully will tell me what needs to be fixed. Please try it and send debug log it generates, thanks. (This version isn't useful for anyone but edeniz.)

[edeniz]

Originally Posted by JimmXinu

Python's date parsing library depends on the locale for things like month name and such. Month names are already addressed, so I'm guessing about am/pm.

Attached is a test version that should log some additional info that hopefully will tell me what needs to be fixed. Please try it and send debug log it generates, thanks. (This version isn't useful for anyone but edeniz.)

Debug log attached.

[JimmXinu]

ValueError: unconverted data remains: PM

Yep, it's the am/pm. I'll have a fix for later today or tomorrow.

[edeniz]

Originally Posted by JimmXinu

ValueError: unconverted data remains: PM

Yep, it's the am/pm. I'll have a fix for later today or tomorrow.

Yay!

But take your time. Never a need to rush on my account.

[agumon1123]

When I download from Quotev I get an error saying: list index out of range

Example Urls:
http://www.quotev.com/story/7376297
http://www.quotev.com/story/7491427
http://www.quotev.com/story/7308679
http://www.quotev.com/story/5698391
http://www.quotev.com/story/6719212

I also included the debug log.

[JimmXinu]

New test version posted (direct link)

2016-04-22

- Fix for %p (am/pm) date parsing on non-en_US locales. - AKA Fix for edeniz's date issues with SB.

- Fix for Yet Another Site Change on quotevcom.

FYI, I'm still researching the issues on OS X. I'm now getting it to crash calibre completely with a SEGV sorta-semi-replicatibly. So... Yay?

[thatblondelady]

Originally Posted by JimmXinu

-snip-

FYI, I'm still researching the issues on OS X. I'm now getting it to crash calibre completely with a SEGV sorta-semi-replicatibly. So... Yay?

Let me know if I can do anything to help. I've just switched to updating via windows, but any testing or anything you need, I'll do what I can.

[edeniz]

Originally Posted by JimmXinu

New test version posted (direct link)

2016-04-22

- Fix for %p (am/pm) date parsing on non-en_US locales. - AKA Fix for edeniz's date issues with SB.

- Fix for Yet Another Site Change on quotevcom.

FYI, I'm still researching the issues on OS X. I'm now getting it to crash calibre completely with a SEGV sorta-semi-replicatibly. So... Yay?

Works perfectly fine now. It always amazes me the way you're willing to take on the extra time to fix minor things like this when you could have easily brushed it off or put it off for a later date. And I certainly appreciate it very much.

[JimmXinu]

Okay, I think I've figured out the Mac OS X issues. At least, I've corrected the one I've been able to duplicate. The way I implemented progress bar dialogs was causing intermittent problems and whole-program calibre crashes, but only on OS X.

I'm especially interested in hearing if anyone still gets the issue where the plugin stops while but doesn't crash.

New test version posted (direct link)

2016-04-24

- Fix for Mac OS X crashes - changes to progress bar dialogs implementation.

- Update translations.

[thatblondelady]

Downloading now. I'll report the news shortly.

Edit 1: I am able to download stories again, just added something new.

Edit 2: Creating / updating of anthologies is still broken. Download happens, it gives the popup asking if I'd like to update the anthology and the job just stops there.

Edit 3: updating all 35 of my stories freezes on the 14th story (it was freezing at the 10th before). Goes through just fine in debug mode.

I think that covers everything. If there's anything else I can test please let me know.