[GUI Plugin] Goodreads Sync

[scorpion2782]

Originally Posted by davidfor

You put in a review? It looks like this is limited to 420 characters. I'll have to add a check to prevent the error.

No, i try to update my reading progress

[davidfor]

Originally Posted by scorpion2782

No, i try to update my reading progress

Yes, that's what I thought. The problem is the "Review" column. Whatever is in this is sent as a comment added to the status. You can edit this to add a comment, but it also gets whatever is in the column configured as the "Review text column". The problem is that Goodreads has a 420 character limit on this. If you type more than 420 characters in the field or in the review column, you will see this error.

The fix is firstly to not use the review column here. That's the wrong this and I'm not sure why I did it in the first place. The second part is to limit the entered text to 420 characters.

[jahnootoko]

Hello, I can't add books to my "to-read" goodreads list.
I tried deauthorizing and reauthorizing the plugin but it does not work, this is what I get everytime:

---------------------------

calibre, version 2.45.0
ERROR: Unhandled exception: <b>BadStatusLine</b>:HTTP/1.1 401Unauthorized


calibre 2.45 isfrozen: True is64bit: True
Darwin-15.0.0-x86_64-i386-64bit Darwin ('64bit', '')
('Darwin', '15.0.0', 'Darwin Kernel Version 15.0.0: Sat Sep 19 15:53:46 PDT 2015; root:xnu-3247.10.11~1/RELEASE_X86_64')
Python 2.7.9
OSX: ('10.11.1', ('', '', ''), 'x86_64')
Successfully initialized third party plugins: Count Pages && FictionDB && Favourites Menu && Reading List && Copy Cover To Device && APNX Generator && BIBLIOETECA && Goodreads && Barnes & Noble && Generate Cover && Find Duplicates && Goodreads Sync && Fantastic Fiction
Traceback (most recent call last):
File "calibre_plugins.goodreads_sync.dialogs", line 1553, in action_button_clicked
File "calibre_plugins.goodreads_sync.core", line 258, in add_remove_book_to_shelf
File "calibre_plugins.goodreads_sync.core", line 117, in _oauth_request_post
File "calibre_plugins.goodreads_sync.oauth2.__init_ _", line 682, in request
File "calibre_plugins.goodreads_sync.httplib2.__init__" , line 1445, in request
File "calibre_plugins.goodreads_sync.httplib2.__init__" , line 1197, in _request
File "calibre_plugins.goodreads_sync.httplib2.__init__" , line 1167, in _conn_request
File "lib/python2.7/httplib.py", line 1073, in getresponse
File "lib/python2.7/httplib.py", line 415, in begin
File "lib/python2.7/httplib.py", line 405, in _read_status
BadStatusLine: HTTP/1.1 401
----------------------------------

I am not a programmer so these don't make sense to me, but do you guys have any idea how can I fix this?

Thanks in advance!

[davidfor]

jahnootoko: That error suggests the plugin hasn't been authorised properly. But, none of the lines reported match with the current code I have. So, it looks like you are running an old version. Please update to the latest and try again.

[davidfor]

Attached is a beta that fixes the problem reported by scorpion2782.

The problem is that the progress update can include a comment. This was using the column set for review text. The maximum length allowed is 420 characters. If set to the comments column, this would probably be exceeded.

The beta has two changes:
- Stop using the review column for the progress comments.
- Set a maximum of 420 characters for the text when entered.

It all seems to work here. If anyone tests it and sees any problems, or that it work, please report it. If everything is OK, I'll arrange for a release later in the week.

[jahnootoko]

Originally Posted by davidfor

Attached is a beta that fixes the problem reported by scorpion2782.

The problem is that the progress update can include a comment. This was using the column set for review text. The maximum length allowed is 420 characters. If set to the comments column, this would probably be exceeded.

The beta has two changes:
- Stop using the review column for the progress comments.
- Set a maximum of 420 characters for the text when entered.

It all seems to work here. If anyone tests it and sees any problems, or that it work, please report it. If everything is OK, I'll arrange for a release later in the week.

Hello Davidfor, thanks for the beta. I installed it and still get the same error message, but I went to goodreads and it actually synced to my shelves... so I guess it is working though not totally smoothly. I am attaching the log just in case it is useful for you. Thanks again for the help!

---------------------
calibre 2.45 isfrozen: True is64bit: True
Darwin-15.0.0-x86_64-i386-64bit Darwin ('64bit', '')
('Darwin', '15.0.0', 'Darwin Kernel Version 15.0.0: Sat Sep 19 15:53:46 PDT 2015; root:xnu-3247.10.11~1/RELEASE_X86_64')
Python 2.7.9
OSX: ('10.11.1', ('', '', ''), 'x86_64')
Successfully initialized third party plugins: Fantastic Fiction && Goodreads Sync && Barnes & Noble && Find Duplicates && APNX Generator && Copy Cover To Device && Generate Cover && Favourites Menu && Goodreads && Count Pages && BIBLIOETECA && Reading List && FictionDB
Traceback (most recent call last):
File "calibre_plugins.goodreads_sync.dialogs", line 1540, in action_button_clicked
File "calibre_plugins.goodreads_sync.core", line 277, in add_remove_book_to_shelf
File "calibre_plugins.goodreads_sync.core", line 135, in _oauth_request_post
File "calibre_plugins.goodreads_sync.oauth2.__init_ _", line 684, in request
File "calibre_plugins.goodreads_sync.httplib2.__init__" , line 1453, in request
File "calibre_plugins.goodreads_sync.httplib2.__init__" , line 1205, in _request
File "calibre_plugins.goodreads_sync.httplib2.__init__" , line 1175, in _conn_request
File "lib/python2.7/httplib.py", line 1073, in getresponse
File "lib/python2.7/httplib.py", line 415, in begin
File "lib/python2.7/httplib.py", line 405, in _read_status
BadStatusLine: HTTP/1.1 401
---------------

[davidfor]

This is while adding a book to a shelf? The changes the beta will not have affected this, but it will mean I can track what the error reports against the code. Unfortunately, it doesn't tell me much more than before.

Can you run calibre in debug mode and post the log? Right click on the preferences button and select "Restart in debug mode". Then do whatever it is that causes the problem and close calibre. The debug log will be displayed. Post the complete log. Hopefully it will tell me something about what is happening.

[jahnootoko]

Originally Posted by davidfor

This is while adding a book to a shelf? The changes the beta will not have affected this, but it will mean I can track what the error reports against the code. Unfortunately, it doesn't tell me much more than before.

Can you run calibre in debug mode and post the log? Right click on the preferences button and select "Restart in debug mode". Then do whatever it is that causes the problem and close calibre. The debug log will be displayed. Post the complete log. Hopefully it will tell me something about what is happening.

Here is the log after debug mode:

------------
Traceback (most recent call last):
File "site-packages/calibre/gui2/ui.py", line 152, in __init__
File "site-packages/calibre/gui2/ui.py", line 166, in init_iaction
File "site-packages/calibre/customize/__init__.py", line 582, in load_actual_plugin
File "lib/python2.7/importlib/__init__.py", line 37, in import_module
File "site-packages/calibre/customize/zipplugin.py", line 179, in load_module
File "calibre_plugins.apnx_generator.apnxaction", line 14, in <module>
ImportError: No module named PyQt4.Qt
calibre Debug log
calibre 2.45 isfrozen: True is64bit: True
Darwin-15.0.0-x86_64-i386-64bit Darwin ('64bit', '')
('Darwin', '15.0.0', 'Darwin Kernel Version 15.0.0: Sat Sep 19 15:53:46 PDT 2015; root:xnu-3247.10.11~1/RELEASE_X86_64')
Python 2.7.9
OSX: ('10.11.1', ('', '', ''), 'x86_64')
Successfully initialized third party plugins: Goodreads && Reading List && Copy Cover To Device && Count Pages && Generate Cover && Goodreads Sync && Barnes & Noble && FictionDB && Fantastic Fiction && BIBLIOETECA && Favourites Menu && APNX Generator && Find Duplicates
Starting up...
HttpHelper::__init__: proxy=None
Traceback (most recent call last):
File "site-packages/calibre/gui2/dialogs/plugin_updater.py", line 73, in read_available_plugins
File "site-packages/calibre/gui2/dialogs/plugin_updater.py", line 88, in get_installed_plugin_status
AttributeError: 'IDEVICE' object has no attribute 'plugin_path'
calibre 2.45 isfrozen: True is64bit: True
Darwin-15.0.0-x86_64-i386-64bit Darwin ('64bit', '')
('Darwin', '15.0.0', 'Darwin Kernel Version 15.0.0: Sat Sep 19 15:53:46 PDT 2015; root:xnu-3247.10.11~1/RELEASE_X86_64')
Python 2.7.9
OSX: ('10.11.1', ('', '', ''), 'x86_64')
Successfully initialized third party plugins: Goodreads && Reading List && Copy Cover To Device && Count Pages && Generate Cover && Goodreads Sync && Barnes & Noble && FictionDB && Fantastic Fiction && BIBLIOETECA && Favourites Menu && APNX Generator && Find Duplicates
Traceback (most recent call last):
File "calibre_plugins.goodreads_sync.dialogs", line 1540, in action_button_clicked
File "calibre_plugins.goodreads_sync.core", line 277, in add_remove_book_to_shelf
File "calibre_plugins.goodreads_sync.core", line 135, in _oauth_request_post
File "calibre_plugins.goodreads_sync.oauth2.__init_ _", line 684, in request
File "calibre_plugins.goodreads_sync.httplib2.__init__" , line 1453, in request
File "calibre_plugins.goodreads_sync.httplib2.__init__" , line 1205, in _request
File "calibre_plugins.goodreads_sync.httplib2.__init__" , line 1175, in _conn_request
File "lib/python2.7/httplib.py", line 1073, in getresponse
File "lib/python2.7/httplib.py", line 415, in begin
File "lib/python2.7/httplib.py", line 405, in _read_status
BadStatusLine: HTTP/1.1 401Unauthorized


======= Plugin Parse Error =======
{u'author': u'GRiker',
u'deprecated': True,
u'description': u'Communicate with iDevices',
u'donate': u'https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=UDN8NYNFR2X58',
u'file': u'198720-deprecated.zip',
u'history': True,
u'index_name': u'Apple iDevice interface',
u'last_modified': u'2013-02-02T23:11:56',
u'minimum_calibre_version': [0, 9, 9],
u'name': u'Apple iDevice interface',
u'original_url': u'https://www.mobileread.com/forums/attachment.php?attachmentid=100574&d=1359846716',
u'size': 1084,
u'supported_platforms': [u'osx', u'windows'],
u'thread_id': u'198720-deprecated',
u'thread_url': u'https://www.mobileread.com/forums/showthread.php?t=198720',
u'uninstall': None,
u'version': [0, 0, 6]}
Started up in 17.71 seconds with 2689 books
HttpHelper::_oauth_request_post: url=http://www.goodreads.com/shelf/add_to_shelf.xml
Client::request - uri=http://www.goodreads.com/shelf/add_to_shelf.xml, body=book_id=19247870&name=to-read
HTTPConnectionWithTimeout::connect: Not using proxy
HTTPConnectionWithTimeout::connect: (www.goodreads.com, 80)
send: u'POST /shelf/add_to_shelf.xml HTTP/1.1\r\nHost: www.goodreads.com\r\nContent-Length: 250\r\nuser-agent: Python-httplib2/0.7.2 (gzip)\r\ncontent-type: application/x-www-form-urlencoded\r\naccept-encoding: gzip\r\n\r\nbook_id=19247870&name=to-read&oauth_consumer_key=UxvtOM3ogQWjfgiCnMleA&oaut h_signature_method=HMAC-SHA1&oauth_signature=9f1SKfDMAYqQJrFuKKv8qAnzp7E%3 D&oauth_timestamp=1449463673&oauth_nonce=9853854&o auth_token=8mmU4bAZd8JI8vQ19fBZAg&oauth_version=1. 0'
reply: 'HTTP/1.1 201\x00Created\r\n'
HTTPConnectionWithTimeout::connect: Not using proxy
HTTPConnectionWithTimeout::connect: (www.goodreads.com, 80)
send: u'POST /shelf/add_to_shelf.xml HTTP/1.1\r\nHost: www.goodreads.com\r\nContent-Length: 250\r\nuser-agent: Python-httplib2/0.7.2 (gzip)\r\ncontent-type: application/x-www-form-urlencoded\r\naccept-encoding: gzip\r\n\r\nbook_id=19247870&name=to-read&oauth_consumer_key=UxvtOM3ogQWjfgiCnMleA&oaut h_signature_method=HMAC-SHA1&oauth_signature=9f1SKfDMAYqQJrFuKKv8qAnzp7E%3 D&oauth_timestamp=1449463673&oauth_nonce=9853854&o auth_token=8mmU4bAZd8JI8vQ19fBZAg&oauth_version=1. 0'
reply: 'HTTP/1.1 401\x00Unauthorized\r\n'
------------

[Marx]

Hello, how to use this plugin together with Calibre Companion? CC use boolean custom column, while this plugin uses tags. So it's not possible after marking book as read to automatically move it to proper shelf.

[davidfor]

Originally Posted by Marx

Hello, how to use this plugin together with Calibre Companion? CC use boolean custom column, while this plugin uses tags. So it's not possible after marking book as read to automatically move it to proper shelf.

You can't do it automatically. What you can do is do a search for all books marked as read. Select them and use the add to shelf function. Then select the "read" shelve press OK. Once you've done this once, you can sort the read books by the modified date and only select the ones that have changed since the last time you did this.

[Firesong]

You can also set the actions as part of add to shelf to set a tag.
I have five unique shelves, and tags associated with all of them. The actions for adding to or syncing from each shelf add the tag which matches the shelf, and deletes all the others.
Therefore you'd have a tag against all the books on the read shelf which you could use to filter the results for read based on Calibre Companion, and as you added them to the shelf, the tag would be set. I can go into more detail if this interests you.

[Rellwood]

How do I get the bookshelves that are in Goodreads to sync, or add to a column set up "comma separated text, like tags, shown in tag browser" and not be the tags column?'



Nevermind I figured out how, but is there something wrong with the sync? I keep getting the not authorized error 401...

[davidfor]

Originally Posted by Rellwood

Nevermind I figured out how, but is there something wrong with the sync? I keep getting the not authorized error 401...

When do you get the error? And can you post the full error?

[Rellwood]

I get the error whenever I try to sync from shelf. Any of the exclusive shelves. I haven't had a problem with this in the past. I know that when I go to add, there is a book limit, but not with the sync from shelf. I have had no problems downloading tags. I think it happened when I started to add commands to the sync from shelf. I wanted to add a "date added" with the date formatted, a yes/no, and a new tag. I went back and redid the set up and put it back with the tags only, and now it works. The following is from my "to read" shelf that I haven't set back to the original way it was set up.

calibre, version 2.46.0
ERROR: Goodreads Failure: The request contacting Goodreads has failed. Please try again.

URL: http://www.goodreads.com/review/list...1&per_page=200
Response Code: 401
not authorized

[davidfor]

Originally Posted by Rellwood

I get the error whenever I try to sync from shelf. Any of the exclusive shelves. I haven't had a problem with this in the past. I know that when I go to add, there is a book limit, but not with the sync from shelf. I have had no problems downloading tags. I think it happened when I started to add commands to the sync from shelf. I wanted to add a "date added" with the date formatted, a yes/no, and a new tag. I went back and redid the set up and put it back with the tags only, and now it works. The following is from my "to read" shelf that I haven't set back to the original way it was set up.

calibre, version 2.46.0
ERROR: Goodreads Failure: The request contacting Goodreads has failed. Please try again.

URL: http://www.goodreads.com/review/list...1&per_page=200
Response Code: 401
not authorized

The other options for syncing shelves shouldn't cause this. They are handled after the above request is made to Goodreads and work on the data returned.

When you made the changes to the configuration, did you refresh the shelp list? When you visit goodreads, does the to-read shelf display properly?