[Linux] FlightCrew Plugin don't works with 0.9.0

[mapreri]

Originally Posted by DiapDealer

Please note that there are cmake instuctions that can be used to specify the exact libpython and python include files you want sigil to link against. These are documented in the BuildingOnLinux document(s) in the docs directory.

Yeah, but personally I find the need to specify such location a bug. After all, we're using something really standard here.

Originally Posted by DiapDealer

I already modified the FindPythonLibs.cmake file to include the two main multi-arch <GNU arch triplet> locations. It wasn't finding ANY of the distro-installed libpythons prior to that. If we can beef up that cmake file to include even more architectures, I'd be happy to incorporate those changes into the original source--when you're ready to make a pull request.

I just let cmake do it's work.
https://anonscm.debian.org/cgit/coll...1c77efab8f1d50
I can only do assumptions on why NO_DEFAULT_PATH was used (=> avoiding linking to system python?).

PS. guess we're OT in this 3d, just redirect me somewhere else if you prefer.

[DiapDealer]

Originally Posted by mapreri

I can only do assumptions on why NO_DEFAULT_PATH was used (=> avoiding linking to system python?).

I've no idea myself, to tell you the truth. I inherited the FindPythonLibs.cmake file -- lock, stock and barrel. Not being particularly fluent in cmake-ese, I made it work for me--and never looked back. Kevin also had to modify it to work on OSX, I believe.

It was certainly not MY intention to avoid linking to system python. Quite the contrary, in fact. That's why I included the x86_64-linux-gnu and the /i386-linux-gnu paths in the first place.

I'll gladly remove the NO_DEFAULT_PATH if it will expand the search and work for more architectures. Those who might not want to link to the system python can still explicitly specify the python they want to utilize.

[DiapDealer]

The removal of NO_DEFAULT_PATH from the FindPythonLibs.cmake file has been committed to the Github master branch.

Thanks for the improvement.

[eschwartz]

@mapreri

Also check out the NEW testplugin, which attempts to make use of each part of sigil's functionality: https://www.mobileread.com/forums/sho...d.php?t=267539


You can run Sigil from the same chroot you built it in, and test out the functionality.

Using arch-chroot I had to mess around a bit before I could actually use a functional account, but other than that it worked perfectly and I was able to make sure all dependencies were accounted for.

[Camelot]

Thanks all and mapreri for the fix to 0.9.0+dfsg-2.

The FlightCrew plugin works now without internal errors.
Also the testplugin: «Success - All Tests of Plugin Operations Passed»

[DiapDealer]

That is excellent news!