[GUI Plugin] Overdrive Link

[buttersk]

Not sure if something happened with last update... or if something changed again.... I had not changed any of my settings since the last time I tried and it worked.

Now getting this in log:

Overdrive Link found: 1 error in searching. (click "View log" for details). 1 book/library link unchanged





Key: *=Discovered book, @=Available at, !=Recommendable at, $=Purchasable at, #=Audiobook

---------------- ERRORS WHILE SEARCHING ----------------

Signing in to Wilbor: : AttributeError (closeable_response instance has no attribute 'data')

-------------------- UNCHANGED LINKS ---------------------

Fahrenheit 451 by Ray Bradbury (No links)





Starting job: Search for books by 1 author
Overdrive Link 1.35.0, calibre 2.42.0
Search formats: Acoustik Audiobook, Adobe EPUB eBook, Adobe PDF eBook, Apple Audiobook, Blio eBook, BookReader, HTML eBook, Hoopla Audiobook, Hoopla Reader, Kindle Book, MP3 Audiobook, MediaDo Reader, Mobipocket eBook, OneClickdigital Audiobook, Online Reader, Open DjVu eBook, Open EPUB eBook, Open PDF eBook, OverDrive Listen, OverDrive MP3 Audiobook, OverDrive Read, OverDrive WMA Audiobook, Oyster Reader, Plain Text eBook, Protected DAISY eBook, Scribd Audiobook, Scribd Reader, WMA Audiobook
Signing in to Wilbor (branch 1704)
Browse: http://bridges.lib.overdrive.com/BAN...rceLoginFlag=0 None
Redirected login url https://bridges.libraryreserve.com/1...=Default%2ehtm
Browse: https://bridges.libraryreserve.com/1...=Default%2ehtm None
Signing in to Wilbor: : AttributeError (closeable_response instance has no attribute 'data')
Traceback (most recent call last):
File "calibre_plugins.overdrive_link.jobs", line 1187, in sign_in
File "calibre_plugins.overdrive_link.overdrive", line 375, in sign_in
File "site-packages\mechanize-0.2.5-py2.7.egg\mechanize\_response.py", line 99, in __getattr__
AttributeError: closeable_response instance has no attribute 'data'

=================================================
Finding library books by Ray Bradbury
Cannot perform search at Wilbor due to sign in failure
=================================================
=================================================
Unmatched book (unchanged): Fahrenheit 451 by Ray Bradbury
=================================================
Checking 0 unmatched library books, 1 author

[jhowell]

Originally Posted by buttersk

Not sure if something happened with last update... or if something changed again.... I had not changed any of my settings since the last time I tried and it worked.

The main problem is a failure to sign-in to the library web site. It looks like something is different at OverDrive for your library. I need to figure out what has changed, but I won't have time to look into this until next week. As a work-around I suggest that you change the plugin configuration to remove your card number and pin for this library so that the plugin no longer attempts to sign-in.

A secondary problem is a bug in the plugin, causing an error to occur when attempting to handle the sign-in failure: AttributeError (closeable_response instance has no attribute 'data') This bug will be fixed in the next plugin release.

[eschwartz]

I keep getting the following error with Axis360 libraries:

Checking xxxxxxxxxx obtainable at QUEENS-A: : Server response error (missing "div class=(^| )CopiesInfo($| )")

And discovering it's because the book doesn't really exist at the library.
Which is odd, because the plugin is what found the link in the first place???

[jhowell]

Originally Posted by eschwartz

...
And discovering it's because the book doesn't really exist at the library.
Which is odd, because the plugin is what found the link in the first place???

The part of the plugin that handles checking current availability doesn't deal well with books no longer being present at the library, as you found out. I will add a more informative error message in this case.

I am assuming that this is a case of a book being removed from the library's collection sometime between when a search linked it and when you did a check for its current availability. If the book still is being found by search, but not by the availability check then there is a bug and I will need more details from you in order to diagnose it.

The plugin has a configuration option, "Unlink books if no longer found by search", which will cause links for books that are no longer at the library to be removed. If this is not set then the plugin will retain links for books that have been removed from a library's collection. I suggest setting that option and doing a new search to clear out non-functional links.

[eschwartz]

Yup -- I checked the link manually and Axis360 shows an Error Ebook Not In Collection or whatever message to that effect. That's why I said "it's because the book doesn't really exist at the library".

As for unlinking automatically -- I guess I could do that.
How well does it handle searches which error out, or the inconsistency in returned Amazon results? (I believe you once said Amazon results are inconsistent, that is...)

P.S. A more informative error message sounds great. Thanks.

[jhowell]

Originally Posted by eschwartz

How well does it handle searches which error out, or the inconsistency in returned Amazon results? (I believe you once said Amazon results are inconsistent, that is...)

If the plugin detects an actual error when searching it will not remove links for books that were no longer found. It is assumed that any missed books were due to the error in that case. It is when things fail in ways that are not caught that links may be mistakenly removed. The most likely cause is a change to a website's page layout that is not handled by the plugin.

Amazon has become more consistent in its search results. I keep the "unlink" setting enabled and it hasn't been a problem for me.

I think the risk is slight. If you want to be cautious you can just use that setting from time to time in order to clean out old links.

[eschwartz]

Thanks for the clarification.
I think I'll risk it.


(I am about due anyway to hit up all my libraries for refreshed links and Discovered Books...)

[Terisa de morgan]

@jhowell, a question. I know that you told that you didn't want to remove the confirmation pop-up because it controlled the metadata update but, would it be possible to include an option for disabling the pop-up when no change has be done and no update is necessary?

[jhowell]

Originally Posted by Terisa de morgan

@jhowell, a question. I know that you told that you didn't want to remove the confirmation pop-up because it controlled the metadata update but, would it be possible to include an option for disabling the pop-up when no change has be done and no update is necessary?

I have heard of another plugin just applying database updates at job completion without a confirmation so I assume that it must work properly. I will add an option in the next plugin release to skip the completion confirmation and just apply any changes. You will need to review the job log if you want to see what was changed.

[Terisa de morgan]

Avoiding to look at logs is the reason of my last proposal , but it's fine for me too as I have a custom column which marks if a book has been found at any of my libraries. Thank you very much.

[jecilop]

UPDATE on this post: SOLVED - link issue fixed; Audible added.

Will you add Audible as a library search site such that a link is returned and added ?

I assumed the w4v.store would cover it, but I can see it is only for Whispersync availability with Kindle books. I would like this type of link returned for books available at Audible.

*****
I'm noticing that some of my link name designations are not showing in the book details. Specifically, the names I give for the Amazon / store (Kindle) and Amazon / wv4.store (Whispersync). I do not have the box checked to update the Amazon link. I would expect to see the name "Kindle" listed in the Ids in the book details. The same thing for a return for w4v which I named "Whispersync."

And to confirm, there is valid info for these returned. It is visible only in the edit metadata window's Ids: field. I clearly have info returned under odid for ak/store and then a return for ak/w4v.store.



I'd appreciate some input.

[jhowell]

Originally Posted by jecilop

Will you add Audible as a library search site such that a link is returned and added ?

I will take a look at Audible and add it as a book provider in the plugin, if it is not too difficult.

Originally Posted by jecilop

I'm noticing that some of my link name designations are not showing in the book details. Specifically, the names I give for the Amazon / store (Kindle) and Amazon / wv4.store (Whispersync). I do not have the box checked to update the Amazon link. I would expect to see the name "Kindle" listed in the Ids in the book details. The same thing for a return for w4v which I named "Whispersync."

I am unable to duplicate this problem. Some more information would be helpful to diagnose this.

When you select a book that has one of these links do you see it listed in the menu when you click the "Overdrive Link" plugin icon? There should be a line in the menu something like "Borrow book from Whispersync". Seeing this shows that the plugin is recognizing the odid identifier and the configuration of the name properly.

Also verify that the plugin configuration has the option "Disable links in book details panel" unchecked.

You can also try restarting calibre and see if this has any effect on the display of the Id in the book details panel. (Installing or removing other plugins without restarting calibre can cause the Overdrive Link Ids to go missing.)

[jecilop]

Originally Posted by jhowell

I will take a look at Audible and add it as a book provider in the plugin, if it is not too difficult.



I am unable to duplicate this problem. Some more information would be helpful to diagnose this.

When you select a book that has one of these links do you see it listed in the menu when you click the "Overdrive Link" plugin icon? There should be a line in the menu something like "Borrow book from Whispersync". Seeing this shows that the plugin is recognizing the odid identifier and the configuration of the name properly.

Also verify that the plugin configuration has the option "Disable links in book details panel" unchecked.

You can also try restarting calibre and see if this has any effect on the display of the Id in the book details panel. (Installing or removing other plugins without restarting calibre can cause the Overdrive Link Ids to go missing.)

Thank you for taking a look at the Audible addition.
I have tested what you mentioned many time and with many restarts including the PC just to extra sure and still do not get info returned visually despite data being in the identifier field.

I'm including some screenshots so you can be certain.

• One is the plugin configuration.
• Another shows the book details panel opened and the links that generate there.
• Another shows the same panel but the tags I created based on the returned info (specific tags and not the general odid which can cover more than one).
• Another is just for fun to share: the custom icons I see based on those tags.
• Lastly, here is the info in the actual metadata field: isbn:9780985088835, amazon:B009LM4E9G, odid:B009LM4E9G@ak/kuwn&B009LM4E9G@ak/prime&B009LM4E9G@ak/unlimited, odpid:B009LM4E9G@ak/store&B009LM4E9G@ak/w4v.store

Thank You.

Side note: for anyone interested....This is the template info I used to create a custom tags style column based on the identifier info so I can manage this info much better. It can be further managed to include other identifier info such as google and goodreads depending on what the user wants to do (just refer to content in the Ids field in the Edit Metadata screen for info to reference).
{identifiers:contains(ak/store,K,)},{identifiers:contains(ak/prime,KPLL,)},{identifiers:contains(ak/unlimited,KU,)},{identifiers:contains(ak/kuwn,KUWN,)},{identifiers:contains(ak/w4v,KWhisper,)}

[jhowell]

Originally Posted by jecilop

Lastly, here is the info in the actual metadata field: isbn:9780985088835, amazon:B009LM4E9G, odid:B009LM4E9G@ak/kuwn&B009LM4E9G@ak/prime&B009LM4E9G@ak/unlimited, odpid:B009LM4E9G@ak/store&B009LM4E9G@ak/w4v.store

Thank you for the detailed response!

I realize now that I was mistaken. Links for purchasable book (the odpid identifier) are not displayed in the book details panel by the plugin. I will add a configuration option in the next plugin release to allow that.

(I expect that release to be within a week.)

[jecilop]

Originally Posted by jhowell

Thank you for the detailed response!

I realize now that I was mistaken. Links for purchasable book (the odpid identifier) are not displayed in the book details panel by the plugin. I will add a configuration option in the next plugin release to allow that.

(I expect that release to be within a week.)

Ah!!! I didn't notice the commonality either.
Thanks!