CoolReader3 Fork

[mysiak]

I've tried the latest version with 4.4 FW and full screen refresh is comparably slower than the "original" CR3. Any idea what's the reason behind it please? Wrong settings (I did not change them during app replacement), FW incompatibility or maybe some bug?
Thanks

[brucelee]

Originally Posted by mysiak

I've tried the latest version with 4.4 FW and full screen refresh is comparably slower than the "original" CR3. Any idea what's the reason behind it please? Wrong settings (I did not change them during app replacement), FW incompatibility or maybe some bug?
Thanks

I don't see why would that happen. I don't feel like it's being slow.


Update:

0.0.6-16-9:
- Now in FW5 book cover is properly set as power of logo too (thanks to pal @ the-ebook.org)
- Added initial FW5 skin - useful for 758x1024 screens (got bigger buttons)
- When words are touched in dictionary list it automaticaly goes to the full description (instead of just selecting the line).
- Smaller binaries
- From now on I'll host the packages on Dropbox.
- Made different builds for FW4 and FW5 although I think it shouldn't be needed.

If you have FW4 please try the FW5 binary too. I'd like to know if it works with both firmwares.

[j0r13n]

Originally Posted by brucelee

If you have FW4 please try the FW5 binary too. I'd like to know if it works with both firmwares.

FW5 binary doesn't work on FW4.4...

The pbfw626fw5 skin is a F A N T A S T I C update!

Minor issue: looks like you forgot the TOC: it still uses a part of the old skin accompanied by an awful narrow touch zone.

[brucelee]

It's just an initial release. Further development will come.

Thanks for testing the FW5 binary.

Edit: New changes:

0.0.6-16-10:
- Removed status bar in skin pb626fw5
- Changed dictionary icons in skin pb626fw5

Check screenshots for the changes.


EDIT:
It seems like the TOC is actually opened through a system function which has nothing to do with the CR3 skins.

[j0r13n]

brucelee,

Every new build it looks more promising!

Keep up the good stuff!


It looks like the frontlight adaption doesn't work well with rotated display. When rotated 90 or 270 degrees, calling the frontlight ánd afterwards calling the menu will results in a garbled display. When rotated 180 degrees calling the frontlight will flip the display to rotate to 0 degrees; hereby the menu shows normal but the underlying tap zones are still 180 degrees rotated.

When using the normal hardware keys the frontlight will work as should, also with rotated display. Also, luckely you're system bar adaption do works well in this regard.

When peeking around (PB626 FW4.4), it looks like the hardware keys use the following arguments: @KA_flct and @KA_flgh, or to be precise...

@KA_flct=@KA_flgh_brightness
@KA_flgh=Frontlight On/Off
@KA_flgh_brightness=Frontlight brightness

Maybe you can use it to our benefit!

[mysiak]

Originally Posted by brucelee

I don't see why would that happen. I don't feel like it's being slow.

Tried the new version again and this time it seems faster. But maybe it's just my feeling as I don't know how to measure or capture the refresh. So probably only false alarm, sorry for that

Is there any chance that you could adapt dictionary search as in original Adobe or FB reader - long press on a word to show the matching record in dictionary? This is probably the only thing which I miss from otherwise useless Adobe reader.
Thanks!

[brucelee]

Originally Posted by j0r13n

...
It looks like the frontlight adaption doesn't work well with rotated display.
...

That's probably because the front light window is another application launched from system.
I'll see if I can do anything about it.

Originally Posted by mysiak

...
long press on a word to show the matching record in dictionary
...

I'll put that on the to do list.

[j0r13n]

Looks like there's an issue with the pb626fw5 skin.

When you call a menu setting and set a value on the last page, you afterwards can't set a value on an earlier page further than items available on the last page of this menu item.

Confusing? You won't be after the next episode of Soap

Suppose you have 3 pages of fonts and the last page contains 4 items; when you select on of the fonts on the last page you can't select another font on page 1 or 2 beyond the first four fonts at either page. When you exit Cool Reader solves the issue: afterwards you can select all fonts again...

[pkbo]

@brucelee, I think I've fixed the issue reported by j0r13n. Could you please merge and check if it does help?

[brucelee]

I made the change but I'll push the code later.

Edit: New version

0.0.6-16-11:
- Pro is compiled with PB_DB_STATE_SUPPORTED
- Pro is compiled with BACKGROUND_CACHE_FILE_CREATION
- Added font gamma steps: 2.5, 4.0
- Added screen update steps: 7 pages, 9 pages
- Applied pkb's patch to fix settings item selection
- Force black/white updates only, in settings for skin pb626fw5 (it's quite speedy now)

Edit: New version:

0.0.6-16-12:
- Added tap action: Open system panel (FW5 only - opens extended system panel)
- Added tap action: Lock device
- Added tap action: Tasks list
- Skin pb626fw5: Removed useless files from package
- Skin pb626fw5: Increased contrast in some images
- Proper setting of flags when compiling

[RUSsiya90]

1. please have the opportunity to work with text in koolredere in fbreadere. (Highlight, pencil, eraser, underline using touch input)

[brucelee]

Originally Posted by RUSsiya90

1. please have the opportunity to work with text in koolredere in fbreadere. (Highlight, pencil, eraser, underline using touch input)

I suppose you're talking about a notes feature.

That would be interesting to implement but I think it's a very time consuming task. I'll consider it. Hopefully it will be easier than I expect.

[RUSsiya90]

Originally Posted by brucelee

I suppose you're talking about a notes feature.

That would be interesting to implement but I think it's a very time consuming task. I'll consider it. Hopefully it will be easier than I expect.

Thank you very much for a long time waiting for this opportunity, please do hope that you will be able to realize (I do not speak English, but you understand me, thank you very much very happy for understanding)

[rkomar]

If you wanted to implement note-taking the same way that PocketBook does, then it probably wouldn't be too bad. They have functions for that within their SDK. The drawback is that those notes aren't really that portable to other devices or applications.

Being able to embed the annotations into the original document would be great, but that would be a gargantuan task. Each different kind of document would do annotation in its own way, if at all.

[j0r13n]

Thanks brucelee for the new build (and pkbo for the fix)!

If I just could code like you guys! The only slightest possible contribution which lies within my limited possibilities is to point you guys if there are IMHO areas of improvement. So please, don't see me as a moaner...

• Still my greatest gripe lies within the buffering of the tap-actions which often result in unintended actions.

• RUSsiya90 opted for a notes implementation but - although not the same - there's already a cite possibility in Cool Reader. Unfortunately it doesn't work correct. In picture 1 you can see it's some kind of scrambled; you can't use it as should and can't leave the cite dialog other than stopping Cool Reader.
  The v0.0.6-11 version of Cool Reader does work well in this respect (picture 2), but only in portrait display mode.

Some cosmetic suggestions:

• In 2 pages landscape mode it would be a nice addition to add a thin separator line between the to pages (pictur 3 vs picture 4)

• Just nitpicking: text in menu's is cut off at the extreme right side (picture 5). Maybe it's a heritage from the regular skin with it's big selecting stripes.

As alway: keep up the good stuff!