So I just have to ask... - Page 5

theducks · 07-25-2014, 11:18 PM

Quote:

Originally Posted by kovidgoyal

The plugin toolbar will be visible only if you have any installed plugins.

When you install a plugin it becomes available in a "Plugins" menu and if it is the first time it is installed (as opposed to being updated), it is also added to the plugins toolbar.

And note that after installing the plugin you have to restart the editor, if it was already open.

Kovid
I installed the PI the normal 'from file' way with the editor closed.
The steps I listed was what happened with both 203 and 1.46 (Windows)

Confirming
Before Plugin: No Plugins on the Menu

The problem is with getting the Icon on the User PI tool bar to show (the first time). I added a separator at the top of the User PI Menu list, to make it clear which toolbar the Icon was on. Once it shows, it stays.

davidfor · 07-25-2014, 11:23 PM

Quote:

Originally Posted by kovidgoyal

The plugin toolbar will be visible only if you have any installed plugins.

When you install a plugin it becomes available in a "Plugins" menu and if it is the first time it is installed (as opposed to being updated), it is also added to the plugins toolbar.

And note that after installing the plugin you have to restart the editor, if it was already open.

It took me a few moments to find the tool and the correct toolbar when I first added it. What I couldn't work out was how to put it on one of the more specific toolbars. I was thinking of putting this only on the CSS editor toolbar to run the sort on the open file. Is there a way to do this?

kovidgoyal · 07-25-2014, 11:30 PM

No plugins are book wide only. If you wish to run it only only the currently opened file, you can do so by simply restricting the files your plugin processes. Get the name of the file like this

from calibre.gui2.tweak_book import editor_name

name = editor_name(self.gui.current_editor)

And I suggest adding a submenu to the plugins menu entry that allows the user to toggle what mnode the plugin operates in.

icallaci · 07-26-2014, 12:12 AM

Quote:

Originally Posted by theducks

Sorts All CSS in book? (actually, i would prefer the current only, but User PI may be limited)

I also would prefer it to sort just the current stylesheet, but I'm not complaining, since it does what I need at the moment. I never expected such a quick response.

davidfor · 07-26-2014, 12:14 AM

Quote:

Originally Posted by theducks

Might not be working the way you thought (1.46 x64) if I understand the rules. Sorts All CSS in book? (actually, i would prefer the current only, but User PI may be limited)

2@ CSS: page_styles, styleesheet
I ran the PI, it showed changes made to Pages (not obvious, only @pages)
the other: stylesheet (the one that could use a sort, did not change. old styl calibre ASCII sorted styles)

Did I use incorrectly?

No, I don't think so. As I said, the plugin is dumb. It simple finds all the stylesheet files and sort them. And because of the way it does this, it does a beautify of the CSS at the same time. What that means is if a beautify has already been run a file and the rules are already sorted, there won't be a change. And for a file with only one rule in it, it will be changed as if a beautify was run.

I'll probably add some extra function. I was thinking of prompting with a list of stylesheets to sort, but I like the idea of restricting it to the current file as Kovid suggests. Plus handling the specificity and rules without a specifier.

theducks · 07-26-2014, 12:57 AM

David
I was reading in the Modify EPUB PI topic and something

Duplicate Selectors

and changing their ORDER

when sorting could have significant effects on the document.

Maybe ?

1) Display a pre-sort warning if dups are found and:
a) allow a Bailout
b) just refuse to proceed.

2) Use a 'bubble sort' so the order does not change. I know, Bubble Sorts are slow.

davidfor · 07-26-2014, 05:31 AM

Quote:

Originally Posted by kovidgoyal

No plugins are book wide only. If you wish to run it only only the currently opened file, you can do so by simply restricting the files your plugin processes. Get the name of the file like this

from calibre.gui2.tweak_book import editor_name

name = editor_name(self.gui.current_editor)

Thanks. Should the second line be:

Code:

name = editor_name(self.gui.central.current_editor)

Or did I miss something?

davidfor · 07-26-2014, 05:52 AM

Quote:

Originally Posted by theducks

David
I was reading in the Modify EPUB PI topic and something

Duplicate Selectors

and changing their ORDER

when sorting could have significant effects on the document.

I didn't think of that at all when I started. It was only after rereading one of the posts that I thought

Quote:

Maybe ?

1) Display a pre-sort warning if dups are found and:
a) allow a Bailout
b) just refuse to proceed.

2) Use a 'bubble sort' so the order does not change. I know, Bubble Sorts are slow.

I haven't thought about sort algorithms for a VERY long time. I'll have a think of these options.

In the meantime, I have added the single file sort that has been suggested. The toolbar button now has a menu option "Sort current file". When that is checked, pressing the button will sort the currently opened file if it is a stylesheet. If it is not checked, it will sort all of them as it does now.

kovidgoyal · 07-26-2014, 05:53 AM

Yeah, it should.

mrmikel · 07-26-2014, 06:43 AM

Will editor plug-ins be in a sticky in this forum, or with the other plug-ins?

ShellShock · 07-26-2014, 07:05 AM

Yes I think a sticky would be good, because I have only just found my way back here after several days--I was starting to think I had imagined reading about editor plug-ins!

DoctorOhh · 07-26-2014, 07:15 AM

Quote:

Originally Posted by ShellShock

Yes I think a sticky would be good, because I have only just found my way back here after several days--I was starting to think I had imagined reading about editor plug-ins!

There is already a Sticky for plug-ins: Index of plugins which is used for all calibre plug-ins. Any plug-in released by a developer will be listed here.

DiapDealer · 07-26-2014, 08:03 AM

Quote:

Originally Posted by kovidgoyal

FYI tomorrows calibre release has support for editor plugins.

http://manual.calibre-ebook.com/crea...t-book-plugins

Sweet mother of monkey milk; thank you for this!

theducks · 07-26-2014, 10:26 AM

Quote:

Originally Posted by davidfor

I didn't think of that at all when I started. It was only after rereading one of the posts that I thought

I haven't thought about sort algorithms for a VERY long time. I'll have a think of these options.

In the meantime, I have added the single file sort that has been suggested. The toolbar button now has a menu option "Sort current file". When that is checked, pressing the button will sort the currently opened file if it is a stylesheet. If it is not checked, it will sort all of them as it does now.

Is this from the latest SortCSS PI (on 1.203)?

Spoiler:

davidfor · 07-26-2014, 08:51 PM

Quote:

Originally Posted by theducks

Is this from the latest SortCSS PI (on 1.203)?

Spoiler:

It looks like it. I changed one of the names in the plugin. It looks like that name was used as part of the key in the preferences for what is on the toolbar. And calibre didn't like not being able to match the key to a plugin. Or at least I think that is what is happening.

To fix it, I think you need to edit the file "tweak_book_gui.json" that is in you calibre preferences directory. Look for the "global_plugins_toolbar" and remove that section and save the file.

07-25-2014, 11:30 PM	#63
kovidgoyal creator of calibre Posts: 45,604 Karma: 28548974 Join Date: Oct 2006 Location: Mumbai, India Device: Various	No plugins are book wide only. If you wish to run it only only the currently opened file, you can do so by simply restricting the files your plugin processes. Get the name of the file like this from calibre.gui2.tweak_book import editor_name name = editor_name(self.gui.current_editor) And I suggest adding a submenu to the plugins menu entry that allows the user to toggle what mnode the plugin operates in.

07-26-2014, 12:57 AM	#66
theducks Well trained by Cats Posts: 31,249 Karma: 61360164 Join Date: Aug 2009 Location: The Central Coast of California Device: Kobo Libra2,Kobo Aura2v1, K4NT(Fixed: New Bat.), Galaxy Tab A	David I was reading in the Modify EPUB PI topic and something Duplicate Selectors and changing their ORDER when sorting could have significant effects on the document. Maybe ? 1) Display a pre-sort warning if dups are found and: a) allow a Bailout b) just refuse to proceed. 2) Use a 'bubble sort' so the order does not change. I know, Bubble Sorts are slow.

07-26-2014, 05:53 AM	#69
kovidgoyal creator of calibre Posts: 45,604 Karma: 28548974 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Yeah, it should.

07-26-2014, 06:43 AM	#70
mrmikel Color me gone Posts: 2,089 Karma: 1445295 Join Date: Apr 2008 Location: Central Oregon Coast Device: PRS-300	Will editor plug-ins be in a sticky in this forum, or with the other plug-ins?

07-26-2014, 07:05 AM	#71
ShellShock Wizard Posts: 1,178 Karma: 2431850 Join Date: Sep 2008 Device: IPad Mini 2 Retina	Yes I think a sticky would be good, because I have only just found my way back here after several days--I was starting to think I had imagined reading about editor plug-ins!