Attn plugin developers: calibre moving to Qt 5

[kovidgoyal]

IIRC PyQt auto converts the arguments for some fucntion calls. In any case getting a QBrush from a QColor is just

QBrush(QColor(whatever)) or QBrush(Qt.somecolorname)

[JimmXinu]

Originally Posted by kovidgoyal

IIRC PyQt auto converts the arguments for some fucntion calls. In any case getting a QBrush from a QColor is just

QBrush(QColor(whatever)) or QBrush(Qt.somecolorname)

Good to know, thanks.

Another unrelated (and probably minor) issue:

I've just noticed that the original plugin zip files from kiwidude I've been working on are zip files, but with 0% compression. I see that in some other plugins, too; but not all.

Is/was there some reason for that?

[kovidgoyal]

Performance. Using zero compression means that the plugins files can be loaded faster as they dont need to be decompressed. If you use the recommended

calibre-customize -b .

to build your plugins it will create zip files with no compression.

[kovidgoyal]

I have uploaded new beta builds (1.201) these include all the changes from todays main calibre release as well as fixes for all issues reported in this thread.

http://download.calibre-ebook.com/betas/

[DNSB]

I've found an issue converting from .mobi to .epub. The conversion works with 1.44 but errors out with 1.201.1

Resolved conversion options
calibre version: 1.201.1
{'asciiize': False,
 'author_sort': None,
 'authors': None,
 'base_font_size': 0.0,
 'book_producer': None,
 'change_justification': u'original',
 'chapter': u"//*[((name()='h1' or name()='h2') and re:test(., '\\s*((chapter|book|section|part)\\s+)|((prolog|prologue|epilogue)(\\s+|$))', 'i')) or @class = 'chapter']",
 'chapter_mark': u'pagebreak',
 'comments': None,
 'cover': u'C:\\Users\\David\\AppData\\Local\\Temp\\calibre_4zxfkr\\f0xlpt.jpeg',
 'debug_pipeline': None,
 'dehyphenate': True,
 'delete_blank_paragraphs': True,
 'disable_font_rescaling': False,
 'dont_split_on_page_breaks': False,
 'duplicate_links_in_toc': False,
 'embed_all_fonts': False,
 'embed_font_family': None,
 'enable_heuristics': False,
 'epub_flatten': False,
 'epub_inline_toc': False,
 'epub_toc_at_end': False,
 'expand_css': False,
 'extra_css': None,
 'extract_to': None,
 'filter_css': u'',
 'fix_indents': True,
 'flow_size': 260,
 'font_size_mapping': None,
 'format_scene_breaks': True,
 'html_unwrap_factor': 0.4,
 'input_encoding': None,
 'input_profile': <calibre.customize.profiles.InputProfile object at 0x0000000004ADD9E8>,
 'insert_blank_line': False,
 'insert_blank_line_size': 0.5,
 'insert_metadata': False,
 'isbn': None,
 'italicize_common_cases': True,
 'keep_ligatures': False,
 'language': None,
 'level1_toc': None,
 'level2_toc': None,
 'level3_toc': None,
 'line_height': 0.0,
 'linearize_tables': False,
 'margin_bottom': 5.0,
 'margin_left': 5.0,
 'margin_right': 5.0,
 'margin_top': 5.0,
 'markup_chapter_headings': True,
 'max_toc_links': 50,
 'minimum_line_height': 120.0,
 'no_chapters_in_toc': False,
 'no_default_epub_cover': False,
 'no_inline_navbars': False,
 'no_svg_cover': False,
 'output_profile': <calibre.customize.profiles.KoboReaderOutput object at 0x0000000004AF20B8>,
 'page_breaks_before': u"//*[name()='h1' or name()='h2']",
 'prefer_metadata_cover': False,
 'preserve_cover_aspect_ratio': True,
 'pretty_print': True,
 'pubdate': None,
 'publisher': None,
 'rating': None,
 'read_metadata_from_opf': u'C:\\Users\\David\\AppData\\Local\\Temp\\calibre_4zxfkr\\snb04d.opf',
 'remove_fake_margins': True,
 'remove_first_image': False,
 'remove_paragraph_spacing': False,
 'remove_paragraph_spacing_indent_size': 1.5,
 'renumber_headings': True,
 'replace_scene_breaks': u'',
 'search_replace': '[]',
 'series': None,
 'series_index': None,
 'smarten_punctuation': False,
 'sr1_replace': None,
 'sr1_search': None,
 'sr2_replace': None,
 'sr2_search': None,
 'sr3_replace': None,
 'sr3_search': None,
 'start_reading_at': None,
 'subset_embedded_fonts': False,
 'tags': None,
 'timestamp': None,
 'title': None,
 'title_sort': None,
 'toc_filter': None,
 'toc_threshold': 6,
 'toc_title': None,
 'unsmarten_punctuation': False,
 'unwrap_lines': True,
 'use_auto_toc': False,
 'verbose': 2}
InputFormatPlugin: MOBI Input running
on C:\Users\David\AppData\Local\Temp\calibre_4zxfkr\99h3z4.mobi
Extracting text...
Adding anchors...
Extracting images...
Cleaning up HTML...
Parsing HTML...
Converting style information to CSS...
Creating OPF...
Parsing all content...
Parsing styles.css ...
Parsing index.html ...
Forcing index.html into XHTML namespace
Reading TOC from NCX...
Merging user specified metadata...
Detecting structure...
Flattening CSS and remapping font sizes...
Source base font size is 12.00000pt
Removing fake margins...
Found 45 items of level: div_1
Found 10 items of level: p_4
Found 4926 items of level: p_1
Ignoring level p_4
div_1  left margin stats: Counter()
div_1  right margin stats: Counter()
p_1  left margin stats: Counter({u'0': 4926})
p_1  right margin stats: Counter({u'0': 4926})
Cleaning up manifest...
Trimming unused files from manifest...
Trimming u'images/00008.jpg' from manifest
Trimming u'images/00009.jpg' from manifest
Creating EPUB Output...
Python function terminated unexpectedly
  local variable 'args' referenced before assignment (Error Code: 1)
Traceback (most recent call last):
  File "site.py", line 132, in main
  File "site.py", line 109, in run_entry_point
  File "site-packages\calibre\utils\ipc\worker.py", line 195, in main
  File "site-packages\calibre\gui2\convert\gui_conversion.py", line 31, in gui_convert_override
  File "site-packages\calibre\gui2\convert\gui_conversion.py", line 25, in gui_convert
  File "site-packages\calibre\ebooks\conversion\plumber.py", line 1194, in run
  File "site-packages\calibre\ebooks\conversion\plugins\epub_output.py", line 192, in convert
  File "site-packages\calibre\ebooks\oeb\transforms\rescale.py", line 21, in __call__
  File "site-packages\calibre\gui2\__init__.py", line 1057, in is_ok_to_use_qt
  File "site-packages\calibre\gui2\__init__.py", line 1049, in must_use_qt
UnboundLocalError: local variable 'args' referenced before assignment

I did not test this with 1.200 so can't say it is a new issue in 1.201. Hopefully, this will be of some help.

Regards,
David

[Terisa de morgan]

Originally Posted by kovidgoyal

I have uploaded new beta builds (1.201) these include all the changes from todays main calibre release as well as fixes for all issues reported in this thread.

http://download.calibre-ebook.com/betas/

Thanks a lot for -15px...

[kovidgoyal]

@DNSB: Ah that bug affects conversions on non-linux platforms. I have committed a fix and I will upload 1.201.2 in a little while with the fix since it is a fairly severe bug.

https://github.com/kovidgoyal/calibr...fbf612d961ef50

[kovidgoyal]

I have uploaded 1.201.2 with the fix for the issue reported by DNSB

[DNSB]

Originally Posted by kovidgoyal

I have uploaded 1.201.2 with the fix for the issue reported by DNSB

That is seriously quick service! Thanks!

Edit: downloaded and installed the update and tried several conversions. All went fine!

Regards,
David

[DiapDealer]

Having trouble with a personal (inherited) plugin that has a lot of the following calls

return unicode(self.lineedit.text().toUtf8(), 'utf8').strip()

that work with Qt4 but not with Qt5 (self.lineedit is a QLineEdit object. if that wasn't clear). I get the following error under Qt5:

unicode object has no toUtf8 attribute

I was thinking this might fall under the QVariant conversion portion of your porting guide (toInt, toBool, etc), but wasn't certain if I should utilize your convert_qvariant() solution for that, or if there's just some plain overkill going on in the original code that could be fixed with something like:

return unicode(self.lineedit.text()).strip()

Thanks for any advice.

**NOTE: these values from the QLineEdit objects may contain non-ascii characters and will eventually be saved/retrieved in/from the plugin's JSON prefs file if that has any bearing at all.

[kovidgoyal]

return unicode(self.lineedit.text()).strip()

will do the right thing in both Qt 4 and Qt 5

[theducks]

Ninja'd by Kovid

[DiapDealer]

Originally Posted by kovidgoyal

return unicode(self.lineedit.text()).strip()

will do the right thing in both Qt 4 and Qt 5

Thanks. That's just the type of non-complicated solution what I was I was hoping for.

[DiapDealer]

Originally Posted by jackie_w

What is the best way to deal with the change to the QFileDialog.getOpenFileName method?

PyQt4 used to return a single filepath but PyQt5 returns 2 strings (filepath, filter). I don't need the filter part of the result so I've temporarily solved it like this:

fd = QFileDialog()
if hasattr(fd, 'getOpenFileNameAndFilter'):
    # PyQt4
    ans = fd.getOpenFileNameAndFilter(self, mycaption, mydir, myfilter)
else:    
    # PyQt5
    ans = fd.getOpenFileName(self, mycaption, mydir, myfilter)
selfile = unicode(ans[0])

Is there a better calibre-way of doing this? I fully admit that this particular personal plugin started life completely external to calibre so uses less calibre special functionality than it might. I tend to only fix things if they break.

I have no idea if it's "better" or not, but I went with something like:

ans = QFileDialog.getOpenFileName(self, mycaption, mydir, myfilter)
selfile = ans[0] if isinstance(ans, tuple) else ans
    if selfile:
        do-stuff with selfile

when I ran into something similar with QFileDialog.getSaveFileName.

[jackie_w]

@DiapDealer,

Thanks for that Certainly less wordy than mine. I think I'll try your way.