[GUI Plugin] FanFictionDownLoader

[cryzed]

Nothing essentially, the new split character is now "\,", so you'll have to replace "{{,}}" with the new one.

[Amalthia]

Originally Posted by cryzed

Nothing essentially, the new split character is now "\,", so you'll have to replace "{{,}}" with the new one.

When I first read it I thought I couldn't use the single line anymore. I tested it both ways and both ways work.

[cryzed]

Oh, good to know. I suppose Jimm left in the "{{,}}" for backwards compatibility.

[cryzed]

Jimm, now I have a question myself . Is this currently the best way to populate a Calibre category with modified metadata, without changing the original metadata? (I don't think I need \, here, since my #category column is a tag-like text type)

extra_valid_entries:_category
include_in__category:category

replace_metadata:
 _category=>(.*)=>Fanfiction,\1 Fanfiction

custom_columns_settings:
 _category=>#category,a

[JimmXinu]

Originally Posted by cryzed

Oh, good to know. I suppose Jimm left in the "{{,}}" for backwards compatibility.

Ummm... no, I didn't. Only \, should be splitting list entries. That's what happens for me--{{,}} becomes {{;}} in the middle of the tag.

[cryzed]

I guess I misunderstood Amalthia then. Any tip regarding my question?

[JimmXinu]

Originally Posted by cryzed

Jimm, now I have a question myself . Is this currently the best way to populate a Calibre category with modified metadata, without changing the original metadata? (I don't think I need \, here, since my #category column is a tag-like text type)

extra_valid_entries:_category
include_in__category:category

replace_metadata:
 _category=>(.*)=>Fanfiction,\1 Fanfiction

custom_columns_settings:
 _category=>#category,a

Well, I personally wouldn't use _category, no matter how pythonic. I thought you had a bunch of typos at first.

Are you asking for a general case, or a specific solution?

In the general case, yes, to modify a metadata list and put it in a custom columns without changing the original list, that's fine. And the 'a' on custom_columns_settings makes it just add without replacing.

But in specific, if you always want 'Fanfiction' as its own tag and 'Harry Potter Fanfiction', 'Stargate Fanfiction', etc, I think you need the split from '\,'.

[cryzed]

The problem is when I try to use \, for a tag-like text column in Calibre it only adds the first element, not all elements. A simple string like "Fanfiction, Test Fanfiction" without the new \, feature works though.

[JimmXinu]

Originally Posted by cryzed

The problem is when I try to use \, for a tag-like text column in Calibre it only adds the first element, not all elements. A simple string like "Fanfiction, Test Fanfiction" without the new \, feature works though.

Oh, that's interesting--and possibly buggy. I confess I was mostly looking at the tags column while I was testing that. I'll look into it a bit.

[JimmXinu]

Originally Posted by JimmXinu

Oh, that's interesting--and possibly buggy. I confess I was mostly looking at the tags column while I was testing that. I'll look into it a bit.

Definitely buggy.

First, there's a bug in the 'a' option for custom_columns_settings--it always replaces everything anyway. But that's a one line fix. (I wonder how long that's been broken?)

Just ',' without split works for tag-like text columns because they get set as strings (not lists) and calibre splits them on the commas. Lists are ', '.join()ed before getting passed in to set custom columns--I didn't remember at first. Tags are kept as a list of string values because calibre expects Tags to be a list.

Your match anything pattern '(.*)' when applied to 'category' with a '\,' split causes the infinite recursion/loop I expected to see before, but couldn't find--I guess I didn't try hard enough. But it doesn't on _category, which has the same cause as the next issue:

I also see the issue with all but the first value of a '\,' split value being discarded when it's an extra_valid_entries, or rather a metadatum that uses include_in_X . That has to do with the way include_in_X is implemented conflicting with how '\,' split is implemented.

I now realize that the (very simplistic) way that I implied the '\,' split feature is fundamentally broken. As proven, it doesn't work with include_in_X and it has the risk of infinite recursion/loop--whether it's a recursion or a loop depends on how you look at it.

I have some ideas I'm going to pursue, but I thought I'd report back my progress now that I actually understand what's going on.

[vikarti]

is it possible to add support to FFDL for following mostly-Russian-language sites:
- fanfics.me (mainly fics)
- ficbook.net (maily fics)
- samlib.ru (some fics, some original content)
?

[cryzed]

Well, I can take a look at them. Foreign languages sites are always especially fun though :P, and requesting three at once when "perfecting" one can take up to an hour and more -- It might take a while, is what I'm saying.

[Tanjamuse]

Is there a function which allows the plugin to automatically pick up the link, if it is useable?

Also, it would be nice to be able to Auto-sort on a custom column.

[cryzed]

"Pick up the link"? What exactly do you mean?

If I understand you correctly the "Add New from URL(s)" window does something like that -- not sure to which extent though. Meaning, you can have a bunch of text with your URLs in your clipboard and it should be able to automatically filter out story URLs (it fills them automatically in as soon as you open the window, I think).

Alternatively there's the "Get Story URLs to Download from Webpage" button which you could try -- which won't work in all circumstances though.

[Tanjamuse]

Now, it pick up the first link, I would love to have to avoid the copy-paste of the rest. If there is that function, I haven't found it