Windows Recycle Bin?

JimmXinu · 02-23-2014, 03:22 PM

In the last few weeks, ebooks and ebook files deleted in calibre end up in my Windows Recycle Bin, but the Bin still shows the empty icon.

Is anyone else seeing this? I've already tried rebooting.

I'm using:

Code:

calibre 1.25 [64bit]  isfrozen: True is64bit: True
Windows-8-6.2.9200 Windows ('64bit', 'WindowsPE')
('Windows', '8', '6.2.9200')
Python 2.7.5

Has the way calibre deletes files changed lately? I also had a windows update recently, so it may not be calibre.

theducks · 02-23-2014, 03:26 PM

My bin is empty, so I am no help.

I would blame windows anyway

Trash is still trash. no matter how it got there.

JimmXinu · 02-23-2014, 03:35 PM

It's a pretty trivial problem, I won't dispute that. But it is a niggling little irritation.

jackie_w · 02-23-2014, 04:34 PM

I'm using calibre 1.25 (32-bit) on a Win7 64-bit PC.

- emptied my Recycle Bin (RB). Bin icon shows empty.
- imported a book into calibre then immediately deleted it again. Bin icon still shows empty.
- opened RB to see if anything in it. Deleted book dir is sitting there. Closed RB without doing anything. Bin icon now stuffed with paper. Actually, I rechecked. Bin icon fills with paper as soon as RB is opened.

Your guess is as good as mine

BetterRed · 02-23-2014, 06:54 PM

Quote:

Originally Posted by JimmXinu

In the last few weeks, ebooks and ebook files deleted in calibre end up in my Windows Recycle Bin, but the Bin still shows the empty icon.

Is anyone else seeing this? I've already tried rebooting.

I'm using:

Code:

calibre 1.25 [64bit]  isfrozen: True is64bit: True
Windows-8-6.2.9200 Windows ('64bit', 'WindowsPE')
('Windows', '8', '6.2.9200')
Python 2.7.5

Has the way calibre deletes files changed lately? I also had a windows update recently, so it may not be calibre.

I'm on Win 7-SP1 fully patched, calibre 1.25.1 (64 bit)

Emptied bin, then tapped Del on a book, confirmed, and the icon instantly goes non empty. When I open the bin I see this folder in the bin "E:\Calibre Libraries\Test deleted wxkcl7" in that folder is the book folder I deleted from my Test library, if I restore it the icon instantly goes to empty.

In other words - not SNAFU here

What happens to the icon if you empty the bin and delete something from windows and restore it again ?

Have you tried a sfc /scannow ?

Could be your registry got screwed by malware - do a scan with up to date malwarebytes.

BR

kovidgoyal · 02-23-2014, 09:29 PM

The way calibre deletes files was changed as part of the database changes around 1.0, but certainly not in the last few weeks.

soulfuldog · 02-24-2014, 01:06 PM

Quote:

Originally Posted by jackie_w

I'm using calibre 1.25 (32-bit) on a Win7 64-bit PC.

- emptied my Recycle Bin (RB). Bin icon shows empty.
- imported a book into calibre then immediately deleted it again. Bin icon still shows empty.
- opened RB to see if anything in it. Deleted book dir is sitting there. Closed RB without doing anything. Bin icon now stuffed with paper. Actually, I rechecked. Bin icon fills with paper as soon as RB is opened.

Your guess is as good as mine

This is what mine does too, Calibre 1.24 (32-bit), Win7 (64-bit), also my Calibre library is stored in dropbox, is that maybe a factor? I've no idea if it's always done it this way with Calibre, have never noticed before now.

JimmXinu · 02-24-2014, 10:32 PM

Quote:

Originally Posted by kovidgoyal

The way calibre deletes files was changed as part of the database changes around 1.0, but certainly not in the last few weeks.

Well, I noticed it in the last few weeks.

It looks like it's been happening longer because deleting books/files in the last 0.9 version works as expected--bin changes icon and makes crumpled paper noise immediately.

kovidgoyal · 02-24-2014, 10:44 PM

Here is the code for deleting files in calibre, it happens in a separate process, because windows has no API for deleting to recycle bin that does not spin the event loop. And processing events while in the middle of a database update operation is a strict no-no if you want to maintain database integrity.

https://github.com/kovidgoyal/calibr...dows/recycle.c

I can see nothing there that could possibly cause an issue. I suspect that the windows SHFileOperation function is broken. It assumes it is called from within a GUI app with a window, and if it is called from a command line program, it fails to update the recycle bin icon, on some systems.

On my windows system, the recycle bin icon is updated as soon as a book is deleted.

JimmXinu · 02-24-2014, 11:52 PM

Some kind of windows oddness then. Thanks for taking the time to look into it and explain.

BetterRed · 02-25-2014, 01:47 AM

Quote:

Originally Posted by JimmXinu

Some kind of windows oddness then. Thanks for taking the time to look into it and explain.

Its probably something gone awry with the Recycle Bin 'metadata' rather than the code, in other words its corrupted. There are two relevant videos at this link http://www.youtube.com/user/ITBroom/videos which may help

I think you'll need to do the one titled Take Full Control of the Recycle Bin before you start doing the Tackling a Corrupt Recycle Bin steps.

You'll need to do it on each drive where you have a Recycle Bin configured, which by default is probably everything.

I have vague memory of Recycle Bins going topsy turvy if I deleted things on NTFS removable drives on different machines.

BR

DoctorOhh · 02-25-2014, 05:49 AM

Quote:

Originally Posted by jackie_w

I'm using calibre 1.25 (32-bit) on a Win7 64-bit PC.

- emptied my Recycle Bin (RB). Bin icon shows empty.
- imported a book into calibre then immediately deleted it again. Bin icon still shows empty.
- opened RB to see if anything in it. Deleted book dir is sitting there. Closed RB without doing anything. Bin icon now stuffed with paper. Actually, I rechecked. Bin icon fills with paper as soon as RB is opened.

Not that I care in the least,

but for another data point, my setup and experience is identical.

kovidgoyal · 02-25-2014, 06:06 AM

Is everyone that experiences it running 32bit? Because I can reproduce it in my 32bit VM but not my 64bit VM.

DoctorOhh · 02-25-2014, 06:09 AM

It does seem to be the 32 bit versions for Windows 7 afflicted. Personally I have never checked before this thread and may never check again until the topic arises on this board.

Update: It seems that the OP is running Windows 64 bit (unless I'm misreading the first post.)

kovidgoyal · 02-25-2014, 07:01 AM

Apparently, if I just make the delete process sleep for a little while (1 sec) before exiting, windows updates the recycle bin icon. Windows is weird. In any case I will make that change for the next release. It means that deleting to recycle bin will take one second longer per book for all windows users, but...

02-23-2014, 03:22 PM	#1
JimmXinu Plugin Developer Posts: 6,973 Karma: 4604635 Join Date: Dec 2011 Location: Midwest USA Device: Kobo Clara Colour running KOReader	Windows Recycle Bin? In the last few weeks, ebooks and ebook files deleted in calibre end up in my Windows Recycle Bin, but the Bin still shows the empty icon. Is anyone else seeing this? I've already tried rebooting. I'm using: Code: calibre 1.25 [64bit] isfrozen: True is64bit: True Windows-8-6.2.9200 Windows ('64bit', 'WindowsPE') ('Windows', '8', '6.2.9200') Python 2.7.5 Has the way calibre deletes files changed lately? I also had a windows update recently, so it may not be calibre.

02-23-2014, 04:34 PM	#4
jackie_w Grand Sorcerer Posts: 6,252 Karma: 16544692 Join Date: Sep 2009 Location: UK Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3	I'm using calibre 1.25 (32-bit) on a Win7 64-bit PC. - emptied my Recycle Bin (RB). Bin icon shows empty. - imported a book into calibre then immediately deleted it again. Bin icon still shows empty. - opened RB to see if anything in it. Deleted book dir is sitting there. Closed RB without doing anything. Bin icon now stuffed with paper. Actually, I rechecked. Bin icon fills with paper as soon as RB is opened. Your guess is as good as mine Last edited by jackie_w; 02-23-2014 at 04:38 PM. Reason: blue bit

02-25-2014, 06:09 AM	#14
DoctorOhh US Navy, Retired Posts: 9,897 Karma: 13806776 Join Date: Feb 2009 Location: North Carolina Device: Icarus Illumina XL HD, Kindle PaperWhite SE 11th Gen	It does seem to be the 32 bit versions for Windows 7 afflicted. Personally I have never checked before this thread and may never check again until the topic arises on this board. Update: It seems that the OP is running Windows 64 bit (unless I'm misreading the first post.) Last edited by DoctorOhh; 02-25-2014 at 06:11 AM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Seriously thoughtful Repeating threads in the deals forum - recycle or repost?	Cyberman tM	Lounge	7	12-11-2012 05:07 PM
How to stop Calibre from creating a Recycle Bin?	zentiment	Library Management	1	09-09-2011 04:53 AM
Calibre files in Recycle Bin	petercreasey	Calibre	1	01-18-2010 11:02 AM
Recycle your PDA at Staples	Colin Dunstan	Lounge	1	11-13-2004 04:35 PM

02-23-2014, 03:26 PM	#2
theducks Well trained by Cats Posts: 31,062 Karma: 60358908 Join Date: Aug 2009 Location: The Central Coast of California Device: Kobo Libra2,Kobo Aura2v1, K4NT(Fixed: New Bat.), Galaxy Tab A	My bin is empty, so I am no help. I would blame windows anyway Trash is still trash. no matter how it got there.

02-23-2014, 03:35 PM	#3
JimmXinu Plugin Developer Posts: 6,973 Karma: 4604635 Join Date: Dec 2011 Location: Midwest USA Device: Kobo Clara Colour running KOReader	It's a pretty trivial problem, I won't dispute that. But it is a niggling little irritation.

02-23-2014, 09:29 PM	#6
kovidgoyal creator of calibre Posts: 45,359 Karma: 27182818 Join Date: Oct 2006 Location: Mumbai, India Device: Various	The way calibre deletes files was changed as part of the database changes around 1.0, but certainly not in the last few weeks.

02-24-2014, 10:44 PM	#9
kovidgoyal creator of calibre Posts: 45,359 Karma: 27182818 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Here is the code for deleting files in calibre, it happens in a separate process, because windows has no API for deleting to recycle bin that does not spin the event loop. And processing events while in the middle of a database update operation is a strict no-no if you want to maintain database integrity. https://github.com/kovidgoyal/calibr...dows/recycle.c I can see nothing there that could possibly cause an issue. I suspect that the windows SHFileOperation function is broken. It assumes it is called from within a GUI app with a window, and if it is called from a command line program, it fails to update the recycle bin icon, on some systems. On my windows system, the recycle bin icon is updated as soon as a book is deleted.

02-24-2014, 11:52 PM	#10
JimmXinu Plugin Developer Posts: 6,973 Karma: 4604635 Join Date: Dec 2011 Location: Midwest USA Device: Kobo Clara Colour running KOReader	Some kind of windows oddness then. Thanks for taking the time to look into it and explain.

02-25-2014, 06:06 AM	#13
kovidgoyal creator of calibre Posts: 45,359 Karma: 27182818 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Is everyone that experiences it running 32bit? Because I can reproduce it in my 32bit VM but not my 64bit VM.

02-25-2014, 07:01 AM	#15
kovidgoyal creator of calibre Posts: 45,359 Karma: 27182818 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Apparently, if I just make the delete process sleep for a little while (1 sec) before exiting, windows updates the recycle bin icon. Windows is weird. In any case I will make that change for the next release. It means that deleting to recycle bin will take one second longer per book for all windows users, but...