Register Guidelines E-Books Today's Posts Search

Go Back   MobileRead Forums > E-Book Software > Calibre > Development

Notices

Closed Thread
 
Thread Tools Search this Thread
Old 12-03-2013, 02:18 AM   #166
eschwartz
Ex-Helpdesk Junkie
eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.
 
eschwartz's Avatar
 
Posts: 19,421
Karma: 85400180
Join Date: Nov 2012
Location: The Beaten Path, USA, Roundworld, This Side of Infinity
Device: Kindle Touch fw5.3.7 (Wifi only)
How exactly does beautify vs. fix html work?
eschwartz is offline  
Old 12-03-2013, 02:20 AM   #167
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,364
Karma: 27230406
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
fix html simply ensures that the html is well-formed (no unclosed tags, incorrect attribute syntax and so on). Prettyfying does that and also makes the html look "pretty" -- blanks lines, indents and so on.
kovidgoyal is online now  
Old 12-03-2013, 02:40 AM   #168
eschwartz
Ex-Helpdesk Junkie
eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.
 
eschwartz's Avatar
 
Posts: 19,421
Karma: 85400180
Join Date: Nov 2012
Location: The Beaten Path, USA, Roundworld, This Side of Infinity
Device: Kindle Touch fw5.3.7 (Wifi only)
Random typo:

Quote:
ERROR: Cannot replace: Currently selected text does not match the search query.You must first click Find, before trying to replace
Needs space before "You" and a closing period.

Also, I am getting "There are unsaved changes in "filename". Are you sure you want to close this editor?" AFTER I click the main save button, and the bottom right corner is cheerfully telling me "Saved" for the entire course of my editing. Not sure what is up with that.
eschwartz is offline  
Old 12-03-2013, 02:47 AM   #169
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,364
Karma: 27230406
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
Ignore the unsaved changes in filename message, it's a holdover that I forgot to remove.
kovidgoyal is online now  
Old 12-03-2013, 11:22 AM   #170
GRiker
Comparer of the Ephemeris
GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.
 
Posts: 1,496
Karma: 424697
Join Date: Mar 2009
Device: iPad
If I'm editing a book which uses <h2> elements for each chapter title, and there are no other <h1> or <h3> elements in the book, when generating a TOC from the headings, the chapter 1 heading is listed with all subsequent chapters as descendants, even though they should be peers.

G
GRiker is offline  
Old 12-03-2013, 12:11 PM   #171
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,364
Karma: 27230406
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
Can you send me the book.
kovidgoyal is online now  
Old 12-03-2013, 12:41 PM   #172
GRiker
Comparer of the Ephemeris
GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.GRiker ought to be getting tired of karma fortunes by now.
 
Posts: 1,496
Karma: 424697
Join Date: Mar 2009
Device: iPad
Quote:
Originally Posted by kovidgoyal View Post
Can you send me the book.
On its way to you.

G
GRiker is offline  
Old 12-03-2013, 03:57 PM   #173
arspr
Dead account. Bye
arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.
 
Posts: 587
Karma: 668244
Join Date: Mar 2011
Device: none
Thumbs up

First of all



Sigil is nearly dead and you set up a similar tool inside Calibre in just two months!!!, which even in an early WIP state seems just great

But you ask for opinions/detected bugs, so here I go . I've just started playing with it so these are going to be just first impressions. As it is completely expected, welcomed and logical, please feel ABSOLUTELY FREE to ignore whatever stupid things I say.
  • Please add the "Count All" button Sigil has in the search tool bar. (I know it's in the Search menu, but a direct access in the tool bar would be great).
  • As an important difference with Sigil, Calibre's tool supports any kind of internal folder structure. But you don't actually show it in the files browser. You just see the epub contents but you don't know and you cannot manage how they are stored. Because of this behaviour I suppose you need some kind of additional tool like a "folders" browser. Or maybe the ability to switch between sorting by type (as it currently works) or by folder location (with ability to drag and drop files between folders). Of course, changing a file location should automatically update every single reference to the file in htmls, content.opf and/or toc.ncx.
  • A pretty stupid little thing. How do you start a brand new book?
  • I do like to see the inspector. But it is always closed when you exit the editor. Is it feasible to remember the last layout of windows?
  • Is it possible to sync position between editor, preview AND inspector?
  • I do miss some useful tools from Sigil (but there's really no hurry in adding them, isn't there?). The more important IMO are ToC viewer (I do really think it is a nearly must have), links tool, metadata editor, Flightcrew validator, Delete unused CSS styles/media files and reports.
  • Another one I really miss is the "link to CSS style" feature. You have already said that it can be a tricky issue as it can have several matches, but it is normally a really useful feature.

Nevertheless, as I said at the beginning if I hadn't seen what you have already achieved I wouldn't have believed it possible...

EDITED.

Two possible bugs I've detected after Beautifying a file:
  • The html file has been changed as expected but I still get the Saved message in the lower right corner. Is it a bug? or what's the meaning of that Saved? I've checked that if I exit without explicitly saving, NO saves are actually made.
  • <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd"> has disappeared. Is that behaviour right?

Last edited by arspr; 12-03-2013 at 04:10 PM. Reason: Two possible bugs
arspr is offline  
Old 12-03-2013, 10:27 PM   #174
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,364
Karma: 27230406
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
@arspr:

There's no place for count all in the find toolbar, calibre's find toolbar ios smaller than Sigils. You can however access it via keyboard shortcut.

While calibre supports arbitrary file layouts, changing them is not something I much care about. It really does not matter what layout the files are in inside the epub. However at some point I will create a tool to automatically rename files into a "standard" layout. If you really want an actual file browser, you are welcome to submit patches for one. And links are updated when you rename files automatically, already.

You dont, this is a tool to tweak existing books, not create them. That said, in the future, I will add a wizard to import html, txt ot docx files directly.

window layout is remembered with the exception of the inspector. The inspector has major performance impact, therefore it always starts closed.

No, there is no way to control the inspector in Qt WebKit.

There is already a toc editor, click the button with the T on it. As for the rest, patches are welcome.

I already said I would look into implementing that, and that if I did implement it, it would work a lot better than Sigils.

Saving is asynchronous, therefore the saved message simple indicates the last save was completed. Try saving a large azw3 file (saving for azw3 is slow, and you will see the saving happen in the bottom right corner). However, since this is likely to be confusing for people, I will remove the saved message in the next release.

Yes Tweak Book removes doctypes (as does conversion in calibre). Doctypes are good for nothing in the ebook world, and only cause problems -- see for example all the issues Sigil had with &nbsp;.

Last edited by kovidgoyal; 12-03-2013 at 10:31 PM.
kovidgoyal is online now  
Old 12-03-2013, 11:16 PM   #175
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,364
Karma: 27230406
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
@arspr: Actually on second thoughts, there may be a way to sync the inspector to the cursor position in the code view, I will look into it.

Last edited by kovidgoyal; 12-03-2013 at 11:46 PM.
kovidgoyal is online now  
Old 12-04-2013, 10:55 AM   #176
arspr
Dead account. Bye
arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.
 
Posts: 587
Karma: 668244
Join Date: Mar 2011
Device: none
Quote:
Originally Posted by kovidgoyal View Post
There is already a toc editor, click the button with the T on it. As for the rest, patches are welcome.
I haven't expressed fine as you haven't understood. I know about the ToC editor/creator. In fact it's better than Sigil's one, so I usually use it since you added it to Calibre.

What I miss is the ToC Viewer which allows directly opening the file and location pointed by ToC entries. An example: I want to edit something in Chapter Five and this is a ToC link to part07.xhtml#Chp05, so if click in ToC Viewer, part07.xhtml file is opened and the focus directed to wherever id="Chp05" is located.

(In fact I usually have the ToC Viewer in Sigil always displayed below the book browser).

Quote:
Originally Posted by kovidgoyal View Post
Saving is asynchronous, therefore the saved message simple indicates the last save was completed. Try saving a large azw3 file (saving for azw3 is slow, and you will see the saving happen in the bottom right corner). However, since this is likely to be confusing for people, I will remove the saved message in the next release.
Maybe another idea could be that you can show two informations in the corner without needing to remove it:
Last save finished/Saving --AND-- eBook with modifications or not (the * which is shown in Sigil beside the name of the book in the window title).
arspr is offline  
Old 12-04-2013, 11:04 AM   #177
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,364
Karma: 27230406
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
Oh you want to navigate using the ToC. Well that is pretty trivial to implement. Remind me about it once Tweak Book is released.

The modified status of the ebook file as a whole is indicated by the status of the save icon, it is disabled when there are no pending changes to be saved and enabled when there are pending changes.
kovidgoyal is online now  
Old 12-04-2013, 11:12 AM   #178
Katsunami
Grand Sorcerer
Katsunami ought to be getting tired of karma fortunes by now.Katsunami ought to be getting tired of karma fortunes by now.Katsunami ought to be getting tired of karma fortunes by now.Katsunami ought to be getting tired of karma fortunes by now.Katsunami ought to be getting tired of karma fortunes by now.Katsunami ought to be getting tired of karma fortunes by now.Katsunami ought to be getting tired of karma fortunes by now.Katsunami ought to be getting tired of karma fortunes by now.Katsunami ought to be getting tired of karma fortunes by now.Katsunami ought to be getting tired of karma fortunes by now.Katsunami ought to be getting tired of karma fortunes by now.
 
Katsunami's Avatar
 
Posts: 6,111
Karma: 34000001
Join Date: Mar 2008
Device: KPW1, KA1
With regard to the Metadata Editor: I assume it's possible to just call up Calibre's own metadata dialog? It wouldn't be logical to implement a completely different dialog for Tweak Book. In that case, it could be left out entirely, because Calibre itself can already do metadata editing.
Katsunami is offline  
Old 12-04-2013, 11:26 AM   #179
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,364
Karma: 27230406
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
At the moment I dont much care about the metadata editor. In the upcoming release, Tweaking a book inside calibre will automatically update the opf from the metadata inside the calibre library (this can be turned off with an option). Therefore, the only case for which a metadata editor is useful is for people using tweak book without the rest of calibre, and that isn't a use case high on my list of priorities to address. But, as always, patches are welcome.

If you do want to implement it yourself,
you wont be able to use the calibre metadata editor dialog directly, as it is tied to the calibre database, and in any case is not really suitable, since there is no need to edit the cover and calibre custom metadata in the edit metadata tool inside tweak book.
kovidgoyal is online now  
Old 12-04-2013, 04:43 PM   #180
arspr
Dead account. Bye
arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.
 
Posts: 587
Karma: 668244
Join Date: Mar 2011
Device: none
Another possibly irrelevant issue:

Beautify also changes <?xml version="1.0" encoding="utf-8" standalone="no"?> into <?xml version='1.0' encoding='utf-8'?>



And another possible suggestion, although it's a matter of preferences.

Imagine this
Code:
<p>Example paragraph with <i>italics</i> inside</p>
And then because of an editing error you forget the closing </i>.

In this situation:
  • Sigil gives you an error in the preview saying "html error in line whatever" or something similar. And it actually stops the file rendering in that paragraph.
  • Calibre silently "fixes" it with a greedy approach (the only one it can actually have). It converts the former paragraph into
    Code:
    <p>Example paragraph with <i>italics inside</i></p>
    without any warning.
Well I really hate intelligent software doing what it thinks it's right on its own... I prefer being told that I've got some kind of trouble, but being forced to solve it myself.

Nevertheless I suppose that a fully "automatic and smart" behaviour is always preferable in a fully automated tool like, as example, the Calibre file format converter. But I think that an advanced tweaker, like this Sigilish editor is intended to be, shouldn't behave in the same way. The user should retain full control all the time.

But as I started the post saying it's just a preference issue. Maybe a lot of people will prefer the current automated behaviour. It's up to you changing it or not, each solution has its own advantages and disadvantages.
arspr is offline  
Closed Thread


Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
How to make Sigil live varlog Sigil 136 10-25-2013 02:34 PM
how many tocs does Sigil make? Gregg Bell Sigil 17 01-31-2013 09:39 AM
How do I make all .pdf's in my calibre library open in calibre instead of preview morbo3000 Library Management 9 07-30-2011 10:39 AM
using sigil to make changes befote conversion alansplace Sigil 11 06-07-2011 07:50 AM
i can't make sigil run in fedora 14 nastarovia Sigil 1 01-20-2011 05:02 AM


All times are GMT -4. The time now is 10:24 PM.


MobileRead.com is a privately owned, operated and funded community.