[GUI Plugin] Modify ePub

[BetterRed]

Originally Posted by kiwidude

Is anyone else having the same problem - or are they having Modify ePub behave normally without errors (without even trying the Append Extra CSS option)?

FWIW - I do NOT get the error when append extra CSS is false (my usual setting) I do get the error if I set append extra CSS to true. Tried several books with same result.

Here's my settings (with append_extra_css as true)

Spoiler:

  "modify epub plugin:options dialog:settings": {
    "append_extra_css": true, 
    "add_replace_jacket": false, 
    "encode_html_utf8": false, 
    "remove_xpgt_files": true, 
    "remove_unmanifested_files": true, 
    "remove_unused_images": true, 
    "remove_javascript": true, 
    "remove_itunes_files": true, 
    "remove_calibre_bookmarks": true, 
    "update_metadata": true, 
    "remove_broken_covers": true, 
    "rewrite_css_margins": true, 
    "insert_replace_cover": false, 
    "remove_embedded_fonts": true, 
    "zero_xpgt_margins": true, 
    "remove_cover": true, 
    "remove_broken_ncx_links": true, 
    "remove_non_dc_elements": true, 
    "remove_legacy_jackets": true, 
    "remove_drm_meta_tags": true, 
    "flatten_toc": true, 
    "smarten_punctuation": true, 
    "remove_all_jackets": true, 
    "add_unmanifested_files": false, 
    "remove_missing_files": true, 
    "remove_os_artifacts": true
  },

BR

[kiwidude]

@BetterRed - you get the same error as DoctorOhh you mean? Or the same error as mob and ottischwenk reported?

@DoctorOhh - Thanks, I can replicate your issue from looking at the code, that is an easy fix. It comes if you do not have any extra css specified in your preference defaults.

[BetterRed]

Originally Posted by kiwidude

@BetterRed - you get the same error as DoctorOhh you mean? Or the same error as mob and ottischwenk reported?

@DoctorOhh - Thanks, I can replicate your issue from looking at the code, that is an easy fix. It comes if you do not have any extra css specified in your preference defaults.

Same as DoctorOhh I think - here you go

Spoiler:

calibre, version 1.1.0
ERROR: Modify ePub failed: No ePub files were updated

Modify ePubs
Logfile for book ID 41 (Test Epub / 4 kiwidude)
41
  Modifying:  C:\CalibreTemp\calibre_6nnbzo\7_ny9k_modify_epub\41.epub
	Updating metadata and cover
Parsing xml file: content.opf
Parsing xml file: toc.ncx
	Looking for files to remove: [u'iTunesMetadata.plist', u'iTunesArtwork']
	Looking for files to remove: [u'META-INF/calibre_bookmarks.txt']
	Looking for files to remove: [u'.DS_Store', u'thumbs.db']
	Looking for unused images
	Looking for redundant entries in manifest
	Looking for unmanifested files
	Looking for NCX to flatten
	  No nested navPoints
	Looking for broken links in the NCX
	Looking for Adobe xpgt files and links to remove
	Looking for Adobe DRM meta tags to remove
	Looking for all jackets
	Looking for embedded fonts
	Looking for css @font-face style declarations
	Looking for inline @font-face style declarations
	Looking for CSS margins
	Looking for extra CSS to append
Test Epub - ERROR: Traceback (most recent call last):
  File "calibre_plugins.modify_epub.modify", line 73, in process_book
  File "calibre_plugins.modify_epub.modify", line 165, in _process_book
TypeError: unsupported operand type(s) for |=: 'bool' and 'NoneType'

ePub not changed after 0.15 seconds

[kiwidude]

Thanks BetterRed - yeah, the fact that both you and DoctorOhh didn't get the same error as mob and ottischwenk leads me to believe that neither restarted calibre after installing the updated plugin. I will push the fix for your error shortly...

[kiwidude]

Changes in this release:

• Fix for users who do not have any Extra CSS in their defaults trying to use the Append Extra CSS option.

[BetterRed]

Originally Posted by kiwidude

Thanks BetterRed - yeah, the fact that both you and DoctorOhh didn't get the same error as mob and ottischwenk leads me to believe that neither restarted calibre after installing the updated plugin. I will push the fix for your error shortly...

That did the trick on my error

BR

[mob]

kiwidude, am pretty sure that I restarted calibre after updating....

Installed new version and all is good now - thanks a lot!

[holymadness]

I've used Modify Epub to replace covers in my ebooks for about a year now. Just recently, the plugin has started creating an ORIGINAL_EPUB file alongside the new epub, whereas previously it would delete the old and replace it with the new.

I don't want to clutter my hard drive with older versions of epubs; is there a way to return to the previous behaviour? Did I uncheck a preference by mistake?

P.S. If there's any way to batch remove the original_epubs via Calibre, would someone be so kind as to let me know? Thank you.

[DoctorOhh]

Originally Posted by holymadness

I've used Modify Epub to replace covers in my ebooks for about a year now. Just recently, the plugin has started creating an ORIGINAL_EPUB file alongside the new epub, whereas previously it would delete the old and replace it with the new.

This is the proper way for this plugin to work. In case of any issue the original is kept around.

Originally Posted by holymadness

P.S. If there's any way to batch remove the original_epubs via Calibre, would someone be so kind as to let me know?

Select all books with original_format (in search bar use formats:"=ORIGINAL_EPUB")
Click edit metadata
Use Remove format option
Select Original_epub and click ok

[Man Eating Duck]

Originally Posted by holymadness

I don't want to clutter my hard drive with older versions of epubs; is there a way to return to the previous behaviour? Did I uncheck a preference by mistake?

P.S. If there's any way to batch remove the original_epubs via Calibre, would someone be so kind as to let me know? Thank you.

Try to set the two tweaks to False in Preferences -> Tweaks (at the bottom), "original" in search for tweak (see attached screenshot).

To remove all instances of ORIGINAL_EPUB from your books *please* make a backup of your library first... Done?

Then: select all your books, right click -> Remove books -> Remove files of a specific format from selected books. Select the format ORIGINAL_EPUB.

Edit: Ninja'd by DoctorOhh
As he mentions, the original format is kept for a reason. If you remove it, make sure that you have the original file somewhere else. Replacing covers is probably safe, but for instance epub->epub conversion can be destructive in non-intuitive ways.

[holymadness]

Thank you both so much. That was very helpful and very quick.

[mob]

I use this add-on on every ebook i keep in calibre - I really like the simplicity and one-click function.... Would really appreciate if the author could add the user option not to create a back-up Original_Epub as it was done in the past.... so that it does not interfere with the creation of back-ups when doing format to same format conversions....

Otherwise, great job.... Mop

[samy2]

Thanks!

[kiwidude]

@mob - just see Man Eating Duck's post above regarding Preferences -> Tweaks.

The category of the tweak to change is "Save original file when converting/polishing from same format tos...". You will see "save_original_format_when_polishing" which as per the release notes for this plugin is what the plugin checks for - set this to False, restart calibre and you will not get the ORIGINAL_EPUB entries appearing.

[DoctorOhh]

Originally Posted by kiwidude

@mob - just see Man Eating Duck's post above regarding Preferences -> Tweaks.

The category of the tweak to change is "Save original file when converting/polishing from same format tos...". You will see "save_original_format_when_polishing" which as per the release notes for this plugin is what the plugin checks for - set this to False, restart calibre and you will not get the ORIGINAL_EPUB entries appearing.

I always seem to learn new things about calibre.