Problem with p toolbar button

JimmyG · 02-13-2013, 07:15 PM

Version 0.6.902

I start with this:

<div class="hdg">
x
</div>

with the cursor at x. I click the p button, and this is what i wind up with:

<p class="hdg">x

</p>

Well, I just went back and checked, and the same thing happens with the h buttons, except the p is replaced by h1, h2, etc. I'm pretty sure this is not how it's supposed to work.

theducks · 02-13-2013, 07:46 PM

Quote:

Originally Posted by JimmyG

Version 0.6.902

I start with this:

<div class="hdg">
x
</div>

with the cursor at x. I click the p button, and this is what i wind up with:

<p class="hdg">x

</p>

Well, I just went back and checked, and the same thing happens with the h buttons, except the p is replaced by h1, h2, etc. I'm pretty sure this is not how it's supposed to work.

AFAIK Yes, that is the way.
Pretty Print (save) will flatten what you see.

JimmyG · 02-13-2013, 08:14 PM

Come on, hitting the toolbar buttons erases the containing div, that doesn't make sense. I don't know what you're talking about with "Pretty Print (save) will flatten what you see."

Hitting the p button replaces div in both places with p...the div disappears, and all that's left is a p with class hdg.

DiapDealer · 02-13-2013, 08:29 PM

I can confirm that's been the behavior as far back as the 0.6.0 release.

theducks · 02-13-2013, 08:40 PM

Quote:

Originally Posted by JimmyG

Come on, hitting the toolbar buttons erases the containing div, that doesn't make sense. I don't know what you're talking about with "Pretty Print (save) will flatten what you see."

Hitting the p button replaces div in both places with p...the div disappears, and all that's left is a p with class hdg.

If you wish to WRAP the contents, use the Clip tool: there is a sample for P and DIV inclided:
Simply highlight the selection, and click/select (the clip item)

JimmyG · 02-14-2013, 09:04 AM

What on earth is the purpose of it?

theducks · 02-14-2013, 09:33 AM

Quote:

Originally Posted by JimmyG

What on earth is the purpose of it?

To do what you said you wanted to do: Add a Tag pai.

Works the same as the Bold or other button on the reply screen of this board.

The H#, P buttons Change the existing tags from whatever to thenew value.
What is new (in 6.x?) is they keep the same class

Make my work flow easy
Change the tag
Then at the end, search and replace the NEW Tag with the OLD class.
Typical usage on unstyled chapter headings.

DiapDealer · 02-14-2013, 11:31 AM

I admit, I don't really use those buttons much, but my understanding is that they are used to modify the current (cursor) block element for the most part. Sure, they'll create a new tag pair if you're not already inside a block element, but how handy is that really? Gui-only users often use them to promote normal paragraphs to headers and demote headers to normal paragraphs.

meme · 02-14-2013, 12:15 PM

Yes, this.

The Book View GUI is meant to provide basic editing abilities. Some things it does ok, some things not so good. div tags are something it doesn't do well.

The heading buttons + p button operate on the block element you are in, like the left/centre buttons. The Bold, Italics, etc. operate on the selection. So if you just click in the middle of a word and then click Bold, nothing happens - because you haven't selected any text. But if you just click in a word in a paragraph/div and click h1 then the containing block will be converted to an h1. Or a p if you click p.

The point of the heading+p buttons is really just to convert a line/paragraph from a heading to another type of heading or back to a normal paragraph.

If you are using divs, its best to use Code View.

Also note with Clips that they are really only best used in Book View for spans or other non-block elements - what you use on selected text. Trying to use a block level clip like p or div on a paragraph gets a bit messy as it deletes the existing block tag as it can't really tell where you are.

JimmyG · 02-14-2013, 04:26 PM

Okay, I got it, I think. I always work in Code View. The only time I switch to Book View is to see if something looks approximately right.

Way back when I first started using html I had an editor that had a whole slew of buttons in the same place. All they did what enter the opening and closing tag and position the cursor. Helpful for someone not used to typing tags. Now, it probably takes as long to move the mouse and click the button as it does to just type it.

But now that I think about it, I think I knew that the h buttons would change one to another. Just haven't used them in a while.

Thanks, everybody.

02-13-2013, 07:15 PM	#1
JimmyG Zealot Posts: 119 Karma: 28454 Join Date: Apr 2011 Location: Yuma, AZ Device: Kindle Touch, Voyage	Problem with p toolbar button Version 0.6.902 I start with this: <div class="hdg"> x </div> with the cursor at x. I click the p button, and this is what i wind up with: <p class="hdg">x </p> Well, I just went back and checked, and the same thing happens with the h buttons, except the p is replaced by h1, h2, etc. I'm pretty sure this is not how it's supposed to work.

02-14-2013, 11:31 AM	#8
DiapDealer Grand Sorcerer Posts: 28,356 Karma: 203720150 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	I admit, I don't really use those buttons much, but my understanding is that they are used to modify the current (cursor) block element for the most part. Sure, they'll create a new tag pair if you're not already inside a block element, but how handy is that really? Gui-only users often use them to promote normal paragraphs to headers and demote headers to normal paragraphs. Last edited by DiapDealer; 02-14-2013 at 11:38 AM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Eject button on toolbar?	alliani	Calibre	9	12-08-2012 07:31 AM
back button problem	tonyofla	Amazon Kindle	9	04-24-2010 05:24 AM
Interface - Button size in toolbar suggestion	jbpilote	Calibre	1	01-31-2010 10:27 AM
LrfAppender: IE toolbar similar to "Toolbar for Librie"	mumurik	LRF	1	10-13-2009 04:01 AM
LrfAppender: IE toolbar similar to "Toolbar for Librie"	mumurik	Sony Reader Dev Corner	1	10-06-2009 03:33 AM

02-13-2013, 08:14 PM	#3
JimmyG Zealot Posts: 119 Karma: 28454 Join Date: Apr 2011 Location: Yuma, AZ Device: Kindle Touch, Voyage	Come on, hitting the toolbar buttons erases the containing div, that doesn't make sense. I don't know what you're talking about with "Pretty Print (save) will flatten what you see." Hitting the p button replaces div in both places with p...the div disappears, and all that's left is a p with class hdg.

02-13-2013, 08:29 PM	#4
DiapDealer Grand Sorcerer Posts: 28,356 Karma: 203720150 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	I can confirm that's been the behavior as far back as the 0.6.0 release.

02-14-2013, 09:04 AM	#6
JimmyG Zealot Posts: 119 Karma: 28454 Join Date: Apr 2011 Location: Yuma, AZ Device: Kindle Touch, Voyage	What on earth is the purpose of it?

02-14-2013, 12:15 PM	#9
meme Sigil developer Posts: 1,274 Karma: 1101600 Join Date: Jan 2011 Location: UK Device: Kindle PW, K4 NT, K3, Kobo Touch	Yes, this. The Book View GUI is meant to provide basic editing abilities. Some things it does ok, some things not so good. div tags are something it doesn't do well. The heading buttons + p button operate on the block element you are in, like the left/centre buttons. The Bold, Italics, etc. operate on the selection. So if you just click in the middle of a word and then click Bold, nothing happens - because you haven't selected any text. But if you just click in a word in a paragraph/div and click h1 then the containing block will be converted to an h1. Or a p if you click p. The point of the heading+p buttons is really just to convert a line/paragraph from a heading to another type of heading or back to a normal paragraph. If you are using divs, its best to use Code View. Also note with Clips that they are really only best used in Book View for spans or other non-block elements - what you use on selected text. Trying to use a block level clip like p or div on a paragraph gets a bit messy as it deletes the existing block tag as it can't really tell where you are.

02-14-2013, 04:26 PM	#10
JimmyG Zealot Posts: 119 Karma: 28454 Join Date: Apr 2011 Location: Yuma, AZ Device: Kindle Touch, Voyage	Okay, I got it, I think. I always work in Code View. The only time I switch to Book View is to see if something looks approximately right. Way back when I first started using html I had an editor that had a whole slew of buttons in the same place. All they did what enter the opening and closing tag and position the cursor. Helpful for someone not used to typing tags. Now, it probably takes as long to move the mouse and click the button as it does to just type it. But now that I think about it, I think I knew that the h buttons would change one to another. Just haven't used them in a while. Thanks, everybody.