[GUI Plugin] Quality Check - Page 25

paulfiera · 05-04-2012, 04:36 AM

@kiwidude, when checking for @font-face or Adobe stuff, do you check every html file in the epub?

kiwidude · 05-04-2012, 04:56 AM

Yes. Every html file that is defined in the opf manifest. Have you found a scenario it does not work?

paulfiera · 05-04-2012, 05:52 AM

Quote:

Originally Posted by kiwidude

Yes. Every html file that is defined in the opf manifest. Have you found a scenario it does not work?

Not really, but I think that if you find a single occurrence of @font-face in an html file during the check, you can already mark that epub as having @font-face declarations and move on to the next epub without checking the rest of the html/css files. That would probably speed things up considerably.

kiwidude · 05-04-2012, 06:02 AM

It already does that.

paulfiera · 05-04-2012, 06:03 AM

Quote:

Originally Posted by kiwidude

It already does that.

How could I assume it didn't?

kiwidude · 05-04-2012, 03:14 PM

Changes in this release:

Protect against a blank author field caused by a bug in the Manage Authors dialog in calibre
Split the Check ePub submenu into two submenus for ease of usage and future expansion
Add a "Check unused image files" option to the Check ePub Structure menu, to find books with jpeg/png image files that are not referenced and can be removed to save space
Add a "Check TOC hierarchical" option to the Check ePub Structure menu, to find books with hierarchical TOC that need flattening for certain devices
Add a "Check Adobe DRM meta tag" option to the Check ePub Structure menu, to find books with html files that contain Adobe <meta /> DRM identifiers
Add a "Check Adobe inline .xpgt links" option to the Check ePub Style menu, to find books with html files that <link /> to a .xpgt file
Add a "Check @font-face" option to the Check ePub Style menu, to find books with CSS or html files that contain @font-face declarations
Add more information into the Help file for newcomers explaining some of the options.

Thanks to those of you who tested the beta versions and offered feedback. Enjoy...

jackie_w · 05-04-2012, 05:32 PM

@kiwidude,

I've spent a good few hours using Quality Check and Modify Epub to remove embedded fonts and @font-faces. Most of it is done, so thank you. However, I'm getting an error message when I look at the log from Quality Check (included below).

There are now only 8 books in my library with embedded fonts, all of which I wish to leave as-is (7 test files, 1 real book).

I can't figure out whether the error is a 9th book whose name never reaches the log or whether it's something different. Any suggestions?

Log if 'Check embedded fonts' option used:

Spoiler:

Code:

C:\Calibre\Novels\Aaa Zzz\Kallisti (Michael Woods) (5815)\Kallisti (Michael Woods) - Aaa Zzz.epub 
  Font found: fonts/xAquiline.ttf 
  Font found: fonts/xBethHand.ttf 
  Font found: fonts/xBudHand.ttf 
  Font found: fonts/xCyberCal.ttf 
  Font found: fonts/xDelphine.ttf 
  Font found: fonts/xDueDate.ttf 
  Font found: fonts/xHenryMorgan.ttf 
  Font found: fonts/xLibMono.ttf 
  Font found: fonts/xLibMonoB.ttf 
  Font found: fonts/xLibMonoBCaps.ttf 
  Font found: fonts/xLibMonoCaps.ttf 
  Font found: fonts/xLibSans.ttf 
  Font found: fonts/xLibSansB.ttf 
  Font found: fonts/xLibSansBI.ttf 
  Font found: fonts/xLibSerif.ttf 
  Font found: fonts/xLibSerifB.ttf 
  Font found: fonts/xLibSerifBI.ttf 
  Font found: fonts/xLibSerifI.ttf 
  Font found: fonts/xOgirema.ttf 
  Font found: fonts/xOgiremaB.ttf 
  Font found: fonts/xOgiremaI.ttf 
  Font found: fonts/xOldNewspaper.ttf 
  Font found: fonts/xOptimus.ttf 
  Font found: fonts/xPetitscript.ttf 
  Font found: fonts/xTypewriter.ttf 
  Font found: fonts/xUglyQua.ttf 
C:\Calibre\Novels\Aaa Zzz\Three Men in a Boat (Zelda) (3576)\Three Men in a Boat (Zelda) - Aaa Zzz.epub 
  Font found: OEBPS/fonts/Fontin-Bold.ttf 
  Font found: OEBPS/fonts/Fontin-Italic.ttf 
  Font found: OEBPS/fonts/Fontin-Regular.ttf 
C:\Calibre\Novels\Aaa Zzz\Font Embed MediciText (5034)\Font Embed MediciText - Aaa Zzz.epub 
  Font found: OEBPS/fonts/MediciText.ttf 
C:\Calibre\Novels\Aaa Zzz\Font Embed CelticEels (5035)\Font Embed CelticEels - Aaa Zzz.epub 
  Font found: OEBPS/fonts/CelticEels.ttf 
C:\Calibre\Novels\Aaa Zzz\DropCaps - CelticEels (5036)\DropCaps - CelticEels - Aaa Zzz.epub 
  Font found: fonts/CelticEels.ttf 
C:\Calibre\Novels\Aaa Zzz\EPUB FontEmbed (5705)\EPUB FontEmbed - Aaa Zzz.epub 
  Font found: fonts/monob.ttf 
  Font found: fonts/monobi.ttf 
  Font found: fonts/monoi.ttf 
  Font found: fonts/monor.ttf 
  Font found: fonts/sansb.otf 
  Font found: fonts/sansbi.otf 
  Font found: fonts/sansi.otf 
  Font found: fonts/sansr.otf 
  Font found: fonts/serifb.ttf 
  Font found: fonts/serifbi.ttf 
  Font found: fonts/serifi.ttf 
  Font found: fonts/serifr.ttf 
C:\Calibre\Novels\Aaa Zzz\Jellby ePub Reader Test v2 (5814)\Jellby ePub Reader Test v2 - Aaa Zzz.epub 
  Font found: OEBPS/Fonts/Lobster_1.4.otf 
  Font found: OEBPS/Fonts/Fontin-Italic.otf 
  Font found: OEBPS/Fonts/Fontin-Regular.otf 
  Font found: OEBPS/Fonts/FreeSans.otf 
  Font found: OEBPS/Fonts/SILEOT.ttf 
  Font found: OEBPS/Fonts/FreeSansOblique.otf 
  Font found: OEBPS/Fonts/LateefRegOT.ttf 
C:\Calibre\Novels\Stephen King\11-22-63 (5816)\11-22-63 - Stephen King.epub 
  Font found: ops/fonts/AldusLTStd-Italic.otf 
  Font found: ops/fonts/AldusLTStd-Roman.otf 
  Font found: ops/fonts/AlternateGothicNo2BTStd-Regular.otf 
  Font found: ops/fonts/AmericanTypewriterStd-Med.otf 
  Font found: ops/fonts/CalibanStd.otf 
  Font found: ops/fonts/CheltenhamStd-BoldCond.otf 
  Font found: ops/fonts/CheltenhamStd-BoldCondIt.otf 
  Font found: ops/fonts/CooperBlackStd-Italic.otf 
  Font found: ops/fonts/CooperBlackStd.otf 
  Font found: ops/fonts/EngraversLTStd-BoldFace.otf 
  Font found: ops/fonts/FrutigerLTStd-Black.otf 
  Font found: ops/fonts/FrutigerLTStd-Bold.otf 
  Font found: ops/fonts/Garamond3LTStd-Bold.otf 
  Font found: ops/fonts/Garamond3LTStd-BoldItalic.otf 
  Font found: ops/fonts/Garamond3LTStd-Italic.otf 
  Font found: ops/fonts/Garamond3LTStd.otf 
  Font found: ops/fonts/HelveticaInseratLTStd-Roman.otf 
  Font found: ops/fonts/HelveticaLTStd-Blk.otf 
  Font found: ops/fonts/HelveticaLTStd-BlkObl.otf 
  Font found: ops/fonts/HelveticaLTStd-Obl.otf 
  Font found: ops/fonts/HelveticaLTStd-Roman.otf 
  Font found: ops/fonts/MemphisLTStd-Bold.otf 
  Font found: ops/fonts/NewsGothicBTStd-Bold.otf 
  Font found: ops/fonts/NewsGothicBTStd-BoldCondensedItalic.otf 
  Font found: ops/fonts/NewsGothicBTStd-Italic.otf 
  Font found: ops/fonts/NewsGothicBTStd-Roman.otf 
  Font found: ops/fonts/StencilStd.otf 
  Font found: ops/fonts/TimesNewRomanMTStd-Bold.otf 
  Font found: ops/fonts/TimesNewRomanMTStd-BoldIt.otf 
  Font found: ops/fonts/TimesNewRomanMTStd-Italic.otf 
  Font found: ops/fonts/TimesNewRomanMTStd.otf 
  Font found: ops/fonts/TradeGothicLTStd-BdCn20.otf 
  Font found: ops/fonts/TradeGothicLTStd-BdCn20Obl.otf 
  Font found: ops/fonts/TradeGothicLTStd.otf 
ERROR parsing book:  None 
Traceback (most recent call last):
  File "calibre_plugins.quality_check.check_epub", line 816, in evaluate_book
  File "site-packages\calibre\utils\zipfile.py", line 751, in __init__
  File "site-packages\calibre\utils\zipfile.py", line 786, in _GetContents
  File "site-packages\calibre\utils\zipfile.py", line 797, in _RealGetContents
  File "site-packages\calibre\utils\zipfile.py", line 228, in _EndRecData
AttributeError: 'NoneType' object has no attribute 'seek'

Log if 'Check @font-face' option used:

Spoiler:

kiwidude · 05-04-2012, 06:04 PM

Looks like you have a corrupt ebook entry. And no it isn't the book you see in the log, it is the one"after" that. See in the error message where it says "ERROR parsing book: None"? That "None" is where it should be displaying the path to the ebook.

I think you need to run the library maintenance. I believe you have deleted the epub out of calibre's file system rather than using "remove format", so calibre thinks you have an epub but you don't for that particular book.

jackie_w · 05-04-2012, 06:23 PM

Quote:

Originally Posted by kiwidude

I think you need to run the library maintenance. I believe you have deleted the epub out of calibre's file system rather than using "remove format", so calibre thinks you have an epub but you don't for that particular book.

Yes! That was the problem, I don't know how I managed to do that. Thanks for that, I'll know what to do next time. Sorry to have bothered you.

kiwidude · 05-04-2012, 06:35 PM

No problem. It has highlighted an area I could improve in the error handling to make it easier to see exactly what the problem is, which I'll include in a future version.

kiwidude · 05-05-2012, 11:33 AM

Changes in this release:

Ensure a better error is displayed for books where the EPUB format has been deleted outside of calibre
Fix for Check unused image files to look for spaces in the file name, and handle namespaced images

CRussel · 05-06-2012, 06:15 PM

kiwidude -- Great plugin, not sure why I only recently discovered it. But now that I'm using it, I've found something I wish it did. Could you add a check to see if a MOBI book has an EBOK tag? (I hate sending something to my Kindle Fire, only to have it hide over in Documents instead of Books.) All my newer books are fine, but I'm periodically seeing the problem when I go to read an older book and forget to do a MOBI-to-MOBI convert.

Now, if you could actually fix it too, that would be awesome. But just being able to quickly check it would be worth having.

Thanks,

kiwidude · 05-06-2012, 07:15 PM

@CRussel - as you have perhaps noticed the plugin doesn't have any MOBI checks currently. It comes down to me knowing absolutely zero about the format. If someone (Kovid?) can point me towards the calibre code related to this EBOK tag stuff then I can take a look, but since I don't own a Fire myself its only going to happen if it is trivial to implement...

kovidgoyal · 05-06-2012, 10:46 PM

Its not absolutely trivial. IIRC going into the Books section of the Fire requires two things: 1) a cdetype of EBOK 2) the presence of an asin field both in the EXTH header.

Also, the Fire has been known to crash with a few MOBI files when they have non Amazon asin values.

But if you want to do the check, use the MetadataHeader class, you will have to make a couple of changes to the EXTH class to store the raw cdetype and asin values so you plugin can handle them. Easily acheived by subclassing EXTH. See metadata/mobi.py for examples of using MetadataHeader.

paulfiera · 05-07-2012, 04:18 AM

Quote:

Originally Posted by kiwidude

Changes in this release:

Fix for Check unused image files to look for spaces in the file name, and handle namespaced images

kiwidude, it looks like the plugin is flagging images with spaces in their file names. I don't know if it's all images or some.

05-04-2012, 03:14 PM	#366
kiwidude Calibre Plugins Developer Posts: 4,735 Karma: 2197770 Join Date: Oct 2010 Location: Australia Device: Kindle Oasis	v1.7.4 Released Changes in this release: Protect against a blank author field caused by a bug in the Manage Authors dialog in calibre Split the Check ePub submenu into two submenus for ease of usage and future expansion Add a "Check unused image files" option to the Check ePub Structure menu, to find books with jpeg/png image files that are not referenced and can be removed to save space Add a "Check TOC hierarchical" option to the Check ePub Structure menu, to find books with hierarchical TOC that need flattening for certain devices Add a "Check Adobe DRM meta tag" option to the Check ePub Structure menu, to find books with html files that contain Adobe <meta /> DRM identifiers Add a "Check Adobe inline .xpgt links" option to the Check ePub Style menu, to find books with html files that <link /> to a .xpgt file Add a "Check @font-face" option to the Check ePub Style menu, to find books with CSS or html files that contain @font-face declarations Add more information into the Help file for newcomers explaining some of the options. Thanks to those of you who tested the beta versions and offered feedback. Enjoy...

05-05-2012, 11:33 AM	#371
kiwidude Calibre Plugins Developer Posts: 4,735 Karma: 2197770 Join Date: Oct 2010 Location: Australia Device: Kindle Oasis	v1.7.5 Released Changes in this release: Ensure a better error is displayed for books where the EPUB format has been deleted outside of calibre Fix for Check unused image files to look for spaces in the file name, and handle namespaced images

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
[GUI Plugin] Search the Internet	kiwidude	Plugins	436	05-12-2025 09:02 PM
[GUI Plugin] Open With	kiwidude	Plugins	404	02-21-2025 05:42 AM
[GUI Plugin] Clipboard Search	kiwidude	Plugins	29	04-02-2024 10:05 PM
[GUI Plugin] Kindle Collections (old)	meme	Plugins	2070	08-11-2014 12:02 AM
[GUI Plugin] Book Sync Deprecated	kiwidude	Plugins	111	06-07-2011 07:47 PM

05-04-2012, 04:36 AM	#361
paulfiera Addict Posts: 387 Karma: 3102 Join Date: Dec 2010 Location: EU Device: Kobo Aura ONE, Kobo Libra H20	@kiwidude, when checking for @font-face or Adobe stuff, do you check every html file in the epub?

05-04-2012, 04:56 AM	#362
kiwidude Calibre Plugins Developer Posts: 4,735 Karma: 2197770 Join Date: Oct 2010 Location: Australia Device: Kindle Oasis	Yes. Every html file that is defined in the opf manifest. Have you found a scenario it does not work?

05-04-2012, 06:02 AM	#364
kiwidude Calibre Plugins Developer Posts: 4,735 Karma: 2197770 Join Date: Oct 2010 Location: Australia Device: Kindle Oasis	It already does that.

05-04-2012, 06:04 PM	#368
kiwidude Calibre Plugins Developer Posts: 4,735 Karma: 2197770 Join Date: Oct 2010 Location: Australia Device: Kindle Oasis	Looks like you have a corrupt ebook entry. And no it isn't the book you see in the log, it is the one"after" that. See in the error message where it says "ERROR parsing book: None"? That "None" is where it should be displaying the path to the ebook. I think you need to run the library maintenance. I believe you have deleted the epub out of calibre's file system rather than using "remove format", so calibre thinks you have an epub but you don't for that particular book.

05-04-2012, 06:35 PM	#370
kiwidude Calibre Plugins Developer Posts: 4,735 Karma: 2197770 Join Date: Oct 2010 Location: Australia Device: Kindle Oasis	No problem. It has highlighted an area I could improve in the error handling to make it easier to see exactly what the problem is, which I'll include in a future version.

05-06-2012, 06:15 PM	#372
CRussel (he/him/his) Posts: 12,322 Karma: 80074820 Join Date: Jul 2010 Location: Sunshine Coast, BC Device: Oasis (Gen3),Paperwhite (Gen10), Voyage, Paperwhite(orig), iPad Air M3	kiwidude -- Great plugin, not sure why I only recently discovered it. But now that I'm using it, I've found something I wish it did. Could you add a check to see if a MOBI book has an EBOK tag? (I hate sending something to my Kindle Fire, only to have it hide over in Documents instead of Books.) All my newer books are fine, but I'm periodically seeing the problem when I go to read an older book and forget to do a MOBI-to-MOBI convert. Now, if you could actually fix it too, that would be awesome. But just being able to quickly check it would be worth having. Thanks,

05-06-2012, 07:15 PM	#373
kiwidude Calibre Plugins Developer Posts: 4,735 Karma: 2197770 Join Date: Oct 2010 Location: Australia Device: Kindle Oasis	@CRussel - as you have perhaps noticed the plugin doesn't have any MOBI checks currently. It comes down to me knowing absolutely zero about the format. If someone (Kovid?) can point me towards the calibre code related to this EBOK tag stuff then I can take a look, but since I don't own a Fire myself its only going to happen if it is trivial to implement...

05-06-2012, 10:46 PM	#374
kovidgoyal creator of calibre Posts: 45,604 Karma: 28548974 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Its not absolutely trivial. IIRC going into the Books section of the Fire requires two things: 1) a cdetype of EBOK 2) the presence of an asin field both in the EXTH header. Also, the Fire has been known to crash with a few MOBI files when they have non Amazon asin values. But if you want to do the check, use the MetadataHeader class, you will have to make a couple of changes to the EXTH class to store the raw cdetype and asin values so you plugin can handle them. Easily acheived by subclassing EXTH. See metadata/mobi.py for examples of using MetadataHeader.