[GUI Plugin] Goodreads Sync

[kiwidude]

What are you actually trying to achieve? Do you have books on shelves in Goodreads already that you are populated a genre column in Calibre for, or are you trying to put books on Goodreads shelves based on their tags?

Looking at your mappings, you have multiple Calibre tags per genre. I wonder if you are making the mistake that someone else made recently on this thread of trying to use uploading to Goodreads as a way of "cleaning" their tags. You cannot do this. The way you have setup your mappings for a "short-stories" shelf to have tags of "Short Stories,short story". What this means if you were to download shelves as tags that a book on the "short-stories" shelf will get both tags applied to it in Calibre. The same works in reverse - this mapping is telling the plugin that a book must have both those tags on it for it to be uploaded onto the short-stories shelf.

Now in terms of your "mappable items" exactly what screen/field are you talking about? The edit shelf/tag mappings screen will let you create one set of mappings per goodreads shelf. If you have added a shelf using the goodreads website, click the refresh button to make sure it appears in the configuration dialog, click edit shelf/tag mappings, and then click the green + icon to add any shelves that exist on your account that are not currently listed in the mapping screen.

[potestus]

mappable items is the button below the sync items.
when pressed I only get 37 of the 24 items displayed.
ie politics, philosophy and on-the shelf do not appear on the "goodreadsd shelf/tag mappings screens.
they all exist in goodreads and calibre and refresh works fine.

so way is the mapping supposted to do then -
It seems to work ie all of these tags when uploaded to shelf are resolved to the one.

what do you suggest then?

If I try to add a ahelf that already exixts ie politics. I get an error
calibre, version 0.7.59
ERROR: Unhandled exception: <b>NameError</b>:global name 'error_dialog' is not defined

Traceback (most recent call last):
File "calibre_plugins.goodreads_sync.config", line 1066, in add_shelf
File "calibre_plugins.goodreads_sync.core", line 197, in create_shelf
File "calibre_plugins.goodreads_sync.core", line 105, in _oauth_request_post
File "calibre_plugins.goodreads_sync.core", line 139, in _handle_failure
NameError: global name 'error_dialog' is not defined


regards

[kiwidude]

@potestus - if you want me to help, please stop abbreviating and using your own terms for things and tell me the specific names of menu items/buttons etc you are clicking on. There is no "sync items" and there is no "mappable items" in this plugin. Do you mean the "Edit Shelf/Tag Mappings" button below the list of shelves in the customize dialog? Please be specific in future.

The error message is a bug I will push a fix for so thanks for reporting that.

As for how the mapping is supposed to work, I have already explained this several times on this thread. I am not going to repeat myself again. Read through the last few pages of this thread and the help file.

In terms of the behaviour you are seeing, I stand by my comments above. Yes a book which has tags of "Short stories, short story" will indeed appear on the "short-stories" shelf with the way you have set these up. However a book which has only the tag "Short stories" will not appear on the shelf when using upload tags as shelves, nor will a book which only has the tag "short story". Specifying multiple Calibre tags for a Goodreads shelf is saying there is a many to one relationship - they all must exist on the book for it to map to that shelf.

The example I keep using is having a shelf called "paranormal-romance" and Calibre tags mapped to it of "Paranormal, Romance". A book with just the "Romance" tag would not go onto that shelf - it is the exact same principle.

So if you want each and every one of the books for that shelf to have that complete same set of duplicated tags in Calibre you have setup currently then yes you could get that approach to "work". However I don't know why you would want to do that. As you have ignored my question asking exactly what it is you are trying to do then I can't suggest anything else.

As for your counts issue, I told you the solution above. If you have clicked the refresh button in the customize dialog, then all of your shelves will appear in the shelves list on that dialog, correct? Then when you click on Edit Shelf/Tag Mappings, you need to click on the green + button to the right to choose which additional shelves that you have added you want to create mappings for. They should then appear in the Goodreads Shelf column.

For when I push that bugfix version I may also just get rid of that second Add (plus) button and have it always list all of your shelves. At one point I had a delete button on there with the theory that you could permanently exclude shelves you had no interest in mapping, but that behaviour all got ripped out and it is probably simpler just to list all shelves for your account.

[kiwidude]

Changes in this release:

• Bugfix for correct error dialog not showing when have an error during Goodreads communication.
• Remove the add shelves button from the edit shelf tag mappings dialog. Always display all your shelves.
• When adding a shelf to the mapping list, default it to having no Calibre tags instead of a tag of the shelf name.

[potestus]

Fixed,
Thanks

[nynaevelan]

Kiwidude:

I get thefollowing error when I drag and drop a link in the add to shelf feature when the book is not linked. It does link the book but the error pops up each time.

calibre, version 0.8.0
ERROR: Unhandled exception: <b>TypeError</b>:arguments did not match any overloaded call:
QTableWidgetItem(int type=QTableWidgetItem.Type): argument 1 has unexpected type 'NoneType'
QTableWidgetItem(QString, int type=QTableWidgetItem.Type): argument 1 has unexpected type 'NoneType'
QTableWidgetItem(QIcon, QString, int type=QTableWidgetItem.Type): argument 1 has unexpected type 'NoneType'
QTableWidgetItem(QTableWidgetItem): argument 1 has unexpected type 'NoneType'

Traceback (most recent call last):
File "calibre_plugins.goodreads_sync.dialogs", line 766, in handle_search_for_goodreads_books
File "calibre_plugins.goodreads_sync.dialogs", line 556, in populate_table_row
File "calibre_plugins.goodreads_sync.common_utils", line 185, in __init__
TypeError: arguments did not match any overloaded call:
QTableWidgetItem(int type=QTableWidgetItem.Type): argument 1 has unexpected type 'NoneType'
QTableWidgetItem(QString, int type=QTableWidgetItem.Type): argument 1 has unexpected type 'NoneType'
QTableWidgetItem(QIcon, QString, int type=QTableWidgetItem.Type): argument 1 has unexpected type 'NoneType'
QTableWidgetItem(QTableWidgetItem): argument 1 has unexpected type 'NoneType'


Nyn

[kiwidude]

Changes in this release:

• Bugfix for no ISBN causing errors when adding to shelf

@Nyn - I'm not sure why this only showed up now but hopefully this version should fix the issue indicated from the call stack above. It is to do with the book not having an ISBN when it is being displayed on that link dialog. Though I haven't experienced this problem myself so I am curious - regardless, let me know if this fixes it.

[SheriW]

When I try to add the plug-in, Calibre won't allow me to access the .RAR file. I'm using Mac OSX 10.5.8.

[kiwidude]

What rar file? There is no rar file?

Welcome to MobileRead btw.

[SheriW]

This is the first file I came across: File Type: rar Goodreads Sync.rar (1.2 KB, 5 views) I should have kept looking. Sorry, that was stupid of me.

[kiwidude]

Ahh, now I understand, no problem. I've just edited that other user's post to remove their attachment to prevent any future confusion. Yes the plugin is always downloaded from the very first post in the thread. An even better way is to install the Plugin Updater plugin - do that once and from then on you have a simple GUI within Calibre to find and install plugins and updates rather than manually downloading them.

[MykelAlvis]

First of all, thanks for the plugin. As far as I can tell from the documentation and the posts here, it seems to have exceeded expectations.

Of course, that's only through reading about it. I can't seem to get it to operate. I click the button that says "Authorize Plugin with Goodreads" and it pops up a dialog asking me if I clicked "allow access". From what I can tell from the documentation, there should be a web connection to goodreads that pops up and asks me to confirm. However, I have no such connection.

I've updated my OS completely, running the latest Calibre (0.8.0) and I installed the goodreads plugin with the plugin manager, so I'm fairly sure I'm up-to-date.

uname -a:
Linux ramses.ainom.net 2.6.35.12-90.fc14.x86_64 #1 SMP Fri Apr 22 16:01:29 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux

yum info python:
Installed Packages
Name : python
Arch : x86_64
Version : 2.7
Release : 8.fc14.1
Size : 22 M
Repo : installed

I'm running calibre in KDE 4.

Is there something else I need to be doing/installing?

[kiwidude]

I don't run Linux myself so I'm afraid I'm not going to be much help. You should be seeing your default webbrowser being opened with a url. I know nothing about configuring a default webbrowser under Linux (google may be your friend). Perhaps a proxy issue?

If you put these two lines into a test.py file

import webbrowser
webbrowser.open('http://www.goodreads.com/')

Then type the equivalent of this from a shell prompt (I don't know if/how this varies for linux, I'm a Windows guy):

calibre-debug -e test.py

If that works, there should be no reason why the authentication page for goodreads shouldn't work. There is another option I have for opening the web pages using some Calibre wrapped code rather than python directly. Tell me if this works for you in comparison to the above:

from calibre.gui2 import open_url
from PyQt4.Qt import QUrl
open_url(QUrl('http://www.goodreads.com/'))

[MykelAlvis]

The first code had no effect. Apparently webbrowser.open doesn't work in calibre-debug for me.

The second was a success! My default browser opened to goodreads, as expected.

As an item of further interest, webbrowser.open works fine in standard python. The issue appears to have something to do with Calibre's python environment. Unfortunately, I don't have a 32-bit linux installation to test this on at the moment, so I can't see if it's a 64-bit issue (a common and extremely unfortunate circumstance). However, I'm supposed to create one this week. I'll try this same code on that instance.

[kiwidude]

Changes in this release:

• Change all webbrowser launching to use Calibre's wrapper for the default browser for better Linux support

@MykelAlvis - give this version a go and let me know how you get on.