![]() |
#16 | |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 12,447
Karma: 8012886
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
|
Quote:
![]() There is a change in .18 that causes the behavior you see. To fix several ondevice display problems, I needed to refresh the GUI screen, so I did. Unfortunately, the way I did the refresh sorted by only the last sort, not the sequence of sorts. Worrying about longer sort sequences didn't occur to me, even though it should have because it was required for the sort_on_startup feature I added. What you are seeing is the result. The display should be sorted by series, but the order of the other columns will be indeterminate. Actually, they are in DB order, but that is effectively the same thing. ![]() I am submitting code to fix this. In the meantime, revert to .17. |
|
![]() |
![]() |
![]() |
#17 | |
US Navy, Retired
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 9,897
Karma: 13806776
Join Date: Feb 2009
Location: North Carolina
Device: Icarus Illumina XL HD, Kindle PaperWhite SE 11th Gen
|
Quote:
![]() |
|
![]() |
![]() |
![]() |
#18 |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 4,004
Karma: 177841
Join Date: Dec 2009
Device: WinMo: IPAQ; Android: HTC HD2, Archos 7o; Java:Gravity T
|
When Kovid adds it to the main trunk, would you post a note here, or just post the bug fix#. I'd like to fix this while running from code. Related question - do all your code mods get added to the bug list, or do you send some directly to Kovid? IOW, if I watch the bug tracker do I see all your proposed code changes?
|
![]() |
![]() |
![]() |
#19 | ||
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 12,447
Karma: 8012886
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
|
Quote:
Quote:
The changes are all in the BZR log/repository, complete with some commentary. That would be the best place to look. I check it reasonably frequently to see what other people are up to. Kovid seems to leave the developer's name attached to the merge directives, even if he changes the code. If you use the BZR GUI, then you would need to click on a '+' circle or two until you see the string of commits you are interested in. |
||
![]() |
![]() |
![]() |
#20 |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 2,157
Karma: 7068605
Join Date: Dec 2007
Device: Amazon Kindle Paperwhite, B&N Nook Colro
|
THANK YOU!!! I didn't think I was crazy, I knew something had to have changed...but I bow down to you for figuring this out.
![]() ![]() ![]() |
![]() |
![]() |
![]() |
#21 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 12,447
Karma: 8012886
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
|
|
![]() |
![]() |
![]() |
#22 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 12,447
Karma: 8012886
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
|
NB: Kovid is concerned that the bug fix will unacceptably reduce performance for those who don't use multi-level sorts. To deal with this, I have added YAT (yet another tweak) to limit the number of remembered sorts to apply.
Tweak documentation is: Code:
# Set the maximum number of sort 'levels' that calibre will use to resort the # library after certain operations such as searches or device insertion. Each # sort level adds a performance penalty. If the database is large (thousands of # books) the penalty might be noticeable. If you are not concerned about multi- # level sorts, and if you are seeing a slowdown, reduce the value of this tweak. maximum_resort_levels = 5 |
![]() |
![]() |
![]() |
#23 |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 4,004
Karma: 177841
Join Date: Dec 2009
Device: WinMo: IPAQ; Android: HTC HD2, Archos 7o; Java:Gravity T
|
|
![]() |
![]() |
![]() |
#24 |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 2,157
Karma: 7068605
Join Date: Dec 2007
Device: Amazon Kindle Paperwhite, B&N Nook Colro
|
so how would I implement this?
|
![]() |
![]() |
![]() |
#25 |
US Navy, Retired
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 9,897
Karma: 13806776
Join Date: Feb 2009
Location: North Carolina
Device: Icarus Illumina XL HD, Kindle PaperWhite SE 11th Gen
|
|
![]() |
![]() |
![]() |
#26 |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 2,157
Karma: 7068605
Join Date: Dec 2007
Device: Amazon Kindle Paperwhite, B&N Nook Colro
|
Yeah sounds like a plan, I've got no idea how to run it from source
|
![]() |
![]() |
![]() |
#27 | |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 12,447
Karma: 8012886
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
|
Quote:
Both the GUI and the content server use this new code. Could those of you who run from source give it a try? I don't think anything is broken, but more use will give reassurance. |
|
![]() |
![]() |
![]() |
#28 |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 4,004
Karma: 177841
Join Date: Dec 2009
Device: WinMo: IPAQ; Android: HTC HD2, Archos 7o; Java:Gravity T
|
|
![]() |
![]() |
![]() |
#29 |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 2,157
Karma: 7068605
Join Date: Dec 2007
Device: Amazon Kindle Paperwhite, B&N Nook Colro
|
So do I need to download the 7.18 again?
Thanks!! |
![]() |
![]() |
![]() |
#30 |
US Navy, Retired
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 9,897
Karma: 13806776
Join Date: Feb 2009
Location: North Carolina
Device: Icarus Illumina XL HD, Kindle PaperWhite SE 11th Gen
|
I know it gets confusing, they are testing it by running from source code that already has the fix in it, not by running a new version of 0.7.18. It sounds like the fix will be in the next release.
|
![]() |
![]() |
![]() |
|
![]() |
||||
Thread | Thread Starter | Forum | Replies | Last Post |
delete old books after adding | iconeo | Calibre | 4 | 05-21-2010 01:03 AM |
Adding new books problem | Flub | Calibre | 6 | 12-24-2009 11:39 AM |
Adding empty books | vbussell | Calibre | 4 | 12-10-2009 05:42 PM |
Adding books without a copy | Sanderfox | Calibre | 5 | 12-02-2009 02:32 PM |
Help with adding books please | stustaff | Calibre | 12 | 10-27-2009 02:30 PM |