Plugin test with mtp

[edward.81]

Just doing some experiment but i get a little confused from this:

from calibre.devices.mtp.driver import MTP_DEVICE

class MYSYNC(MTP_DEVICE):
    name                = 'Android Sync' # Name of the plugin
    description         = 'bla bla bla'
    supported_platforms = ['windows', 'linux'] # Platforms this plugin will run on
    author              = 'dontlookhere' # The author of this plugin
    version             = (0, 1, 0)   # The version number of this plugin
    minimum_calibre_version = (0, 7, 53)

This is the little code. I try to make a plugin that extend mtp for my device. I don't know is is possible but if i try to load the plugin:

calibre-customize -b mine/

I get this error:

Traceback (most recent call last):
  File "/usr/bin/calibre-customize", line 20, in <module>
    sys.exit(main())
  File "/usr/lib/calibre/calibre/customize/ui.py", line 662, in main
    build_plugin(opts.build_plugin)
  File "/usr/lib/calibre/calibre/customize/ui.py", line 624, in build_plugin
    plugin = add_plugin(t.name)
  File "/usr/lib/calibre/calibre/customize/ui.py", line 382, in add_plugin
    'A builtin plugin with the name %r already exists' % plugin.name)
calibre.customize.ui.NameConflict: A builtin plugin with the name u'MTP Device Interface' already exists

I'm doing something wrong ? I have my ""luck"" has found a bug?

[kovidgoyal]

You cannot inherit from a builtin driver class like that. The plugin loading system has no way to know which is the driver class, MTP_DEVICE or MSYNC

You need to inherit from the DevicePlugin class instead.

If you really want to inherit from MTP_DEVICE then create a driver.py file in your plugin and do it in that, then simply import MSYNC into __init__.py like this

from calibre_plugins.my_plugin_import_name.driver import MSYNC

[kovidgoyal]

And this commit should allow your __init__.py to work as well

https://github.com/kovidgoyal/calibr...a9f681b2234426

[edward.81]

Originally Posted by kovidgoyal

You cannot inherit from a builtin driver class like that. The plugin loading system has no way to know which is the driver class, MTP_DEVICE or MSYNC

You need to inherit from the DevicePlugin class instead.

If you really want to inherit from MTP_DEVICE then create a driver.py file in your plugin and do it in that, then simply import MSYNC into __init__.py like this

from calibre_plugins.my_plugin_import_name.driver import MSYNC

Got it thanks !

Originally Posted by kovidgoyal

And this commit should allow your __init__.py to work as well

https://github.com/kovidgoyal/calibr...a9f681b2234426

Simply awesome !