KPV: a PDF reader for Kindle, based on muPDF, GPLv3

[h1uke]

Originally Posted by NuPogodi

Does anybody like the filechooser to look that way?

any special handling of long file names which do not fit?
I'd say this is more important than the beautification of any kind.
Nice icons are good to have, but some practical needs still
remain, and should be covered...

[NuPogodi]

To say the truth, I see no reasonable way to handle long filenames. To begin with, I've just implemented the simplest one - reducing the filename length till it fits the page width (see screenshots of the same folder at two orientations, i.e. various page widths)

If you have better idea, please, do not hesitate to share it here.

[dpavlin]

Originally Posted by NuPogodi

Does anybody like the filechooser to look in that way?

Looks nice, but I would rather have keyboard shortcuts instead of icons. We do poor job of displaying longer filenames already since we don't have scroll left-right feature which Kindle framework does.

Do you have some code to share? We can put keyboard shortcuts on top of icons in new ui rewrite if I'm not mistaken (right now text always have white background)

OOH, icons help, especially if you have two formats of same book and don't see file extension :-)

[dave2008]

Originally Posted by NuPogodi

To say the truth, I see no reasonable way to handle long filenames. To begin with, I've just implemented the simplest one - reducing the filename length till it fits the page width (see screenshots of the same folder at two orientations, i.e. various page widths)

If you have better idea, please, do not hesitate to share it here.

We have menu that handles long item names in the new UI framework:



Press right arrow key in a item will pop up a message box to show a full name. How about that?

[NuPogodi]

Originally Posted by dpavlin

Do you have some code to share? We can put keyboard shortcuts on top of icons in new ui rewrite if I'm not mistaken (right now text always have white background)

1. Are you mocking about hiding icons by white-backgrounded text? To show icons, I've used a function similar to FrameContainer with HorisontalGroup consisted of 1) ImageWidget /the icons are plain png-files/, 3) TextWidget /filenames/ and 2) empty Widget to define a gap in-between. So, one may load, do not load or just replace icons by something else (say, text prompts for corresponding keycode to run the item).

Originally Posted by dpavlin

Do you have some code to share?

2. As far as I understood, new UI (mentioned by Dave) already solved the problem. If not, I may of cause post a link to modified filechooser.lua and widget.lua.

Originally Posted by dave2008

We have menu that handles long item names in the new UI framework... Press right arrow key in a item will pop up a message box to show a full name. How about that?

3. Well, i did not know the new UI-widget splits long strings. In my kdpf-version (April.2), the one-line info appears only if the string is not too long. My naive attempts to split long lines with "\n" just failed.
4. If it does handle strings with few lines, I'd rather add to this info-window some other useful details (filesize; date; eventually, percents of read text for those files that has already been opened in kpdfviewer, etc)

[eLiNK]

Originally Posted by dave2008

We have menu that handles long item names in the new UI framework:



Press right arrow key in a item will pop up a message box to show a full name. How about that?

Suboptimal.
Clearly, it would be a useful feature. Because apart from the name of the file you could get an additional information on the file size, creation date, number of pages and the like.

But for long file names, a two-liner would be great and in my view really necessary.

[eLiNK]

Originally Posted by NuPogodi

Does anybody like the filechooser to look in that way?

I'm all for bells and whistles as long as practical considerations are not ignored.

But it looks real' gooood.

[dave2008]

Originally Posted by NuPogodi

2. As far as I understood, new UI (mentioned by Dave) already solved the problem. If not, I may of cause post a link to modified filechooser.lua and widget.lua.

The new UI framework is under developing in another branch and I guess it will not be merged to the main branch in the near future. So I think hacking on current filechooser is still necessary.

Originally Posted by NuPogodi

3. Well, i did not know the new UI-widget splits long strings. In my kdpf-version (April.2), the one-line info appears only if the string is not too long. My naive attempts to split long lines with "\n" just failed.

Yes, "\n" wont work here. To draw another line, you need to manually call renderUtf8Text with new offset of next line.

Originally Posted by NuPogodi

4. If it does handle strings with few lines, I'd rather add to this info-window some other useful details (filesize; date; eventually, percents of read text for those files that has already been opened in kpdfviewer, etc)

Yes, and also buttons in the message box to allow for simple file manipulations

[dave2008]

Originally Posted by eLiNK

Suboptimal.
Clearly, it would be a useful feature. Because apart from the name of the file you could get an additional information on the file size, creation date, number of pages and the like.

But for long file names, a two-liner would be great and in my view really necessary.

Agree, two lines should meet most of the cases. If the file name is longer than two line, then it should be considered for renaming

[NuPogodi]

Originally Posted by dave2008

So I think hacking on current filechooser is still necessary.

Link to zip with updated lua-files & some icons.
ATM, long files are splitted by "...", the keys KEY_I and KEY_FW_RIGHT result in a simple popup-window with filesize & date (just for demo purposes).

[eLiNK]

Originally Posted by NuPogodi

Link to zip with updated lua-files & some icons.
ATM, long files are splitted by "...", the keys KEY_I and KEY_FW_RIGHT result in a simple popup-window with filesize & date (just for demo purposes).

the icons are missing in the filesearcher.

[NuPogodi]

Originally Posted by eLiNK

the icons are missing in the filesearcher.

Oh, I've just forgotten to include updated filesearcher.lua. The result looks like:

PS. KEY_I -> File Information (the same command & window as in filechooser)

[pol01]

Originally Posted by dave2008

We have menu that handles long item names in the new UI framework:



Press right arrow key in a item will pop up a message box to show a full name. How about that?

May be it should better to use fixed length string to show long file name by default and let user to enable this message box in settings?

Dave2008 the "duokan style" file browser will be realized in the new UI framework. Am I right?

[SP777]

One more idea. Is it possible to make a continues page view like in the desktop Adobe Reader? This means: when the previous page ends, you see the top of the next page on the same screen. Both modes (with and without margins) would be useful.

[dpavlin]

Originally Posted by SP777

One more idea. Is it possible to make a continues page view like in the desktop Adobe Reader? This means: when the previous page ends, you see the top of the next page on the same screen. Both modes (with and without margins) would be useful.

I was thinking about same thing, but it would take a while because we first have to migrate to new UI framework (which will hopefully bring some support for non-keyboard kindles, I hope ;-)