OPDS Client fails with calibre 5.38.0

[PiperKev]

This morning I upgraded calibre to the latest version, 5.38.0. After restarting, I attempted to invoke the OPDS Client plugin, and it failed with a "KeyError: 'Server'" error. I restarted calibre in debug mode and produced the attached log file.

After reinstalling calibre 5.37.0, the plugin worked as normal.

Has anyone noted any issues with 5.38?

Cheers,
Kevin

[DNSB]

At a wild eyed guess, that plugin has not been updated to Python 3.

Take a look at model.py where you see import urllib2 and then later where you see lines starting with calibreRestSearchResponse = urllib2.urlopen(. urllib2 is deprecated in Python 3.

Edit: I had a bit of time to kill so I ran 2to3 (convert python2 code to python3 code) against the .py files for the plugin and added the modified files to a zip archive. The resultant plugin comes up asking which tool bars to show in and after a restart, the configuration dialog shows when I click on the icon. When I have the calibre server running on port 8080 and open the OPDS client, I can see the various selection options and libraries, etc. If I remove the checkmark on Hide books already in library, I can see the books. Since I am looking at the existing libraries, this is a bit useless other than for testing.

[PiperKev]

The plugin was actually updated to Python 3 about a year and a half ago in response to calibre releasing version 5, which also went to Python 3. The author of the plugin did work to make it compatible, and it's worked on every iteration of calibre 5 until 5.38, which changed something under the dashboard and broke it.

[kovidgoyal]

That will be be because feedparser bundled with calibre is updated to version 6. If the plugin needs version 5 it should use its own private copy.

[PiperKev]

Thanks, Kovid! I'll add your info to my GitHub issue on the plugin!

[DNSB]

Originally Posted by PiperKev

The plugin was actually updated to Python 3 about a year and a half ago in response to calibre releasing version 5, which also went to Python 3. The author of the plugin did work to make it compatible, and it's worked on every iteration of calibre 5 until 5.38, which changed something under the dashboard and broke it.

My bad. I was looking at the version from goodlibs' GitHub site.

[PiperKev]

The author pushed a fixed version that now works with calibre 5.38.0.

https://github.com/steinarb/opds-reader

[DNSB]

Originally Posted by PiperKev

The author pushed a fixed version that now works with calibre 5.38.0.

https://github.com/steinarb/opds-reader

I've already picked up that one. After realizing that I'd look at the wrong version, I went to the 2nd Google search result. Sadly, the version from there still gives the following:

Spoiler:

calibre, version 5.38.0
ERROR: Unhandled exception: <b>KeyError</b>:'server'

calibre 5.38 [64bit]  embedded-python: True is64bit: True
Windows-10-10.0.22000 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.22000')
Python 3.8.5
Windows: ('10', '10.0.22000', '', 'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: DeACSM (0, 0, 15) && DeDRM (10, 0, 2) && Annotations (1, 16, 0) && Baen (1, 2, 0) && Barnes & Noble (1, 2, 16) && Calibre Power Search Plugin (2, 1, 2) && Count Pages (1, 11, 2) && Diaps Editing Toolbag (0, 3, 7) && EpubCheck (0, 2, 4) && EpubMerge (2, 12, 0) && EpubSplit (3, 2, 0) && FanFicFare (4, 10, 0) && Fantastic Fiction (1, 5, 1) && Find Duplicates (1, 9, 4) && Goodreads (1, 5, 3) && Goodreads Sync (1, 15, 1) && Hyphenate This! (0, 1, 3) && ISFDB (3, 0, 0) && Job Spy (1, 0, 190) && KePub Output (3, 5, 3) && Kindle hi-res covers (0, 5, 0) && KindleUnpack - The Plugin (0, 83, 1) && Kobo Books (1, 8, 4) && Kobo Utilities (2, 15, 1) && KoboTouchExtended (3, 5, 4) && Modify ePub (1, 7, 0) && OPDS Client (1, 0, 0) && Obok DeDRM (10, 0, 0) && Open With (1, 7, 0) && Quality Check (1, 12, 1) && Resize Cover (1, 1, 0) && ScrambleEbook (0, 4, 5) && SmartEject (2, 4, 0) && Smashwords Metadata (1, 0, 2)
Traceback (most recent call last):
  File "calibre_plugins.opds_client.ui", line 24, in show_dialog
  File "calibre_plugins.opds_client.main", line 68, in __init__
  File "calibre_plugins.opds_client.model", line 78, in downloadOpdsRootCatalog
KeyError: 'server'

[PiperKev]

Originally Posted by DNSB

I've already picked up that one. After realizing that I'd look at the wrong version, I went to the 2nd Google search result. Sadly, the version from there still gives the following:

Spoiler:

calibre, version 5.38.0
ERROR: Unhandled exception: <b>KeyError</b>:'server'

calibre 5.38 [64bit]  embedded-python: True is64bit: True
Windows-10-10.0.22000 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.22000')
Python 3.8.5
Windows: ('10', '10.0.22000', '', 'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: DeACSM (0, 0, 15) && DeDRM (10, 0, 2) && Annotations (1, 16, 0) && Baen (1, 2, 0) && Barnes & Noble (1, 2, 16) && Calibre Power Search Plugin (2, 1, 2) && Count Pages (1, 11, 2) && Diaps Editing Toolbag (0, 3, 7) && EpubCheck (0, 2, 4) && EpubMerge (2, 12, 0) && EpubSplit (3, 2, 0) && FanFicFare (4, 10, 0) && Fantastic Fiction (1, 5, 1) && Find Duplicates (1, 9, 4) && Goodreads (1, 5, 3) && Goodreads Sync (1, 15, 1) && Hyphenate This! (0, 1, 3) && ISFDB (3, 0, 0) && Job Spy (1, 0, 190) && KePub Output (3, 5, 3) && Kindle hi-res covers (0, 5, 0) && KindleUnpack - The Plugin (0, 83, 1) && Kobo Books (1, 8, 4) && Kobo Utilities (2, 15, 1) && KoboTouchExtended (3, 5, 4) && Modify ePub (1, 7, 0) && OPDS Client (1, 0, 0) && Obok DeDRM (10, 0, 0) && Open With (1, 7, 0) && Quality Check (1, 12, 1) && Resize Cover (1, 1, 0) && ScrambleEbook (0, 4, 5) && SmartEject (2, 4, 0) && Smashwords Metadata (1, 0, 2)
Traceback (most recent call last):
  File "calibre_plugins.opds_client.ui", line 24, in show_dialog
  File "calibre_plugins.opds_client.main", line 68, in __init__
  File "calibre_plugins.opds_client.model", line 78, in downloadOpdsRootCatalog
KeyError: 'server'

That's strange, because it's working fine for me with 5.38. Before I updated calibre, I removed the plugin and restarted. When I was sure it was gone, I updated to 5.38. I followed the instructions on GitHub to clone the repository and install it. Works perfectly!

[DNSB]

Originally Posted by PiperKev

That's strange, because it's working fine for me with 5.38. Before I updated calibre, I removed the plugin and restarted. When I was sure it was gone, I updated to 5.38. I followed the instructions on GitHub to clone the repository and install it. Works perfectly!

I removed the old version, restarted calibre and then installed the new version. I'll give it another try,

Edit: My default is to have the content server user/password protected. I had to disable authentication for the plugin to work.