![]() |
#1 |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 1,208
Karma: 1419583
Join Date: Dec 2016
Location: Goiânia - Brazil
Device: iPad, Kindle Paperwhite, Kindle Oasis
|
Tag browser flickering
I'm using calibre 6.23 on Windows 11, dark mode.
Calibre uses a dark background and light font (probably a light gray). But, when you expand some items on the Tag Browser, most of the text of the items below this one flicks, becoming black and then going back to the light font. This flickering does not happen when using light mode. Last edited by thiago.eec; 07-20-2023 at 04:10 PM. Reason: typo |
![]() |
![]() |
![]() |
#2 | |
null operator (he/him)
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 21,708
Karma: 29711016
Join Date: Mar 2012
Location: Sydney Australia
Device: none
|
Quote:
Which items? Did you try changing the Look & feel->Main interface->User interface style from calibre-style to System-style (or vice versa)? That's the first setting on that dialogue. BR |
|
![]() |
![]() |
Advert | |
|
![]() |
#3 |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 1,208
Karma: 1419583
Join Date: Dec 2016
Location: Goiânia - Brazil
Device: iPad, Kindle Paperwhite, Kindle Oasis
|
Yes. Just tested here on 4.23 portable. I only noticed now because I removed all my tags and started from scratch, using hierarchical tags.
Most of them. See the video attached. It happens both in calibre style and system style. |
![]() |
![]() |
![]() |
#4 |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 2,181
Karma: 8888888
Join Date: Jun 2010
Device: Kobo Clara HD,Hisence Sero 7 Pro RIP, Nook STR, jetbook lite
|
I can reproduce in dark mode, linux mint 21.2. My best guess would that it is something in qt with dark mode.
bernie |
![]() |
![]() |
![]() |
#5 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 12,416
Karma: 8012664
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
|
@kovid: this seems to be caused by the adjustment for dark theme when painting highlighted (hovered) tag browser labels done in gui2.library.views.paint_text at line 70. According to my experiments (on Windows) the painter must have a correct dark mode pen set if the item is not being highlighted. If the pen is not set then Qt seems to use a black pen, which is replaced later the correct color.
I pushed a PR with my fix. I freely admit that I might have broken something, but I don't see anything. It is also possible that the non-hover pen should be something other than Qt.GlobalColor.white. Finally, it is possible that this should be done in a style sheet somewhere instead of in code. |
![]() |
![]() |
Advert | |
|
![]() |
#6 |
creator of calibre
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 45,318
Karma: 27111242
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
|
Your fix is fine except that it should use window-text rather than white.
|
![]() |
![]() |
![]() |
#7 |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 1,208
Karma: 1419583
Join Date: Dec 2016
Location: Goiânia - Brazil
Device: iPad, Kindle Paperwhite, Kindle Oasis
|
Thanks @chaley and @kovid. All good now!
|
![]() |
![]() |
![]() |
|
![]() |
||||
Thread | Thread Starter | Forum | Replies | Last Post |
Tag Browser | chicleeblair | Library Management | 29 | 09-13-2023 12:02 PM |
Lost tag in tag browser | Goldwinger5566 | Library Management | 2 | 10-09-2021 03:54 PM |
How to stop Tag Browser, Details and Cover Browser from showing on startup? | stuartro | Calibre | 1 | 08-15-2016 11:53 PM |
Sorting tag values in tag browser | mcam | Library Management | 15 | 08-25-2013 05:50 AM |
Tag Browser | Lady Fitzgerald | Library Management | 2 | 07-17-2012 11:54 PM |