Resolved: Calibre 3.3 AttributeError: 'NoneType' object has no attribute

[DoctorOhh]

Resolved by removing then reinstalling calibre. (placing Resolved in the title and post #4 may not have been enough last night at 5:38am so for future onlookers here it is in red)

After updating to calibre portable 3.3, I manually downloaded metadata twice for 2 separate books recently added to calibre. Each time upon clicking OK I got the error, AttributeError: 'NoneType' object has no attribute 'refill_quickview'. Best I can tell all of the metadata was updated and calibre keeps on ticking. Any idea what is causing this error message?

Update: Simply opening the edit metadata window for any book then clicking OK produces the error on any book.

Spoiler:

calibre, version 3.3.0
ERROR: Unhandled exception: <b>AttributeError</b>:'NoneType' object has no attribute 'refill_quickview'

calibre 3.3 Portable embedded-python: True is64bit: False
Windows-10-10.0.15063-SP0 Windows ('32bit', 'WindowsPE')
32bit process running on 64bit windows
('Windows', '10', '10.0.15063')
Python 2.7.12+
Windows: ('10', '10.0.15063', 'SP0', u'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: DeDRM (6, 3, 6) && KFX Output (1, 8, 0) && Kindle covers (G) (0, 3, 0) && FictionDB (1, 0, 10) && EpubMerge (2, 1, 1) && Count Pages (1, 8, 0) && Fantastic Fiction Adults (1, 0, 4) && FanFicFare (2, 14, 0) && Goodreads Sync (1, 10, 1) && Modify ePub (1, 3, 13) && SmartEject (2, 0, 7) && ScrambleEbook (0, 0, 5) && Walk Search History (1, 3, 1) && Reading List (1, 6, 6) && Fantastic Fiction (1, 2, 0) && KindleUnpack - The Plugin (0, 81, 4) && Goodreads (1, 1, 12) && Quality Check (1, 9, 11) && Quick Preferences (1, 4, 1) && Audit Log (1, 0, 7) && Extract ISBN (1, 4, 4) && Open With (1, 5, 10) && EpubCheck (0, 1, 2) && EpubSplit (2, 2, 1) && Find Duplicates (1, 6, 3) && Generate Cover (1, 5, 21) && Barnes & Noble (1, 2, 14) && Search The Internet (1, 7, 6) && Manage Series (1, 2, 8) && View Manager (1, 4, 3) && Resize Cover (1, 0, 2) && Favourites Menu (1, 0, 4)
Traceback (most recent call last):
File "site-packages\calibre\gui2\actions\edit_metadata.py", line 306, in edit_metadata
File "site-packages\calibre\gui2\actions\edit_metadata.py", line 337, in edit_metadata_for
File "site-packages\calibre\gui2\actions\edit_metadata.py", line 353, in refresh_books_after_metadata_edit
AttributeError: 'NoneType' object has no attribute 'refill_quickview'

[kovidgoyal]

Looks like it is related to the Quickview changes, you will have to wait for chaley to comment.

[chaley]

Originally Posted by kovidgoyal

Looks like it is related to the Quickview changes, you will have to wait for chaley to comment.

@kovid: that exception is happening because the Quickview plugin is "initialized" but the "actual_plugin_" is not. Apparently either "load_actual_plugin" is not being called or the plugin is being initialized a second time. Any idea how can this happen?

[DoctorOhh]

Originally Posted by chaley

@kovid: that exception is happening because the Quickview plugin is "initialized" but the "actual_plugin_" is not. Apparently either "load_actual_plugin" is not being called or the plugin is being initialized a second time. Any idea how can this happen?

Since the answer wasn't quickly obvious and it seemed to only affect me. I removed everything in the calibre folder, re-downloaded calibre and installed again. The mysterious error has now gone away. Thanks for taking the time to ponder this mystery.

[chaley]

I pushed code to protect against this strange thing happening again. The code also removes a regression that left the QV column headings empty.

@DoctorOhh: do you use QV? If so, have you tried changing the preference (Preferences / Look & Feel / Quickview) for which columns are shown in the QV window?

[kovidgoyal]

Originally Posted by chaley

@kovid: that exception is happening because the Quickview plugin is "initialized" but the "actual_plugin_" is not. Apparently either "load_actual_plugin" is not being called or the plugin is being initialized a second time. Any idea how can this happen?

Not really, from looking at the code in ui.py it should not be possible.

[BetterRed]

Originally Posted by chaley

[. . .] have you tried changing the preference (Preferences / Look & Feel / Quickview) for which columns are shown in the QV window?

Took me a while to find it, I've had a quick look, see attachment - looks good.

Some observations:

Would be nice if the columns could be dragged around a'la the Book List, would not want changes to persists.

When docked, with no tag browser shown, the left edge could do with margin, see attachment

When panel is not docked, the panel has three ways to dismiss it - red X top right, a Close button, and via the Layout button, whereas when its docked there's only one - via the Layout button. This seems 'inconsistent' to me, either keep the Close button when docked or get rid of it altogether.

Now that QV has become a Layout feature could it have a keyboard shortcut toggle that is consistent with the other Layout features - i.e Miscellaneous->Toggle Quick View.

Other :

Am I right in observing that version 3.3 lost the default kb shorts for Toggle Tag Browser (Alt+Shift+T), Toggle Book Details (Alt+Shift+D) etc - I can't recall, or imagine, I would have set them to 'None'. No biggie for me 'cos I change them anyway.

Would be nice if the Job Details panel could be docked.

BR

[BetterRed]

@chaley - PS : I've not had the errors DoctorOhh reported

And maybe you could help out here

BR

[chaley]

Originally Posted by BetterRed

Some observations:

Would be nice if the columns could be dragged around a'la the Book List, would not want changes to persists.

That is more work than I want to do.

When docked, with no tag browser shown, the left edge could do with margin, see attachment

You are right. The problem isn't there when the tag browser is open. I will add a few pixels.

When panel is not docked, the panel has three ways to dismiss it - red X top right, a Close button, and via the Layout button, whereas when its docked there's only one - via the Layout button. This seems 'inconsistent' to me, either keep the Close button when docked or get rid of it altogether.

I see no reason to add the close button to the docked version. I have no problem removing the "X" window close icon, but I suspect that many others won't agree with that. I also have no problem with removing the close button altogether. In both cases my willingness is moderated by the fact that I am generally not in favor of changes that seem entirely gratuitous, especially if they break "muscle memory".

There is also the problem that keyboard users would no longer have ALT+C to close the window.

For the moment I will do nothing.

Now that QV has become a Layout feature could it have a keyboard shortcut toggle that is consistent with the other Layout features - i.e Miscellaneous->Toggle Quick View.

It does have a shortcut. The default Q toggles quickview. The one that is missing is focus back to the book list from quickview. I agree that the label "Show Quickview" should be "Toggle Quickview".

Other :

Am I right in observing that version 3.3 lost the default kb shorts for Toggle Tag Browser (Alt+Shift+T), Toggle Book Details (Alt+Shift+D) etc - I can't recall, or imagine, I would have set them to 'None'. No biggie for me 'cos I change them anyway.

Those shortcuts work for me, and are indicated in Preferences as the default.

Would be nice if the Job Details panel could be docked.

BR

That would be up to Kovid.

[chaley]

Originally Posted by BetterRed

@chaley - PS : I've not had the errors DoctorOhh reported

And maybe you could help out here

BR

I saw that. I haven't yet built up the energy to deal with it.

[BetterRed]

Originally Posted by chaley

Those shortcuts work for me, and are indicated in Preferences as the default.

Maybe I lost them because I had previously customised them, to Ctrl+Alt+T, etc. San Fairy Anne, I can customise them again, it is a Portable install for testing/investigating V3.

BR

[DoctorOhh]

Originally Posted by chaley

@DoctorOhh: do you use QV? If so, have you tried changing the preference (Preferences / Look & Feel / Quickview) for which columns are shown in the QV window?

I've never used Quickview, didn't even realize that section in the preferences existed. A nice feature for viewing secondary series or universes without changing the main focus.

[theducks]

Originally Posted by DoctorOhh

I've never used Quickview, didn't even realize that section in the preferences existed.

I occasionally use QV and I also did not know about options

[chaley]

Originally Posted by DoctorOhh

I've never used Quickview, didn't even realize that section in the preferences existed. A nice feature for viewing secondary series or universes without changing the main focus.

Originally Posted by theducks

I occasionally use QV and I also did not know about options

It didn't until this release.