Possible (or not) bug in 2.0: Selecting items in Customize Toolbar

[arspr]

A possible or not bug in Customize Toolbar.

Go to Customize Toolbar.

Click in one item in order to select it.

Click in other item.

The first one is maintained selected, (so you have two selected items).



I don't really remember how 1.xx worked but this behaviour feels really alien to me and I don't remember having this feeling when I customized the toolbar long time ago. In "Windows standard", that behaviour is expected if you Ctrl+Click, but if you just Click on a new item the first one should be unselected. For that behaviour to be "naturally" expected, a selection rectangle should be drawn beside the item.

A bug or design criteria?

[theducks]

Originally Posted by arspr

A possible or not bug in Customize Toolbar.

Go to Customize Toolbar.

Click in one item in order to select it.

Click in other item.

The first one is maintained selected, (so you have two selected items).



I don't really remember how 1.xx worked but this behaviour feels really alien to me and I don't remember having this feeling when I customized the toolbar long time ago. In "Windows standard", that behaviour is expected if you Ctrl+Click, but if you just Click on a new item the first one should be unselected. For that behaviour to be "naturally" expected, a selection rectangle should be drawn beside the item.

A bug or design criteria?

This is previous version behavior. they stay selected unless cancelled

[BetterRed]

Originally Posted by arspr

A possible or not bug in Customize Toolbar.

Go to Customize Toolbar.

Click in one item in order to select it.

Click in other item.

The first one is maintained selected, (so you have two selected items).



I don't really remember how 1.xx worked but this behaviour feels really alien to me and I don't remember having this feeling when I customized the toolbar long time ago. In "Windows standard", that behaviour is expected if you Ctrl+Click, but if you just Click on a new item the first one should be unselected. For that behaviour to be "naturally" expected, a selection rectangle should be drawn beside the item.

A bug or design criteria?

@aspr - It's always been thus, surely the fact that a selected item remains highlighted is indication enough that the items can me multiply selected.

BR

[arspr]

OK then but nevertheless I still think it's not a truly coherent design.

I mean, even in Calibre main window, when you click in another item the first one is deselected. That's the expected behaviour, at least in a Windows environment: you can select multiple items, (Ctrl+Click, Shift+Click), but you work in single item mode by default...

Maybe a default "Ctrl+Click" behaviour could be desirable in certain parts, but then the user should have some kind of clue about it, as example, the mentioned selection rectangle marks. In the current way (with no previous identification) it really feels like a bug... (The fact that the selected item remains highlighted is not enough indication, it's the "bug" itself).

Nevertheless a very minor issue.

[kovidgoyal]

https://github.com/kovidgoyal/calibr...7b192c7c925693

[BetterRed]

Kovid, will that change result in the calibre Preferences two list selection behaviour being at variance with the calibre Tag Editor two list selection behaviour?

If so, and the Tag editor is changed to be coherent with Preferences->Toolbars then could there be an associated tweak - use ExtendedSelection or MultiSelection in the Tag Editor.

I use the Tag Editor 10-20 times a day; for me at least, having to hold down the Ctrl key to make multiple selections would enfeeble calibre rather than enhance it.

In other contexts I often inadvertently let go of the Ctrl key and lose my prior selections, and I've seen other folks do likewise. Its one of the reasons I like Mark books toggle and show; and its a reason I don't use Windows Explorer much, the file manager I do use has a 'Sticky selection' switch.

I wont be bothered by not having multi select in Preferences->Toolbars because I don't often use it.

PS : maybe there other left->right selection lists in calibre that currently use the multiple-selection mode.

BR

[kovidgoyal]

It serves a useful purpose in the tag editor, I dont intend to change it there. You often want to select multiple items in the tag editor. In the toolbar preferences, that is not the case, so it is better to stick to the usual convention to avoid confusing people.

[BetterRed]

- common sense rulz

BR