View Single Post
Old 09-18-2023, 11:10 AM   #239
thiago.eec
Wizard
thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.
 
Posts: 1,235
Karma: 1419583
Join Date: Dec 2016
Location: Goiânia - Brazil
Device: iPad, Kindle Paperwhite, Kindle Oasis
Quote:
Originally Posted by ownedbycats View Post
I see that now. Maybe change the dialog to indicate books are updated?
Added an extra message if some books were just updated.

Quote:
Originally Posted by ownedbycats View Post
How would I get rid of an empty genre? I'm not sure how this happened. I looked in the JSON and found the book it was associated with. I wonder why it didn't appear in Genre.
The problem was that you have two identical 'tag leafs': 'Mystery' and 'Fiction.Mystery'. Also, you have the same* book listed twice (one in each tag). *Same title/author, but different page count
This is fixed now.

Quote:
Originally Posted by ownedbycats View Post
EDIT: Also, Statistics > By Genre > All doesn't seem to be working.
Fixed. It now shows the most read genres in all the years.

Quote:
Originally Posted by Comfy.n View Post
I'm using 1.1.7... While attempting to log the steps in order to reproduce this on a clean slate, I just noticed this: I hit the clear database, got the confirmation message "All existing data will be permanently deleted. Do you want to proceed?", but the Edit Goal Window wouldn't update, as it would still show years 1990 and 2023, with no book records... Then after opening it again after some time, it was actually cleared
Fixed.


Quote:
Originally Posted by Comfy.n View Post
This is on a clean slate in v1.1.7, after clearing the database: even 2023 records don't get added.
Fixed. As for your other problems, I will need the exact steps to reproduce, since I could not reproduce it here.

Quote:
Originally Posted by ownedbycats View Post
Suggestion, if it makes sense: When using the 'add to reading goal' menu option, an option to add a value to a column. I would use the same readinggoal:yyyy in #admintags that I use as the autoadd value.
I'll see what I can do.

Quote:
Originally Posted by ownedbycats View Post
Unexpected behaviour: If I open Edit Reading Goal, click one of the headers (Want to Read, etc), then Mark Selected Books, I get an empty marked:2023 search. I'd expect either it to mark all the 'want to read' books or to get an error.
Fixed. I was not sure how to proceed here: consider it an empty selection (like it happens for the other buttons), or let it mark all the books in that shelf. I ended up choosing the second approach. Although it may be a little inconsistent, this is just 'marking', so no change to the database.

Quote:
Originally Posted by ownedbycats View Post
This error happens trying to open records if any were added in this version (older ones are still okay)
Code:
'NoneType' object has no attribute 'astimezone'
I could not reproduce it here:
1) Add a new book to the current year (or other year)
2) Open the 'Edit reading goal' dialog
3) Click on the added book
4) Click on the 'Show records' button
5) Records are shown
6) Deleting records also works

Test the new version that will be released in a few moments and tell me if it still happens. If so, please give me the complete steps to reproduce.

Last edited by thiago.eec; 09-18-2023 at 11:37 AM.
thiago.eec is offline   Reply With Quote