View Single Post
Old 10-08-2020, 09:17 AM   #923
JimmXinu
Plugin Developer
JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.
 
JimmXinu's Avatar
 
Posts: 7,028
Karma: 4604637
Join Date: Dec 2011
Location: Midwest USA
Device: Kobo Clara Colour running KOReader
Quote:
Originally Posted by ownedbycats View Post
Is there a way to check that I didn't break anything? Reading List > View list shows all the books are on the list.
I'm not sure what there might be to break. The worst that can happen is your series common doesn't reflect the list. Reading the code, I think when you next change the list, RL will basically reset the series to be the list again.

I would suggest, that instead of asking, it would be quicker and more accurate in most cases to setup a test case and try things out to see what happens when you have specific behavior questions.

Quote:
Originally Posted by ownedbycats View Post
EDIT: Also, I set a keyboard shortcut to add a book to the reading list. However every time I use it it refreshes the tag browser (e.g. if I have selected things in it the pluses and minuses go away, and also temporarily glitches the Job Spy user category icons). Is that supposed to happen?
As far as I know, RL calls the appropriate Calibre methods to alert Calibre about which book ids have been changed and whether tags need to be recounted due to changes. RL calls gui.tags_view.recount(), but only when tags change, and gui.library_view.model().refresh_ids(<changed_id>) for any books with changes.

What Calibre and other plugins do with it is outside Reading List's control.

Quote:
Originally Posted by JSWolf View Post
Is this ready for release?
I don't know--there's been no feedback either for or against the change. I suppose we can call 10 downloads with no complaints implicit positive feedback?
JimmXinu is offline   Reply With Quote