View Single Post
Old 07-31-2013, 12:09 PM   #528
jgoguen
Generally Awesome Person
jgoguen ought to be getting tired of karma fortunes by now.jgoguen ought to be getting tired of karma fortunes by now.jgoguen ought to be getting tired of karma fortunes by now.jgoguen ought to be getting tired of karma fortunes by now.jgoguen ought to be getting tired of karma fortunes by now.jgoguen ought to be getting tired of karma fortunes by now.jgoguen ought to be getting tired of karma fortunes by now.jgoguen ought to be getting tired of karma fortunes by now.jgoguen ought to be getting tired of karma fortunes by now.jgoguen ought to be getting tired of karma fortunes by now.jgoguen ought to be getting tired of karma fortunes by now.
 
Posts: 1,100
Karma: 2191133
Join Date: Jan 2013
Location: /dev/kmem
Device: Kobo Clara HD, Kindle Oasis
Quote:
Originally Posted by met67 View Post
To keep you busy during your wait () , I've been playing with the plugin's code and managed to put together a version which doesn't nest KoboSpans.
Since I can't make a git patch (can't use git...), can I send you a normal diff (or the full container.py) file?
The diffs are relatively small...
My approach is to use a <DUMMY> tag as a container for the spans generated by a node's text and than remove it when appending it to the originating node.

EDIT: spoke too soon
What do you mean, "can't use Git"? Git is easy :P Relative to bzr anyway.

If you have access to a UNIX-ish system, the output of "diff -u" is fine. If you can do a GitHub pull request or a standard Git pull request, that would be best since then it records you as the author.
jgoguen is offline   Reply With Quote