06-22-2011, 06:13 PM | #31 |
Calibre Plugins Developer
Posts: 4,673
Karma: 2162246
Join Date: Oct 2010
Location: Australia
Device: Kindle Oasis
|
Thx for the debate on this guys. So to summarise the state of play as I understand it...
|
06-22-2011, 06:40 PM | #32 |
creator of calibre
Posts: 44,333
Karma: 23661992
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
|
Seems about right
|
Advert | |
|
06-22-2011, 07:38 PM | #33 |
Grand Sorcerer
Posts: 6,216
Karma: 16534894
Join Date: Sep 2009
Location: UK
Device: Kobo: KA1, ClaraHD, Forma, Libra2, Clara2E. PocketBook: TouchHD3
|
H-e-e-l-l-p-p! Most of this thread is completely over my head but the keyword cover(), from post #1 has made me reply rather than go get my duvet and sit under it singing la-la-lah-la-lah until it's all over
I have no idea whether my cosmetic Copy Cover plugin will be affected by your plans and I don't run from source to suck-it-and-see. Please can someone help me figure out whether I need to do anything? I think the following info may be relevant.
Now, do I need to get the duvet? |
06-22-2011, 07:51 PM | #34 |
creator of calibre
Posts: 44,333
Karma: 23661992
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
|
You're fine, the only difference for you is that every time you use cover(..., as_path=True) a temp file is created and the cover is copied to it. The tempfile is automatically deleted when you close calibre.
I would suggest that you use a single call to both get the cover data and test for its existence, like this: Code:
cover_data = db.cover(row, index_is_id=False, as_path=False) if cover_data is None: # no cover present else: # cover present |
06-22-2011, 08:07 PM | #35 |
Grand Sorcerer
Posts: 6,216
Karma: 16534894
Join Date: Sep 2009
Location: UK
Device: Kobo: KA1, ClaraHD, Forma, Libra2, Clara2E. PocketBook: TouchHD3
|
Well, that's made me feel a bit more relaxed
I should obviously have coded it that way to begin with. Do you advise me to do a new release just to make that change or can I leave it until I actually have a new feature to offer (if ever). |
Advert | |
|
06-22-2011, 08:29 PM | #36 |
creator of calibre
Posts: 44,333
Karma: 23661992
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
|
It's up to you, if you are the type that cannot live with the creation of all those extra temp files on all your users computers, then make an updated release.
If I were you, I would make an updated release, but then, I have a disease, just look at the number of calibre releases there are... |
06-22-2011, 08:35 PM | #37 |
Calibre Plugins Developer
Posts: 4,673
Karma: 2162246
Join Date: Oct 2010
Location: Australia
Device: Kindle Oasis
|
Luckily I don't have that disease. I can go months without releasing.
|
06-22-2011, 08:40 PM | #38 |
Grand Sorcerer
Posts: 6,216
Karma: 16534894
Join Date: Sep 2009
Location: UK
Device: Kobo: KA1, ClaraHD, Forma, Libra2, Clara2E. PocketBook: TouchHD3
|
Long may you be thus afflicted.
OK, boss, I'll get it sorted. I've been interested to see the number of my plugin downloads rocket since you released v0.8.6. About 10/day before, about 100/day since. Presumably, not a coincidence as I haven't added any functionality. |
|
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
The behavior of Apple | leebase | General Discussions | 30 | 03-17-2011 12:01 AM |
strange behavior | zeroh | Nook Color & Nook Tablet | 3 | 12-09-2010 11:14 AM |
strange behavior | valb2953 | Calibre | 1 | 11-22-2010 01:12 PM |
Tag behavior... | guyanonymous | Calibre | 1 | 11-29-2009 02:57 PM |