Improvements? New Features? post sigil 2.7.6

[kovidgoyal]

Just FYI you can use the calibre ebook-edit program for this.

ebook-edit file.epub name/of/image/file/inside/the/epub.jpeg

You would need some wrapper code to put the image into an epub skeleton before calling ebook-edit and then extracting the image after ebook-edit returns, but that is trivial to do.

[philja]

Originally Posted by KevinH

I am open to suggestions on how to handle this, the options are:

1. Add to Sigil for everyone (code is small)
2. Add to Sigil for MacOS only
3. Create a separate Helper app for everyone (but then we have to make releases)

Thoughts?

#3 would involve ongoing work so I'd go for #1 - make it available for everyone and accessible from the drop-down context in the browser pane or from the image, once opened.

[DNSB]

I'd go with the add to Sigil for everyone.

[JSWolf]

My suggestion is to add to Sigil for everyone.

[KevinH]

Okay here is a partially working first attempt at replacing the current static QtWebEngine-based ImageTab with a new ImageTab that allows some basic image adjustments.

See the attached screenshot.

Note, the toolbar shows some bad png icons I had along side the free ones that came with the original code. If we do decide to go with way then I am hoping BeckyEbook will volunteer some of her excellent artwork to create svg based icons for all 3 icon themes.

The code as shown in the screen shot actually works but I have broken both webprinting and zooming in and out as well as broken context menus that I will have to work on yet.

But I wanted peoples feedback on making ImageTabs be able to adjust images by cropping, rotate right, rotate left, resizing, etc. instead of just being a static.

All thoughts welcome.

[DNSB]

For me, the zoom actions (in, out, screen) work but zoom is not maintained when rotating or most of the other actions. Cropping seems to disregard the selected part of the image, instead fitting part of the unzoomed image into the selection. Resize seems to work—I used it to resize the section break images in one ebook where some dimglow decided to make each instance a separate image sized them at 1920x1080 for 62 identical images. Resizing one and then doing a search/replace to replace the other 61 file names.

[KevinH]

But I haven't pushed anything to master, yet! Just an early version to my own repo.
It is not yet ready for testing. Zoom is broken as it is not tied to Sigil Zoom yet. I will check why Zoom is lost on rotate, crop, etc, and crop used to work but once inside a tab it seems to have failed somehow. Things to explore.

It is not ready for general testing.

All I am looking for is would people be okay (assuming I can get it all working) with our current static ImageTab going away and being replaced by something like this.

[DNSB]

I've removed the link to the installer and will wait until the code is moved to master before posting a new link.

[KevinH]

Originally Posted by DNSB

I've removed the link to the installer and will wait until the code is moved to master before posting a new link.

Thank you! I will keep pushing stuff to my personal repo. I think I have now fixed zoom and can now keep it after rotates and other actions.

But crop is still broken as I need to properly descale and translate coordinates somehow. Still working on it. Hopefully by end of day tomorrow most of the bugs will be ironed out.

[un_pogaz]

What is the action of the fourth icon?

Also, if crops is pretty easy-okay for PNG, for JPEG is not the same and I recommend to checkout and use jpegtran for a lossless resize and crops.

[DiapDealer]

Originally Posted by un_pogaz

What is the action of the fourth icon?

Looks like Resize to me. Rotate left, Rotate right, Crop, Resize.

[KevinH]

Yes, and the plan is to remove the zoom in and zoom out icons since the zoom bar in Sigil itself should control Zoom level leaving just the zoom to fit button in the zoom section.

All cropping and resizing is handled via QImage operations using QTransform as this approach should work across all image types supported by QImage.

[KevinH]

Still looking for thoughts on the general idea. Is this new ImageTab acceptable assuming I can get the bugs and nits ironed out?

[un_pogaz]

Originally Posted by KevinH

Still looking for thoughts on the general idea. Is this new ImageTab acceptable assuming I can get the bugs and nits ironed out?

Yes, very good. Probably make that the toolbar use the same heigth that the toolbar setting, but details.

[KevinH]

Okay, I have pushed all bug fixes to my personal repo:

https://github.com/kevinhendricks/Sigil

It seems to work now. I think I have tracked down and fixed most of the bugs, tied it to the Sigil zoom bar, put back in support for WebPrinting, removed the QMenuBar and replaced it with a pop-up Context menu, etc.

I did not push this to normal master because all my new icons are not svg. And they do not work well under both light and dark themes as they are simple pngs that virtually disappear under Dark modes. Also I have no icons versions at all for the other two major icon themes fluent, and material.

But what is there should work. So if you build your own, please pull Sigil master from my personal repo and give it a build. Let me know if you run into any trouble with basic functionality (aside from the known icon inconsistent with dark themes known issue).

Note: The web printer will only work on the actual file from the epub, and not the one with the changes you just made *until* you save your changes.

All feedback welcome. If we decide to go this way, perhaps @BeckyEbook will take a shot at making us some good svg icons that work under both dark and light themes (please, please, please!).

I am also thinking of adding a context menu item to toggle the toolbar showing, so if you do not want to use the toolbar you do not have to look at it and you can stick to the context menu.

Any and all thoughts on this potential change, please let me know.

I have added a new screenshot below: