Thoughts on new epub3 tool: generate guide from Landmarks

[DiapDealer]

Originally Posted by Doitsu

I haven't had time to test the new "optncx" branch. Will be bk.gettocid() return None for epub3 books without toc.ncx or will it raise a custom Sigil error?

It's all a part of master now, so you should be able to test the features pretty easily. And we encourage those who are able to do so, to do so. Precisely because of things like this that could be potentially overlooked.

In this case, I can confirm that bk.gettocid() returns None when no ncx exists.

My ancient NCXRemove plugin uses the following code:

ncxid = bk.gettocid()
    if ncxid is None:
        print('Error: EPUB 3.0 ebook has no NCX')
        return -1
    ncxhref = bk.id_to_href(ncxid)

without needing to resort to any Try/Except logic.

[KevinH]

BTW, the optncx branch is now merged into master and deleted. So anyone who wants to test these changes can do a pull from master.

[KevinH]

@DiapDealer - we keep saying almost exactly the same thing!

edit: So it must be true great minds think alike! ;-)

[DiapDealer]

Originally Posted by KevinH

edit: So it must be true great minds think alike! ;-)

It HAS to be.

[Doitsu]

Originally Posted by DiapDealer

In this case, I can confirm that bk.gettocid() returns None when no ncx exists.

Thanks for checking this! AFAIK, only one of my plugins uses bk.gettocid() and it'll display a warning if bk.gettocid() returns None.

[DiapDealer]

Originally Posted by Doitsu

Thanks for checking this! AFAIK, only one of my plugins uses bk.gettocid() and it'll display a warning if bk.gettocid() returns None.

Yeah ... I don't really expect much trouble at all. But I wanted to give a heads up in case someone made the assumption in their code that the ncx would always be there (since it always has been until now).

My input plugin DOCXImport will automatically create an ncx for an EPUB3, but since it will be able to be removed (or created for compatibility), there's no real hurry (or incentive) for me to modify the plugin.

I probably wouldn't change it anyway, since older versions of Sigil would still need the ncx created--and checking for specific versions of Sigil just to see if a dummy ncx should be created on import or not seems like overkill.